Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Dragan Simic" <dsimic@manjaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Maximilian Weigand" <mweigand@mweigand.net>,
	"Marek Kraus" <gamiee@pine64.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	"Diederik de Haas" <didi.debian@cknow.org>
Subject: Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote
Date: Fri, 07 Feb 2025 17:39:10 +0100	[thread overview]
Message-ID: <D7MD194WS7UL.FT324IUB9BIA@cknow.org> (raw)
In-Reply-To: <502523554b482a2e10d85d37761932a0@manjaro.org>

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

Hi Dragan,

On Fri Feb 7, 2025 at 4:01 PM CET, Dragan Simic wrote:
> On 2025-02-07 12:11, Diederik de Haas wrote:
>> Add the recommended chassis-type root node property so userspace can
>> request the form factor and adjust their behavior accordingly.
>> 
>> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
>> Link: 
>> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>
> Maybe the Link tag should be converted into a "[1]" reference?
> To me, this is more like a reference for this DT addition.
>
> In general, references can also be placed closer to the contents
> they back up, which isn't possible with Link tags, but of course
> that doesn't matter much in this case.

I generally use the "[1]" format when linking to specific claims, which
I could've done wrt the "recommended". But I considered this a general
background link and then I prefer to do it via a Link tag.

If requested by a maintainer I'll change it ofc, but otherwise I prefer
to keep it as is.

>> ---
>>  arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> index 2d3ae1544822..3613661417b2 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> @@ -9,6 +9,8 @@
>>  #include "rk3566.dtsi"
>> 
>>  / {
>> +	chassis-type = "tablet";
>> +
>>  	aliases {
>>  		mmc0 = &sdhci;
>>  	};
>
> The patch is obviously fine.  Thanks for the patch, and please feel
> free to include, regardless of the note above, my:
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Thanks :)

Cheers,
  Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]