From: "Umer Uddin" <umer.uddin@mentallysanemainliners.org>
To: <wachiturroxd150@gmail.com>
Cc: <alim.akhtar@samsung.com>, <krzk@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v1 9/9] arm64: dts: exynos990: define all PERIC USI nodes
Date: Sat, 08 Feb 2025 19:18:14 +0000 [thread overview]
Message-ID: <D7NB1L54MHGG.MHALKBC8531M@mentallysanemainliners.org> (raw)
In-Reply-To: <20250205222223.613-10-wachiturroxd150@gmail.com>
Hi Denzeel, thank you for your patches.
> + samsung,mode = <USI_V2_UART>;
[...]
> + samsung,mode = <USI_V2_I2C>;
Although these definitions are valid, there are two issues. these will
never compile as you have forgotten to include the header file
"dt-bindings/soc/samsung,exynos-usi.h". Also USI_V2* definitions are
deprecated and you shoulud use USI_MODE* definitions instead.
> + fifo-depth = <256>
You are missing a semi-colon. (This applies for nodes spi_8, spi_9 and
spi_10).
Please rectify these errors.
Regards, Umer
next prev parent reply other threads:[~2025-02-08 19:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 22:22 [PATCH v1 0/9] Add PERIC0/1 support for Exynos 990 Denzeel Oliva
2025-02-05 22:22 ` [PATCH v1 1/9] dt-bindings: clock: samsung,exynos990-clock: add PERIC0/1 clock management unit Denzeel Oliva
2025-02-06 7:41 ` Krzysztof Kozlowski
2025-02-05 22:22 ` [PATCH v1 2/9] dt-bindings: i2c: exynos5: add samsung,exynos990-hsi2c compatible Denzeel Oliva
2025-02-06 7:41 ` Krzysztof Kozlowski
2025-02-05 22:22 ` [PATCH v1 3/9] dt-bindings: serial: samsung: add Exynos990 compatible Denzeel Oliva
2025-02-06 7:42 ` Krzysztof Kozlowski
2025-02-05 22:22 ` [PATCH v1 4/9] dt-bindings: samsung: usi: add exynos990-usi compatible Denzeel Oliva
2025-02-05 22:22 ` [PATCH v1 5/9] spi: dt-bindings: samsung: add samsung,exynos990-spi compatible Denzeel Oliva
2025-02-06 7:42 ` Krzysztof Kozlowski
2025-02-05 22:22 ` [PATCH v1 6/9] dt-bindings: soc: samsung: exynos-sysreg: add compatibles peric0/1 sysreg for Exynos990 Denzeel Oliva
2025-02-05 22:22 ` [PATCH v1 7/9] clk: samsung: exynos990: add support for CMU_PERIC0/1 Denzeel Oliva
2025-02-05 22:22 ` [PATCH v1 8/9] spi: s3c64xx: add support exynos990-spi to new port config data Denzeel Oliva
2025-02-05 22:22 ` [PATCH v1 9/9] arm64: dts: exynos990: define all PERIC USI nodes Denzeel Oliva
2025-02-08 19:18 ` Umer Uddin [this message]
[not found] ` <CABeP6EGt1vOyxbc=vnCjBSimERLTV5_QV5Ph8p3SP4vc_z2=nQ@mail.gmail.com>
2025-02-09 10:20 ` Krzysztof Kozlowski
2025-02-06 7:45 ` [PATCH v1 0/9] Add PERIC0/1 support for Exynos 990 Krzysztof Kozlowski
2025-02-07 15:21 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7NB1L54MHGG.MHALKBC8531M@mentallysanemainliners.org \
--to=umer.uddin@mentallysanemainliners.org \
--cc=alim.akhtar@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.