Re: [docs] [PATCH 3/3] reproducible-builds: add a "How to" section with OEQA* variables

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Yoann,

On Sun Feb 9, 2025 at 11:46 PM CET, Yoann Congal via lists.yoctoproject.org wrote:
> Le 07/02/2025 à 10:12, Quentin Schulz a écrit :
>> Hi Yoann,
>
> Hi,
>
>> On 2/6/25 7:17 PM, Yoann Congal wrote:
>>> Le 06/02/2025 à 17:08, Quentin Schulz a écrit :
>>>> Hi Yoann,
>>>>
>>>> On 2/6/25 2:18 PM, Yoann Congal via lists.yoctoproject.org wrote:
>>>>> From: Yoann Congal <yoann.congal@smile.fr>
>>>>>
>>>>> Shows an example of the new variable
>>>>> OEQA_REPRODUCIBLE_TEST_LEAF_TARGETS
>>>>> and still mention OEQA_REPRODUCIBLE_TEST_TARGET/SSTATE_TARGETS that
>>>>> were
>>>>> shown earlier.
>>>>>
>>>>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>>>>> Reviewed-by: Guillaume Swaenepoel <guillaume.swaenepoel@smile.fr>
>> 
>> Since this is your v1, I believe you're not allowed to provide Reviewed-
>> by/Acked-by/Tested-by/etc... given privately. Guillaume should give
>> their Reviewed-by on the mailing list before you can add it.
>
> I did not know this was a thing.
> I did private reviews (with my Reviewed-By) for my coworkers for more
> than 2 years now and nobody told me.
>
> I'll remove it for v3.

Also, if you add a cover letter to the series, and if Guillaume sends their
Reviewed-by in reply to the cover-letter, it counts for the whole series. At
least, that's how b4 behaves on my side when applying the patches. So Guillaume
doesn't have to reply to each email. :)

Antonin

--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com