All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Yoann Congal <yoann.congal@smile.fr>, docs@lists.yoctoproject.org
Cc: Guillaume Swaenepoel <guillaume.swaenepoel@smile.fr>
Subject: Re: [docs] [PATCH 3/3] reproducible-builds: add a "How to" section with OEQA* variables
Date: Fri, 7 Feb 2025 10:12:56 +0100	[thread overview]
Message-ID: <cdef73b7-8b73-447f-ba06-8256f5ac8f0c@cherry.de> (raw)
In-Reply-To: <481d5eeb-7042-478c-b4cb-86b1981b5a8d@smile.fr>

Hi Yoann,

On 2/6/25 7:17 PM, Yoann Congal wrote:
> 
> 
> Le 06/02/2025 à 17:08, Quentin Schulz a écrit :
>> Hi Yoann,
>>
>> On 2/6/25 2:18 PM, Yoann Congal via lists.yoctoproject.org wrote:
>>> From: Yoann Congal <yoann.congal@smile.fr>
>>>
>>> Shows an example of the new variable OEQA_REPRODUCIBLE_TEST_LEAF_TARGETS
>>> and still mention OEQA_REPRODUCIBLE_TEST_TARGET/SSTATE_TARGETS that were
>>> shown earlier.
>>>
>>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>>> Reviewed-by: Guillaume Swaenepoel <guillaume.swaenepoel@smile.fr>

Since this is your v1, I believe you're not allowed to provide 
Reviewed-by/Acked-by/Tested-by/etc... given privately. Guillaume should 
give their Reviewed-by on the mailing list before you can add it.

[...]
>>> +This will test the reproducibility of ``my-recipe`` but will use the
>>> +:ref:`Shared State <overview-manual/concepts:Shared State>` for most its
>>> +dependencies.
>>> +
>>> +You can have finer control on the test with:
>>> +
>>> +- :term:`OEQA_REPRODUCIBLE_TEST_TARGET`: lists recipes to be built,
>>
>> Reading this I'm wondering if this includes the recipes that will be
>> built using sstate-cache as well, i.e. all recipes that will be built?
> 
> OEQA_REPRODUCIBLE_TEST_TARGET is the list of all recipes to build twice
> (once with sstate globally enabled, once with sstate globally disabled)
> 
> Before the second build, the OEQA_REPRODUCIBLE_TEST_SSTATE_TARGETS set
> of recipes will be built using sstate so that the second build (without
> sstate) does not have to build them from scratch.
> 

This is actually documented at the end of 
https://docs.yoctoproject.org/test-manual/reproducible-builds.html#can-we-prove-the-project-is-reproducible. 
I feel like a reminder wouldn't be too bad of an idea in this section 
even though it follows the one it's explained in, but not a requirement 
per-se, up to you.

> We usually want OEQA_REPRODUCIBLE_TEST_SSTATE_TARGETS to be a subset of
> the dependencies of OEQA_REPRODUCIBLE_TEST_TARGET but it not enforced by
> the test.
> 

If my understand is correct, OEQA_REPRODUCIBLE_TEST_TARGET could be a 
recipe A and OEQA_REPRODUCIBLE_TEST_SSTATE_TARGETS could be dependencies 
of that recipe A, so it's not necessarily a subset? But they should 
relate otherwise they are noop?

Thanks for the explanation!

Cheers,
Quentin


  reply	other threads:[~2025-02-07  9:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 13:18 [PATCH 1/3] ref-manual/variables: document OEQA_REPRODUCIBLE_TEST_LEAF_TARGETS Yoann Congal
2025-02-06 13:18 ` [PATCH 2/3] reproducible-builds: change/add titles in the "How" section Yoann Congal
2025-02-06 13:18 ` [PATCH 3/3] reproducible-builds: add a "How to" section with OEQA* variables Yoann Congal
2025-02-06 16:08   ` [docs] " Quentin Schulz
2025-02-06 18:17     ` Yoann Congal
2025-02-07  9:12       ` Quentin Schulz [this message]
2025-02-09 22:46         ` Yoann Congal
2025-02-10 12:11           ` Antonin Godard
2025-02-10 17:52           ` Quentin Schulz
2025-02-11 23:37             ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdef73b7-8b73-447f-ba06-8256f5ac8f0c@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=docs@lists.yoctoproject.org \
    --cc=guillaume.swaenepoel@smile.fr \
    --cc=yoann.congal@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.