Re: [PATCH v2 02/14] ppc/xive: Rename ipb_to_pipr() to xive_ipb_to_pipr()

["Nicholas Piggin" <npiggin@gmail.com>]

On Tue Dec 10, 2024 at 10:05 AM AEST, Michael Kowal wrote:
> Renamed function to follow the convention of the other function names.
>
> Signed-off-by: Michael Kowal <kowal@linux.ibm.com>

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  include/hw/ppc/xive.h | 16 ++++++++++++----
>  hw/intc/xive.c        | 22 ++++++----------------
>  2 files changed, 18 insertions(+), 20 deletions(-)
>
> diff --git a/include/hw/ppc/xive.h b/include/hw/ppc/xive.h
> index ebee982528..41a4263a9d 100644
> --- a/include/hw/ppc/xive.h
> +++ b/include/hw/ppc/xive.h
> @@ -130,11 +130,9 @@
>   *   TCTX   Thread interrupt Context
>   *
>   *
> - * Copyright (c) 2017-2018, IBM Corporation.
> - *
> - * This code is licensed under the GPL version 2 or later. See the
> - * COPYING file in the top-level directory.
> + * Copyright (c) 2017-2024, IBM Corporation.
>   *
> + * SPDX-License-Identifier: GPL-2.0-or-later
>   */
>  
>  #ifndef PPC_XIVE_H
> @@ -510,6 +508,16 @@ static inline uint8_t xive_priority_to_ipb(uint8_t priority)
>          0 : 1 << (XIVE_PRIORITY_MAX - priority);
>  }
>  
> +/*
> + * Convert an Interrupt Pending Buffer (IPB) register to a Pending
> + * Interrupt Priority Register (PIPR), which contains the priority of
> + * the most favored pending notification.
> + */
> +static inline uint8_t xive_ipb_to_pipr(uint8_t ibp)
> +{
> +    return ibp ? clz32((uint32_t)ibp << 24) : 0xff;
> +}
> +
>  /*
>   * XIVE Thread Interrupt Management Aera (TIMA)
>   *
> diff --git a/hw/intc/xive.c b/hw/intc/xive.c
> index 245e4d181a..7b06a48139 100644
> --- a/hw/intc/xive.c
> +++ b/hw/intc/xive.c
> @@ -3,8 +3,7 @@
>   *
>   * Copyright (c) 2017-2018, IBM Corporation.
>   *
> - * This code is licensed under the GPL version 2 or later. See the
> - * COPYING file in the top-level directory.
> + * SPDX-License-Identifier: GPL-2.0-or-later
>   */
>  
>  #include "qemu/osdep.h"
> @@ -27,15 +26,6 @@
>   * XIVE Thread Interrupt Management context
>   */
>  
> -/*
> - * Convert an Interrupt Pending Buffer (IPB) register to a Pending
> - * Interrupt Priority Register (PIPR), which contains the priority of
> - * the most favored pending notification.
> - */
> -static uint8_t ipb_to_pipr(uint8_t ibp)
> -{
> -    return ibp ? clz32((uint32_t)ibp << 24) : 0xff;
> -}
>  
>  static uint8_t exception_mask(uint8_t ring)
>  {
> @@ -159,7 +149,7 @@ static void xive_tctx_set_cppr(XiveTCTX *tctx, uint8_t ring, uint8_t cppr)
>       * Recompute the PIPR based on local pending interrupts.  The PHYS
>       * ring must take the minimum of both the PHYS and POOL PIPR values.
>       */
> -    pipr_min = ipb_to_pipr(regs[TM_IPB]);
> +    pipr_min = xive_ipb_to_pipr(regs[TM_IPB]);
>      ring_min = ring;
>  
>      /* PHYS updates also depend on POOL values */
> @@ -169,7 +159,7 @@ static void xive_tctx_set_cppr(XiveTCTX *tctx, uint8_t ring, uint8_t cppr)
>          /* POOL values only matter if POOL ctx is valid */
>          if (pool_regs[TM_WORD2] & 0x80) {
>  
> -            uint8_t pool_pipr = ipb_to_pipr(pool_regs[TM_IPB]);
> +            uint8_t pool_pipr = xive_ipb_to_pipr(pool_regs[TM_IPB]);
>  
>              /*
>               * Determine highest priority interrupt and
> @@ -193,7 +183,7 @@ void xive_tctx_ipb_update(XiveTCTX *tctx, uint8_t ring, uint8_t ipb)
>      uint8_t *regs = &tctx->regs[ring];
>  
>      regs[TM_IPB] |= ipb;
> -    regs[TM_PIPR] = ipb_to_pipr(regs[TM_IPB]);
> +    regs[TM_PIPR] = xive_ipb_to_pipr(regs[TM_IPB]);
>      xive_tctx_notify(tctx, ring);
>  }
>  
> @@ -841,9 +831,9 @@ void xive_tctx_reset(XiveTCTX *tctx)
>       * CPPR is first set.
>       */
>      tctx->regs[TM_QW1_OS + TM_PIPR] =
> -        ipb_to_pipr(tctx->regs[TM_QW1_OS + TM_IPB]);
> +        xive_ipb_to_pipr(tctx->regs[TM_QW1_OS + TM_IPB]);
>      tctx->regs[TM_QW3_HV_PHYS + TM_PIPR] =
> -        ipb_to_pipr(tctx->regs[TM_QW3_HV_PHYS + TM_IPB]);
> +        xive_ipb_to_pipr(tctx->regs[TM_QW3_HV_PHYS + TM_IPB]);
>  }
>  
>  static void xive_tctx_realize(DeviceState *dev, Error **errp)