Re: [PATCH v2 2/5] ipmi: add fwinfo to pci ipmi devices

["Nicholas Piggin" <npiggin@gmail.com>]

On Tue Apr 1, 2025 at 11:09 PM AEST, Corey Minyard wrote:
> On Tue, Apr 01, 2025 at 09:44:09PM +1000, Nicholas Piggin wrote:
>> This requires some adjustments to callers to avoid possible behaviour
>> changes for PCI devices.
>> 
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>> ---
>>  include/hw/ipmi/ipmi.h     |  5 +++++
>>  hw/acpi/ipmi.c             |  2 +-
>>  hw/ipmi/isa_ipmi_bt.c      |  1 +
>>  hw/ipmi/isa_ipmi_kcs.c     |  1 +
>>  hw/ipmi/pci_ipmi_bt.c      | 12 ++++++++++++
>>  hw/ipmi/pci_ipmi_kcs.c     | 11 +++++++++++
>>  hw/smbios/smbios_type_38.c |  6 +++++-
>>  7 files changed, 36 insertions(+), 2 deletions(-)
>> 
>> diff --git a/include/hw/ipmi/ipmi.h b/include/hw/ipmi/ipmi.h
>> index 77a7213ed93..71c4efac8cd 100644
>> --- a/include/hw/ipmi/ipmi.h
>> +++ b/include/hw/ipmi/ipmi.h
>> @@ -90,6 +90,11 @@ typedef struct IPMIFwInfo {
>>      } memspace;
>>  
>>      int interrupt_number;
>> +    enum {
>> +        IPMI_NO_IRQ = 0,
>> +        IPMI_ISA_IRQ,
>> +        IPMI_PCI_IRQ,
>> +    } irq;
>
> In addition to Phillippe's comment, can you name this "irq_source" to
> make it clear what it is?

Sure.

I wonder now looking at fwinfo if I should put protocol in there
too instead of in the class.

Thanks,
Nick