All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Quentin Schulz" <quentin.schulz@cherry.de>,
	<docs@lists.yoctoproject.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [docs] [PATCH 1/2] poky.yaml: introduce DISTRO_LATEST_TAG
Date: Wed, 23 Apr 2025 11:33:28 +0200	[thread overview]
Message-ID: <D9DWY617J6W5.1G9WMLH95TIIF@bootlin.com> (raw)
In-Reply-To: <62fb508b-741f-458b-ab7a-2ceed64a95be@cherry.de>

Hi Quentin,

On Fri Apr 18, 2025 at 1:28 PM CEST, Quentin Schulz wrote:
[...]
>>> I seem to recall we wanted the variables set by set_versions.py to still
>>> be able to build the docs from tarballs and not force the use of git
>>> repos? But it seems like we force to fetch git tags at the very
>>> beginning of the Python script.
>> 
>>    $ make html
>>    ./set_versions.py
>>    Please run 'git fetch --tags' before building the documentation
>>    make: *** [Makefile:72: html] Error 1
>> 
>> It is indeed a bug!
>> Created one here: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15834
>> 
>>> So I'm wondering if we should only have variables that aren't replaced
>>> in poky.yaml.in and eventually have the ones set_versions.py adds in
>>> poky.yaml (instead of replacing for example) documented in comments to
>>> explain what they are and in which context(s) to use them?
>> 
>> That would be a bit cleaner yes.
>> 
>> Maybe standards.md would be a good place? i.e.:
>> "Use &DISTRO; in the docs when wanting to refer to the latest possible version"
>> "Use &DISTRO_LATEST_TAG; in the docs when wanting to refer to the latest
>> existing tag"
>> etc.
>> 
>
> If we need to restore building the docs from tarballs, then we need 
> default values (and appropriate ones!) in poky.yaml.in. We could still 
> explain proper usage in standards.md , though, up to you.

I discussed this with Richard the other day, and it was decided to not support
building the docs from tarballs in the end. As mentioned in the ticket above, I
will simply state that the docs must be built from the Git repository in a
message when trying to build from a tarball.

> I would simply split the file in two with a big comment before the 
> second section where we would define overridden variables?

Yep, re-organizing the file seems like a good approach to me too - easy and
effective.

> I don't think we should be using &DISTRO; anymore? Most of the time we 
> don't want to be printing .999 on the landing page of 
> docs.yoctoproject.org! For the dev page, that's different.

I would like to agree, but at the same time, wouldn't it be confusing to have a
real tag (e.g. 5.1.8) when reading for the latest tip of the branch? It would be
somewhat accurate, but not _stricty_ accurate as to which version of the doc you
are actually reading (the latest tip).

I'm trying to think of a way to make it clear that 999 represent the branch's
tip.

Some ideas to replace or append to the 999:

"5.1 (<short commit sha>)"
"5.1.999 (<short commit sha>)"
"5.1+<short commit sha>"
"5.1+<short commit sha>+<branch name>"

Maybe just using an output from `git describe` (modified to render what we want)
could be enough?

> Cheers,
> Quentin

Thanks,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2025-04-23  9:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09  9:55 [PATCH 0/2] Fix broken links when building on branch tip Antonin Godard
2025-04-09  9:55 ` [PATCH 1/2] poky.yaml: introduce DISTRO_LATEST_TAG Antonin Godard
2025-04-14 12:18   ` [docs] " Quentin Schulz
2025-04-16  7:46     ` Antonin Godard
2025-04-16  9:58       ` Quentin Schulz
2025-04-17  7:21         ` Antonin Godard
2025-04-18 11:28           ` Quentin Schulz
2025-04-23  9:33             ` Antonin Godard [this message]
2025-04-23  9:56               ` Quentin Schulz
2025-05-13  8:28                 ` Antonin Godard
2025-05-15  7:50                   ` Quentin Schulz
2025-05-22  9:51                     ` Antonin Godard
2025-05-22 12:13                       ` Quentin Schulz
2025-04-09  9:55 ` [PATCH 2/2] Fix dead links that use the DISTRO macro Antonin Godard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9DWY617J6W5.1G9WMLH95TIIF@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=quentin.schulz@cherry.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.