From: "Benno Lossin" <lossin@kernel.org>
To: "Remo Senekowitsch" <remo@buenzli.dev>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v4 6/9] rust: device: Add bindings for reading device properties
Date: Tue, 20 May 2025 09:40:21 +0200 [thread overview]
Message-ID: <DA0TG9P9N7CI.3STZPSRIV6NDX@kernel.org> (raw)
In-Reply-To: <DA0T1M8YEHZ9.1AW3IGD1IZX7Z@kernel.org>
On Tue May 20, 2025 at 9:21 AM CEST, Benno Lossin wrote:
> On Mon May 19, 2025 at 9:51 PM CEST, Remo Senekowitsch wrote:
>> On Mon May 19, 2025 at 6:55 PM CEST, Danilo Krummrich wrote:
>>> Also, the PropertyInt trait itself has to be unsafe, given that it contains
>>> unsafe functions.
>>
>> I don't think a trait necessarily has to be marked unsafe just because
>> it has unsafe methods. Marking a trait as unsafe means that implementors
>> of the trait must uphold some invariants. This is not the case here
>> IIUC. Here's a good explanation of my understanding: [1]
>
> Yes this is correct, I don't think that the trait itself should be
> unsafe.
Ahh, I understood now why Danilo suggested this: if the trait should
guarantee that `fwnode_property_read_*_array` is called, then the trait
would have to be `unsafe`.
But I don't think that's necessary, we don't have any other unsafe code
that needs to rely on that.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-05-20 7:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 17:31 [PATCH v4 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-05-12 13:59 ` Danilo Krummrich
2025-05-12 14:12 ` Danilo Krummrich
2025-05-04 17:31 ` [PATCH v4 2/9] rust: device: Enable accessing the FwNode of a Device Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 3/9] rust: device: Move property_present() to FwNode Remo Senekowitsch
2025-05-12 17:29 ` Rob Herring
2025-05-12 17:44 ` Danilo Krummrich
2025-05-04 17:31 ` [PATCH v4 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-05-05 5:14 ` Dirk Behme
2025-05-05 13:02 ` Remo Senekowitsch
2025-05-05 15:37 ` Rob Herring
2025-05-05 15:53 ` Remo Senekowitsch
2025-05-05 16:12 ` Danilo Krummrich
2025-05-05 18:33 ` Rob Herring
2025-05-12 17:09 ` Rob Herring
2025-05-04 17:31 ` [PATCH v4 6/9] rust: device: Add bindings for reading device properties Remo Senekowitsch
2025-05-12 13:36 ` Danilo Krummrich
2025-05-19 15:43 ` Remo Senekowitsch
2025-05-19 16:55 ` Danilo Krummrich
2025-05-19 19:51 ` Remo Senekowitsch
2025-05-20 7:21 ` Benno Lossin
2025-05-20 7:40 ` Benno Lossin [this message]
2025-05-20 10:37 ` Remo Senekowitsch
2025-05-20 7:37 ` Benno Lossin
2025-05-20 10:32 ` Remo Senekowitsch
2025-05-20 11:04 ` Benno Lossin
2025-05-04 17:31 ` [PATCH v4 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
2025-05-12 13:54 ` Danilo Krummrich
2025-05-12 11:49 ` [PATCH v4 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-12 12:04 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA0TG9P9N7CI.3STZPSRIV6NDX@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=remo@buenzli.dev \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.