From: Danilo Krummrich <dakr@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Remo Senekowitsch" <remo@buenzli.dev>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Saravana Kannan" <saravanak@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v4 3/9] rust: device: Move property_present() to FwNode
Date: Mon, 12 May 2025 19:44:23 +0200 [thread overview]
Message-ID: <aCIzdx8drlVMzCLk@cassiopeiae> (raw)
In-Reply-To: <20250512172957.GB3463681-robh@kernel.org>
On Mon, May 12, 2025 at 12:29:57PM -0500, Rob Herring wrote:
> On Sun, May 04, 2025 at 07:31:48PM +0200, Remo Senekowitsch wrote:
> > The new FwNode abstraction will be used for accessing all device
> > properties, so it must have the property_present method.
> >
> > It's possible to duplicate the methods on the device itself, but since
> > some of the methods on Device would have different type sigatures as the
> > ones on FwNode, this would only lead to inconsistency and confusion.
> > Hence, remove the method from Device.
> >
> > There aren't any users to update yet.
>
> But there is one going into 6.16 most likely with the cpufreq stuff[1]
> which complicates merging.
Should we target the upcoming merge window, I suggest to just add
FwNode::property_present() and remove Device::property_present() with a
subsequent patch for v6.17.
Should we not make it (which given that there are a few open points and -rc7 is
rather close is not that unlikely), we can just rebase and merge early.
>
> Rob
>
> [1] https://lore.kernel.org/all/f7e96b7da77ac217be5ccb09b9309da28fd96c90.1745218976.git.viresh.kumar@linaro.org/
next prev parent reply other threads:[~2025-05-12 17:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 17:31 [PATCH v4 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-05-12 13:59 ` Danilo Krummrich
2025-05-12 14:12 ` Danilo Krummrich
2025-05-04 17:31 ` [PATCH v4 2/9] rust: device: Enable accessing the FwNode of a Device Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 3/9] rust: device: Move property_present() to FwNode Remo Senekowitsch
2025-05-12 17:29 ` Rob Herring
2025-05-12 17:44 ` Danilo Krummrich [this message]
2025-05-04 17:31 ` [PATCH v4 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-05-05 5:14 ` Dirk Behme
2025-05-05 13:02 ` Remo Senekowitsch
2025-05-05 15:37 ` Rob Herring
2025-05-05 15:53 ` Remo Senekowitsch
2025-05-05 16:12 ` Danilo Krummrich
2025-05-05 18:33 ` Rob Herring
2025-05-12 17:09 ` Rob Herring
2025-05-04 17:31 ` [PATCH v4 6/9] rust: device: Add bindings for reading device properties Remo Senekowitsch
2025-05-12 13:36 ` Danilo Krummrich
2025-05-19 15:43 ` Remo Senekowitsch
2025-05-19 16:55 ` Danilo Krummrich
2025-05-19 19:51 ` Remo Senekowitsch
2025-05-20 7:21 ` Benno Lossin
2025-05-20 7:40 ` Benno Lossin
2025-05-20 10:37 ` Remo Senekowitsch
2025-05-20 7:37 ` Benno Lossin
2025-05-20 10:32 ` Remo Senekowitsch
2025-05-20 11:04 ` Benno Lossin
2025-05-04 17:31 ` [PATCH v4 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-05-04 17:31 ` [PATCH v4 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
2025-05-12 13:54 ` Danilo Krummrich
2025-05-12 11:49 ` [PATCH v4 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-12 12:04 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCIzdx8drlVMzCLk@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=remo@buenzli.dev \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.