Re: [[PATCH]] rust/list: replace unwrap() with ? in doctest examples

["Benno Lossin" <lossin@kernel.org>]

Hi,

Thanks for the patch, a couple comments below.

The subject of your email starts with `[[PATCH]]`, normally we use
`[PATCH]` instead. Did you use `git send-email` and `git format-patch`?

On Mon May 26, 2025 at 12:59 AM CEST, Albin Babu Varghese wrote:
> Replace panicking `unwrap()` calls in the `kernel::list` doctests with `ok_or(EINVAL)?` so they return a proper `Error` instead of panicking.

Commit messages should be wrapped to a sensible column length such as 72
characters.

Also this is missing the motivation that newcomers might get the
impression that calling `unwrap` is OK.

> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
>

No need for blank lines in the taglist.

> Link: https://github.com/Rust-for-Linux/linux/issues/1164
> Signed-off-by: Albin Babu Varghese <albinbabuvarghese20@gmail.com>
> ---
>  rust/kernel/list.rs | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)

The changes themselves look good, if we want to use the `ok_or` + error
combination. I haven't thought about this, so there might be something
better here, but it already is an improvement over the previous one.

Reviewed-by: Benno Lossin <lossin@kernel.org>

---
Cheers,
Benno