From: Alejandro Vallejo <agarciav@amd.com>
To: "Orzel, Michal" <michal.orzel@amd.com>, <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h
Date: Fri, 6 Jun 2025 12:08:54 +0200 [thread overview]
Message-ID: <DAFD99VSFIEP.1VCU7C02XMFPO@amd.com> (raw)
In-Reply-To: <633ffa7f-cf26-4ec3-a153-28404c39d882@amd.com>
On Fri Jun 6, 2025 at 10:59 AM CEST, Michal Orzel wrote:
>
>
> On 05/06/2025 21:48, Alejandro Vallejo wrote:
>> Part of an unpicking process to extract bootfdt contents independent of bootinfo
>> to a separate file for x86 to take.
>>
>> Move functions required for early FDT parsing from device_tree.h and arm's
>> setup.h onto bootfdt.h
>>
>> Declaration motion only. Not a functional change.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@amd.com>
>> ---
>> v2:
>> * Remove the u32 identifiers in the device_tree_get_u32() implementation
> I don't understand the reasoning behind changing u32->uint32_t only for one
> function in this patch while leaving others unmodified. Also what about u64?
> Either don't change any or change all.
Sure. Let's call the original u32->uint32_t change a misplaced mutation and
move on. The point is the motion, not these cleanups on top.
>
>> * Fix an existing const-stripping case.
> These points should be mentioned in the commit msg.
Sure.
>
> ~Michal
Cheers,
Alejandro
next prev parent reply other threads:[~2025-06-06 10:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 19:47 [PATCH v2 00/15] Allow x86 to unflatten DTs Alejandro Vallejo
2025-06-05 19:47 ` [PATCH v2 01/15] xen: Clean up asm-generic/device.h Alejandro Vallejo
2025-06-06 6:51 ` Jan Beulich
2025-06-06 9:55 ` Alejandro Vallejo
2025-06-06 10:03 ` Jan Beulich
2025-06-06 10:21 ` Alejandro Vallejo
2025-06-05 19:47 ` [PATCH v2 02/15] arm/gnttab: Break links between asm/grant_table.h and xen/grant_table.h Alejandro Vallejo
2025-06-06 6:52 ` Jan Beulich
2025-06-06 10:02 ` Alejandro Vallejo
2025-06-06 10:07 ` Jan Beulich
2025-06-06 10:30 ` Alejandro Vallejo
2025-06-06 12:23 ` Jan Beulich
2025-06-05 19:47 ` [PATCH v2 03/15] xen/dt: Add BOOTMOD_MICROCODE Alejandro Vallejo
2025-06-06 8:47 ` Orzel, Michal
2025-06-05 19:47 ` [PATCH v2 04/15] x86: Preinitialise all modules to be of kind BOOTMOD_UNKNOWN Alejandro Vallejo
2025-06-05 19:47 ` [PATCH v2 05/15] x86: Replace boot_module with bootmodule Alejandro Vallejo
2025-06-05 19:47 ` [PATCH v2 06/15] xen: Refactor kernel_info to have a header like boot_domain Alejandro Vallejo
2025-06-05 19:47 ` [PATCH v2 07/15] x86: Replace boot_domain with bootdomain Alejandro Vallejo
2025-06-06 23:28 ` Stefano Stabellini
2025-06-09 8:57 ` Alejandro Vallejo
2025-06-09 16:56 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h Alejandro Vallejo
2025-06-06 8:59 ` Orzel, Michal
2025-06-06 10:08 ` Alejandro Vallejo [this message]
2025-06-06 19:59 ` Stefano Stabellini
2025-06-09 8:59 ` Alejandro Vallejo
2025-06-09 16:55 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 09/15] xen/dt: Move bootinfo functions to a new bootinfo.h Alejandro Vallejo
2025-06-06 23:39 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 10/15] xen/dt: Rename bootfdt.c -> bootinfo-fdt.c Alejandro Vallejo
2025-06-05 19:48 ` [PATCH v2 11/15] xen/dt: Move bootinfo-independent helpers out of bootinfo-fdt.c Alejandro Vallejo
2025-06-06 23:43 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 12/15] xen/dt: Extract helper to map nodes to module kinds Alejandro Vallejo
2025-06-05 19:48 ` [PATCH v2 13/15] xen/dt: ifdef out DEV_DT-related bits from device_tree.{c,h} Alejandro Vallejo
2025-06-06 23:54 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 14/15] xen/dt: Allow CONFIG_DOM0LESS_BOOT to include device-tree/ Alejandro Vallejo
2025-06-06 23:55 ` Stefano Stabellini
2025-06-05 19:48 ` [PATCH v2 15/15] kconfig: Allow x86 to pick CONFIG_DOM0LESS_BOOT Alejandro Vallejo
2025-06-06 23:57 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAFD99VSFIEP.1VCU7C02XMFPO@amd.com \
--to=agarciav@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.