[oe][meta][PATCH] dropbear: add xauth runtime dependency when x11-forwarding is enabled

[oe][meta][PATCH] dropbear: add xauth runtime dependency when x11-forwarding is enabled

[Andrej Valek]

Even if enable-x11-forwarding was used, XAUTH_COMMAND failed due to missing
xauth.

Signed-off-by: Andrej Valek <andrej.v@skyrain.eu>
---
 meta/recipes-core/dropbear/dropbear_2025.88.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/dropbear/dropbear_2025.88.bb b/meta/recipes-core/dropbear/dropbear_2025.88.bb
index f203763b17..a1317d3b73 100644
--- a/meta/recipes-core/dropbear/dropbear_2025.88.bb
+++ b/meta/recipes-core/dropbear/dropbear_2025.88.bb
@@ -51,7 +51,7 @@ EXTRA_OEMAKE = 'MULTI=1 SCPPROGRESS=1 PROGRAMS="${SBINCOMMANDS} ${BINCOMMANDS}"'
 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}"
 PACKAGECONFIG[pam] = "--enable-pam,--disable-pam,libpam,${PAM_PLUGINS}"
 PACKAGECONFIG[system-libtom] = "--disable-bundled-libtom,--enable-bundled-libtom,libtommath libtomcrypt"
-PACKAGECONFIG[enable-x11-forwarding] = ""
+PACKAGECONFIG[enable-x11-forwarding] = ",,,xauth"
 
 # This option appends to CFLAGS and LDFLAGS from OE
 # This is causing [textrel] QA warning
-- 
2.34.1

Re: [OE-core] [oe][meta][PATCH] dropbear: add xauth runtime dependency when x11-forwarding is enabled

[Ross Burton]

On 5 Jun 2025, at 10:18, Andrej Valek via lists.openembedded.org <andrej.v=skyrain.eu@lists.openembedded.org> wrote:
> -PACKAGECONFIG[enable-x11-forwarding] = ""
> +PACKAGECONFIG[enable-x11-forwarding] = “,,,xauth”

It feels like this should be a recommends not a depends (so add another comma).

Whilst you’re here: do you think we should enable x11 forwarding if x11 is in DISTRO_FEATURES by default, or is there a good reason to keep it disabled by default?

Thanks,
Ross

Re: [OE-core] [oe][meta][PATCH] dropbear: add xauth runtime dependency when x11-forwarding is enabled

[Andrej Valek]

Hi Ross,

What do you mean by "should be a recommends not a depends"? AFAIK: 
PACKAGECONFIG[x] = "with,without,depends,rdepends", so I would say my 
variant is ok, or?

No, I'm fully on your side to enable the forwarding by default when x11 
is enabled.

Will you take a care of it, or should I?

BR,
Andy

On 09.06.2025 18:54, Ross Burton via lists.openembedded.org wrote:
> On 5 Jun 2025, at 10:18, Andrej Valek via lists.openembedded.org <andrej.v=skyrain.eu@lists.openembedded.org> wrote:
>> -PACKAGECONFIG[enable-x11-forwarding] = ""
>> +PACKAGECONFIG[enable-x11-forwarding] = “,,,xauth”
> It feels like this should be a recommends not a depends (so add another comma).
>
> Whilst you’re here: do you think we should enable x11 forwarding if x11 is in DISTRO_FEATURES by default, or is there a good reason to keep it disabled by default?
>
> Thanks,
> Ross
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#218301): https://lists.openembedded.org/g/openembedded-core/message/218301
> Mute This Topic: https://lists.openembedded.org/mt/113482164/3619876
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [andrej.v@skyrain.eu]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [oe][meta][PATCH] dropbear: add xauth runtime dependency when x11-forwarding is enabled

[Ross Burton]

On 10 Jun 2025, at 07:42, Andrej Valek <andrej.v@skyrain.eu> wrote:
> 
> Hi Ross,
> 
> What do you mean by "should be a recommends not a depends"? AFAIK: PACKAGECONFIG[x] = "with,without,depends,rdepends", so I would say my variant is ok, or?

https://docs.yoctoproject.org/ref-manual/variables.html#term-PACKAGECONFIG

The full syntax is with,without,depends,rdepends,rrecommends,conflicts so just adding an extra comma would make it a RRECOMMENDS not a RDEPENDS.

My reasoning is that xauth isn’t _needed_ for ssh to work, so it could be useful to be able to build it with X support but not actually install xauth in otherwise headless images.

> No, I'm fully on your side to enable the forwarding by default when x11 is enabled.
> 
> Will you take a care of it, or should I?

If you can send a second patch, that would be great.

Ross

[OE-core][meta][PATCH v2] dropbear: add xauth runtime recommends dependency on x11 DISTRO_FEATURE

[Andrej Valek]

Change enable-x11-forwarding PACKAGECONFIG to x11, while we can rely
directly on X11 DISTRO_FEATURE. Previously when enable-x11-forwarding was
used, the XAUTH_COMMAND failed due to missing xauth. So add xauth to
runtime recommends dependency and enable this behavior as default.

Signed-off-by: Andrej Valek <andrej.v@skyrain.eu>
---
 meta/recipes-core/dropbear/dropbear_2025.88.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/dropbear/dropbear_2025.88.bb b/meta/recipes-core/dropbear/dropbear_2025.88.bb
index a1317d3b73..72a886d907 100644
--- a/meta/recipes-core/dropbear/dropbear_2025.88.bb
+++ b/meta/recipes-core/dropbear/dropbear_2025.88.bb
@@ -48,10 +48,10 @@ SBINCOMMANDS = "dropbear dropbearkey dropbearconvert"
 BINCOMMANDS = "dbclient ssh scp"
 EXTRA_OEMAKE = 'MULTI=1 SCPPROGRESS=1 PROGRAMS="${SBINCOMMANDS} ${BINCOMMANDS}"'
 
-PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}"
+PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam x11', d)}"
 PACKAGECONFIG[pam] = "--enable-pam,--disable-pam,libpam,${PAM_PLUGINS}"
 PACKAGECONFIG[system-libtom] = "--disable-bundled-libtom,--enable-bundled-libtom,libtommath libtomcrypt"
-PACKAGECONFIG[enable-x11-forwarding] = ",,,xauth"
+PACKAGECONFIG[x11] = ",,,,xauth"
 
 # This option appends to CFLAGS and LDFLAGS from OE
 # This is causing [textrel] QA warning
@@ -62,7 +62,7 @@ EXTRA_OECONF:append:libc-musl = " --disable-wtmp --disable-lastlog"
 
 do_configure:append() {
 	echo "/* Dropbear features */" > ${B}/localoptions.h
-	if ${@bb.utils.contains('PACKAGECONFIG', 'enable-x11-forwarding', 'true', 'false', d)}; then
+	if ${@bb.utils.contains('PACKAGECONFIG', 'x11', 'true', 'false', d)}; then
 		echo "#define DROPBEAR_X11FWD 1" >> ${B}/localoptions.h
 	fi
 }
-- 
2.34.1

Re: [OE-core][meta][PATCH v2] dropbear: add xauth runtime recommends dependency on x11 DISTRO_FEATURE

[Mathieu Dubois-Briand]

On Mon Jun 16, 2025 at 9:37 AM CEST, Andrej Valek wrote:
> Change enable-x11-forwarding PACKAGECONFIG to x11, while we can rely
> directly on X11 DISTRO_FEATURE. Previously when enable-x11-forwarding was
> used, the XAUTH_COMMAND failed due to missing xauth. So add xauth to
> runtime recommends dependency and enable this behavior as default.
>
> Signed-off-by: Andrej Valek <andrej.v@skyrain.eu>
> ---

Hi Andrej,

It looks like the v2 depends on the v1 here. I would have been happy to
squash them, but the commit message is different, so I don't want to
interfere too much here.

Do you mind sending a v3 with a single commit?

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[oe][meta-oe][PATCH v3] dropbear: add xauth runtime recommends dependency on x11 DISTRO_FEATURE

[Andrej Valek]

Change enable-x11-forwarding PACKAGECONFIG to x11, while we can rely
directly on X11 DISTRO_FEATURE. Previously when enable-x11-forwarding was
used, the XAUTH_COMMAND failed due to missing xauth. So add xauth to
runtime recommends dependency and enable this behavior as default.

Signed-off-by: Andrej Valek <andrej.v@skyrain.eu>
---
 meta/recipes-core/dropbear/dropbear_2025.88.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/dropbear/dropbear_2025.88.bb b/meta/recipes-core/dropbear/dropbear_2025.88.bb
index f203763b17..72a886d907 100644
--- a/meta/recipes-core/dropbear/dropbear_2025.88.bb
+++ b/meta/recipes-core/dropbear/dropbear_2025.88.bb
@@ -48,10 +48,10 @@ SBINCOMMANDS = "dropbear dropbearkey dropbearconvert"
 BINCOMMANDS = "dbclient ssh scp"
 EXTRA_OEMAKE = 'MULTI=1 SCPPROGRESS=1 PROGRAMS="${SBINCOMMANDS} ${BINCOMMANDS}"'
 
-PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}"
+PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam x11', d)}"
 PACKAGECONFIG[pam] = "--enable-pam,--disable-pam,libpam,${PAM_PLUGINS}"
 PACKAGECONFIG[system-libtom] = "--disable-bundled-libtom,--enable-bundled-libtom,libtommath libtomcrypt"
-PACKAGECONFIG[enable-x11-forwarding] = ""
+PACKAGECONFIG[x11] = ",,,,xauth"
 
 # This option appends to CFLAGS and LDFLAGS from OE
 # This is causing [textrel] QA warning
@@ -62,7 +62,7 @@ EXTRA_OECONF:append:libc-musl = " --disable-wtmp --disable-lastlog"
 
 do_configure:append() {
 	echo "/* Dropbear features */" > ${B}/localoptions.h
-	if ${@bb.utils.contains('PACKAGECONFIG', 'enable-x11-forwarding', 'true', 'false', d)}; then
+	if ${@bb.utils.contains('PACKAGECONFIG', 'x11', 'true', 'false', d)}; then
 		echo "#define DROPBEAR_X11FWD 1" >> ${B}/localoptions.h
 	fi
 }
-- 
2.34.1

Patchtest results for [oe][meta-oe][PATCH v3] dropbear: add xauth runtime recommends dependency on x11 DISTRO_FEATURE

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/oe-meta-oe-v3-dropbear-add-xauth-runtime-recommends-dependency-on-x11-DISTRO_FEATURE.patch

FAIL: test target mailing list: Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists (test_mbox.TestMbox.test_target_mailing_list)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!