From: "Danilo Krummrich" <dakr@kernel.org>
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>, "Guo Ren" <guoren@kernel.org>,
"Fu Wei" <wefu@redhat.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Benno Lossin" <lossin@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Drew Fustini" <fustini@kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver
Date: Thu, 10 Jul 2025 12:17:03 +0200 [thread overview]
Message-ID: <DB8AQ15RTAJ2.3QXX8Q2FTFGCP@kernel.org> (raw)
In-Reply-To: <e8a4a821-e7e4-4bcd-a2ac-f6b684b6ceea@samsung.com>
On Thu Jul 10, 2025 at 10:42 AM CEST, Michal Wilczynski wrote:
> I was hoping you could clarify the intended merge path for this series,
> as it introduces changes to both the Rust and PWM subsystems.
>
> Is the expectation that the Rust maintainers will take the abstraction
> patches into the Rust tree first? Or would Uwe, as the PWM maintainer,
> pull the entire series? Any guidance on the coordination would be very
> helpful.
Except for the helpers I only see PWM code, so this is fully on Uwe's purview I
think.
I see that there is a new MAINTAINERS entry:
PWM SUBSYSTEM BINDINGS [RUST]
M: Michal Wilczynski <m.wilczynski@samsung.com>
S: Maintained
F: rust/helpers/pwm.c
F: rust/kernel/pwm.rs
I assume this is agreed with Uwe?
In case there's no agreement yet, the typical options are:
1) Maintain the Rust abstractions as part of the existing MAINTAINERS entry.
Optionally, the author can be added as another maintainer or reviewer.
2) Add a separate MAINTAINERS entry; patches / PRs still go through the same
subsystem tree.
3) Add a separate MAINTAINERS entry; patches don't go through the subsystem
tree (e.g. because the subsystem maintainers don't want to deal with it).
I don't recommend (3), since it's really just a fallback.
The above looks like (2). In this case I recommend to also add the C maintainers
as reviewers, such that they can easily follow along and specifiy the tree (T:).
But, of course, that's up to you and Uwe.
> I understand that it may be too late in the development cycle to merge
> the full series. If that's the case, perhaps patch 2 could be considered
> on its own, as it hasn't received comments in the last couple of
> revisions. As another possibility, patch 1 and patch 3 are dependent on
> each other and could be applied as a pair, depending on your assessment.
>
> The RISC-V driver itself would need to wait for the IoMem series merge [1].
>
> [1] - https://lore.kernel.org/rust-for-linux/20250704-topics-tyr-platform_iomem-v12-0-1d3d4bd8207d@collabora.com/
>
> Best regards,
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>, "Guo Ren" <guoren@kernel.org>,
"Fu Wei" <wefu@redhat.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Benno Lossin" <lossin@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Drew Fustini" <fustini@kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver
Date: Thu, 10 Jul 2025 12:17:03 +0200 [thread overview]
Message-ID: <DB8AQ15RTAJ2.3QXX8Q2FTFGCP@kernel.org> (raw)
In-Reply-To: <e8a4a821-e7e4-4bcd-a2ac-f6b684b6ceea@samsung.com>
On Thu Jul 10, 2025 at 10:42 AM CEST, Michal Wilczynski wrote:
> I was hoping you could clarify the intended merge path for this series,
> as it introduces changes to both the Rust and PWM subsystems.
>
> Is the expectation that the Rust maintainers will take the abstraction
> patches into the Rust tree first? Or would Uwe, as the PWM maintainer,
> pull the entire series? Any guidance on the coordination would be very
> helpful.
Except for the helpers I only see PWM code, so this is fully on Uwe's purview I
think.
I see that there is a new MAINTAINERS entry:
PWM SUBSYSTEM BINDINGS [RUST]
M: Michal Wilczynski <m.wilczynski@samsung.com>
S: Maintained
F: rust/helpers/pwm.c
F: rust/kernel/pwm.rs
I assume this is agreed with Uwe?
In case there's no agreement yet, the typical options are:
1) Maintain the Rust abstractions as part of the existing MAINTAINERS entry.
Optionally, the author can be added as another maintainer or reviewer.
2) Add a separate MAINTAINERS entry; patches / PRs still go through the same
subsystem tree.
3) Add a separate MAINTAINERS entry; patches don't go through the subsystem
tree (e.g. because the subsystem maintainers don't want to deal with it).
I don't recommend (3), since it's really just a fallback.
The above looks like (2). In this case I recommend to also add the C maintainers
as reviewers, such that they can easily follow along and specifiy the tree (T:).
But, of course, that's up to you and Uwe.
> I understand that it may be too late in the development cycle to merge
> the full series. If that's the case, perhaps patch 2 could be considered
> on its own, as it hasn't received comments in the last couple of
> revisions. As another possibility, patch 1 and patch 3 are dependent on
> each other and could be applied as a pair, depending on your assessment.
>
> The RISC-V driver itself would need to wait for the IoMem series merge [1].
>
> [1] - https://lore.kernel.org/rust-for-linux/20250704-topics-tyr-platform_iomem-v12-0-1d3d4bd8207d@collabora.com/
>
> Best regards,
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-07-10 10:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250707094926eucas1p155bd967b6986c4a999776839b1aa1fc6@eucas1p1.samsung.com>
2025-07-07 9:48 ` [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 1/7] pwm: Export `pwmchip_release` for external use Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 2/7] rust: pwm: Add Kconfig and basic data structures Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 3/7] rust: pwm: Add complete abstraction layer Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 4/7] pwm: Add Rust driver for T-HEAD TH1520 SoC Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 5/7] dt-bindings: pwm: thead: Add T-HEAD TH1520 PWM controller Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 6/7] riscv: dts: thead: Add PWM controller node Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-07 9:48 ` [PATCH v10 7/7] riscv: dts: thead: Add PWM fan and thermal control Michal Wilczynski
2025-07-07 9:48 ` Michal Wilczynski
2025-07-10 8:42 ` [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-07-10 8:42 ` Michal Wilczynski
2025-07-10 10:17 ` Danilo Krummrich [this message]
2025-07-10 10:17 ` Danilo Krummrich
2025-07-10 10:29 ` Michal Wilczynski
2025-07-10 10:29 ` Michal Wilczynski
2025-07-10 13:36 ` Uwe Kleine-König
2025-07-10 13:36 ` Uwe Kleine-König
2025-07-10 13:41 ` Danilo Krummrich
2025-07-10 13:41 ` Danilo Krummrich
2025-07-10 13:10 ` Uwe Kleine-König
2025-07-10 13:10 ` Uwe Kleine-König
2025-07-10 13:48 ` Michal Wilczynski
2025-07-10 13:48 ` Michal Wilczynski
2025-07-10 15:25 ` Uwe Kleine-König
2025-07-10 15:25 ` Uwe Kleine-König
2025-07-10 16:06 ` Danilo Krummrich
2025-07-10 16:06 ` Danilo Krummrich
2025-07-10 20:57 ` Uwe Kleine-König
2025-07-10 20:57 ` Uwe Kleine-König
2025-07-10 21:19 ` Danilo Krummrich
2025-07-10 21:19 ` Danilo Krummrich
2025-07-11 12:36 ` Michal Wilczynski
2025-07-11 12:36 ` Michal Wilczynski
2025-07-10 16:58 ` Michal Wilczynski
2025-07-10 16:58 ` Michal Wilczynski
2025-07-10 20:39 ` Uwe Kleine-König
2025-07-10 20:39 ` Uwe Kleine-König
2025-07-11 15:19 ` Michal Wilczynski
2025-07-11 15:19 ` Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8AQ15RTAJ2.3QXX8Q2FTFGCP@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.