From: "Benno Lossin" <lossin@kernel.org>
To: "Boqun Feng" <boqun.feng@gmail.com>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
<lkmm@lists.linux.dev>, <linux-arch@vger.kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Lyude Paul" <lyude@redhat.com>, "Ingo Molnar" <mingo@kernel.org>,
"Mitchell Levy" <levymitchell0@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Alan Stern" <stern@rowland.harvard.edu>
Subject: Re: [PATCH v7 5/9] rust: sync: atomic: Add atomic {cmp,}xchg operations
Date: Mon, 14 Jul 2025 12:56:01 +0200 [thread overview]
Message-ID: <DBBQ21NIC2I5.32X8ZVDIK3J4C@kernel.org> (raw)
In-Reply-To: <20250714053656.66712-6-boqun.feng@gmail.com>
On Mon Jul 14, 2025 at 7:36 AM CEST, Boqun Feng wrote:
> xchg() and cmpxchg() are basic operations on atomic. Provide these based
> on C APIs.
>
> Note that cmpxchg() use the similar function signature as
> compare_exchange() in Rust std: returning a `Result`, `Ok(old)` means
> the operation succeeds and `Err(old)` means the operation fails.
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Looks good except for the naming disputes :) So
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
> ---
> rust/kernel/sync/atomic/generic.rs | 181 ++++++++++++++++++++++++++++-
> 1 file changed, 180 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2025-07-14 10:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 5:36 [PATCH v7 0/9] LKMM generic atomics in Rust Boqun Feng
2025-07-14 5:36 ` [PATCH v7 1/9] rust: Introduce atomic API helpers Boqun Feng
2025-07-16 9:23 ` Greg Kroah-Hartman
2025-07-16 12:36 ` Miguel Ojeda
2025-07-16 12:47 ` Peter Zijlstra
2025-07-16 12:54 ` Greg Kroah-Hartman
2025-07-16 12:57 ` Miguel Ojeda
2025-07-16 13:04 ` Peter Zijlstra
2025-07-16 12:56 ` Miguel Ojeda
2025-07-14 5:36 ` [PATCH v7 2/9] rust: sync: Add basic atomic operation mapping framework Boqun Feng
2025-07-14 10:03 ` Benno Lossin
2025-07-14 13:42 ` Boqun Feng
2025-07-14 15:00 ` Benno Lossin
2025-07-14 15:34 ` Boqun Feng
2025-07-14 5:36 ` [PATCH v7 3/9] rust: sync: atomic: Add ordering annotation types Boqun Feng
2025-07-14 10:10 ` Benno Lossin
2025-07-14 14:59 ` Boqun Feng
2025-07-14 15:16 ` Benno Lossin
2025-07-14 5:36 ` [PATCH v7 4/9] rust: sync: atomic: Add generic atomics Boqun Feng
2025-07-14 10:30 ` Benno Lossin
2025-07-14 14:21 ` Boqun Feng
2025-07-14 14:30 ` Boqun Feng
2025-07-14 14:34 ` Miguel Ojeda
2025-07-14 14:53 ` Boqun Feng
2025-07-14 15:16 ` Benno Lossin
2025-07-14 15:05 ` Benno Lossin
2025-07-14 15:32 ` Boqun Feng
2025-07-15 9:36 ` Benno Lossin
2025-07-15 13:14 ` Boqun Feng
2025-07-15 15:35 ` Benno Lossin
2025-07-14 5:36 ` [PATCH v7 5/9] rust: sync: atomic: Add atomic {cmp,}xchg operations Boqun Feng
2025-07-14 10:56 ` Benno Lossin [this message]
2025-07-14 5:36 ` [PATCH v7 6/9] rust: sync: atomic: Add the framework of arithmetic operations Boqun Feng
2025-07-15 11:21 ` Benno Lossin
2025-07-15 13:33 ` Boqun Feng
2025-07-15 15:45 ` Benno Lossin
2025-07-15 16:13 ` Boqun Feng
2025-07-15 18:39 ` Benno Lossin
2025-07-15 20:13 ` Boqun Feng
2025-07-16 10:25 ` Benno Lossin
2025-07-16 14:13 ` Boqun Feng
2025-07-16 15:36 ` Benno Lossin
2025-07-16 15:48 ` Boqun Feng
2025-07-16 17:16 ` Benno Lossin
2025-07-16 17:38 ` Boqun Feng
2025-07-14 5:36 ` [PATCH v7 7/9] rust: sync: atomic: Add Atomic<u{32,64}> Boqun Feng
2025-07-14 5:36 ` [PATCH v7 8/9] rust: sync: Add memory barriers Boqun Feng
2025-07-14 5:36 ` [PATCH v7 9/9] rust: sync: atomic: Add Atomic<{usize,isize}> Boqun Feng
2025-07-14 11:06 ` Benno Lossin
2025-07-14 13:47 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBQ21NIC2I5.32X8ZVDIK3J4C@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=levymitchell0@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=lyude@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=ojeda@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=torvalds@linux-foundation.org \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.