All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gero Schwäricke" <gero.schwaericke@sevenlab.de>
To: "Marcus Hoffmann" <buildroot@bubu1.eu>, <buildroot@buildroot.org>
Cc: "Colin Foster" <colin.foster@in-advantage.com>
Subject: Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
Date: Wed, 16 Jul 2025 15:35:28 +0200	[thread overview]
Message-ID: <DBDIP7YD1MDH.2ZH98MITNKUJW@sevenlab.de> (raw)
In-Reply-To: <d0473d32-8362-4c92-be5e-1cb82c370c4e@bubu1.eu>

Hi Marcus,

On Tue Jul 15, 2025 at 8:02 PM CEST, Marcus Hoffmann wrote:
> Hi Gero,
>
> I found almost exactly this change in our local patches recently but 
> didn't get around to upstreaming this yet... oops.
>
> Small note below for something that should probably be changed for 
> consistency.
>
> On 15.07.25 18:00, Gero Schwäricke wrote:
>> Systemd support for the RAUC hawkbit updater was added in
>> 
>>    4aa7a4ad8a (package/rauc-hawkbit-updater: add systemd optional dependency, 2024-07-10)
>> 
>> This installs the RAUC hawkbit updater service, which executes as user
>> "rauc-hawkbit" [1], which doesn't exist by default.
>> 
>> [1] https://github.com/rauc/rauc-hawkbit-updater/blob/2711c0e02781eb9d97285c87197f1bafef75d0d1/script/rauc-hawkbit-updater.service
>> 
>> Signed-off-by: Gero Schwäricke <gero.schwaericke@sevenlab.de>
>
> Reviewed-by: Marcus Hoffmann <buildroot@bubu1.eu>
>> ---
>>   package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk | 4 ++++
>>   1 file changed, 4 insertions(+)
>> 
>> diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> index da1c020bb6..5ee8414b91 100644
>> --- a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> +++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> @@ -15,6 +15,10 @@ RAUC_HAWKBIT_UPDATER_CFLAGS = $(TARGET_CFLAGS) -std=c99
>>   ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>>   RAUC_HAWKBIT_UPDATER_DEPENDENCIES += systemd
>>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=enabled
>> +# rauc-hawkbit-updater.service uses this user and group
>> +define RAUC_HAWKBIT_UPDATER_USERS
>> +	rauc-hawkbit -1 rauc-hawkbit -1 ! - - - RAUC Hawkbit Updater
>
> Other _USERS definitions in buildroot all use * instead of ! for the 
> password field. Not sure if that makes any difference in password but 
> (from shadow(5)) the convention seems to be that the '!' prefix is 
> specifically for locked accounts.
>

Thanks for the hint! I corrected this in v2 of the patch.

Best,
Gero

>> +endef
>>   else
>>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=disabled
>>   endif
>
> Best,
> Marcus

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-07-16 13:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 16:00 [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user Gero Schwäricke
2025-07-15 18:02 ` Marcus Hoffmann via buildroot
2025-07-15 18:07   ` Marcus Hoffmann via buildroot
2025-07-15 18:09   ` Colin Foster
2025-07-16 13:35   ` Gero Schwäricke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBDIP7YD1MDH.2ZH98MITNKUJW@sevenlab.de \
    --to=gero.schwaericke@sevenlab.de \
    --cc=buildroot@bubu1.eu \
    --cc=buildroot@buildroot.org \
    --cc=colin.foster@in-advantage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.