All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
@ 2025-07-15 16:00 Gero Schwäricke
  2025-07-15 18:02 ` Marcus Hoffmann via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Gero Schwäricke @ 2025-07-15 16:00 UTC (permalink / raw)
  To: buildroot; +Cc: Gero Schwäricke, Colin Foster

Systemd support for the RAUC hawkbit updater was added in

  4aa7a4ad8a (package/rauc-hawkbit-updater: add systemd optional dependency, 2024-07-10)

This installs the RAUC hawkbit updater service, which executes as user
"rauc-hawkbit" [1], which doesn't exist by default.

[1] https://github.com/rauc/rauc-hawkbit-updater/blob/2711c0e02781eb9d97285c87197f1bafef75d0d1/script/rauc-hawkbit-updater.service

Signed-off-by: Gero Schwäricke <gero.schwaericke@sevenlab.de>
---
 package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
index da1c020bb6..5ee8414b91 100644
--- a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
+++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
@@ -15,6 +15,10 @@ RAUC_HAWKBIT_UPDATER_CFLAGS = $(TARGET_CFLAGS) -std=c99
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 RAUC_HAWKBIT_UPDATER_DEPENDENCIES += systemd
 RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=enabled
+# rauc-hawkbit-updater.service uses this user and group
+define RAUC_HAWKBIT_UPDATER_USERS
+	rauc-hawkbit -1 rauc-hawkbit -1 ! - - - RAUC Hawkbit Updater
+endef
 else
 RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=disabled
 endif
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
  2025-07-15 16:00 [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user Gero Schwäricke
@ 2025-07-15 18:02 ` Marcus Hoffmann via buildroot
  2025-07-15 18:07   ` Marcus Hoffmann via buildroot
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Marcus Hoffmann via buildroot @ 2025-07-15 18:02 UTC (permalink / raw)
  To: Gero Schwäricke, buildroot; +Cc: Colin Foster

Hi Gero,

I found almost exactly this change in our local patches recently but 
didn't get around to upstreaming this yet... oops.

Small note below for something that should probably be changed for 
consistency.

On 15.07.25 18:00, Gero Schwäricke wrote:
> Systemd support for the RAUC hawkbit updater was added in
> 
>    4aa7a4ad8a (package/rauc-hawkbit-updater: add systemd optional dependency, 2024-07-10)
> 
> This installs the RAUC hawkbit updater service, which executes as user
> "rauc-hawkbit" [1], which doesn't exist by default.
> 
> [1] https://github.com/rauc/rauc-hawkbit-updater/blob/2711c0e02781eb9d97285c87197f1bafef75d0d1/script/rauc-hawkbit-updater.service
> 
> Signed-off-by: Gero Schwäricke <gero.schwaericke@sevenlab.de>

Reviewed-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
>   package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
> index da1c020bb6..5ee8414b91 100644
> --- a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
> +++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
> @@ -15,6 +15,10 @@ RAUC_HAWKBIT_UPDATER_CFLAGS = $(TARGET_CFLAGS) -std=c99
>   ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>   RAUC_HAWKBIT_UPDATER_DEPENDENCIES += systemd
>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=enabled
> +# rauc-hawkbit-updater.service uses this user and group
> +define RAUC_HAWKBIT_UPDATER_USERS
> +	rauc-hawkbit -1 rauc-hawkbit -1 ! - - - RAUC Hawkbit Updater

Other _USERS definitions in buildroot all use * instead of ! for the 
password field. Not sure if that makes any difference in password but 
(from shadow(5)) the convention seems to be that the '!' prefix is 
specifically for locked accounts.

> +endef
>   else
>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=disabled
>   endif

Best,
Marcus
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
  2025-07-15 18:02 ` Marcus Hoffmann via buildroot
@ 2025-07-15 18:07   ` Marcus Hoffmann via buildroot
  2025-07-15 18:09   ` Colin Foster
  2025-07-16 13:35   ` Gero Schwäricke
  2 siblings, 0 replies; 5+ messages in thread
From: Marcus Hoffmann via buildroot @ 2025-07-15 18:07 UTC (permalink / raw)
  To: Gero Schwäricke, buildroot



On 15.07.25 20:02, Marcus Hoffmann wrote:
> Hi Gero,
> 
[...]
> 
> Other _USERS definitions in buildroot all use * instead of ! for the 
> password field. Not sure if that makes any difference in password but 

I meant "any difference *in practice*" :D

> (from shadow(5)) the convention seems to be that the '!' prefix is 
> specifically for locked accounts.
> 
>> +endef
>>   else
>>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=disabled
>>   endif
> 
> Best,
> Marcus

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
  2025-07-15 18:02 ` Marcus Hoffmann via buildroot
  2025-07-15 18:07   ` Marcus Hoffmann via buildroot
@ 2025-07-15 18:09   ` Colin Foster
  2025-07-16 13:35   ` Gero Schwäricke
  2 siblings, 0 replies; 5+ messages in thread
From: Colin Foster @ 2025-07-15 18:09 UTC (permalink / raw)
  To: Marcus Hoffmann; +Cc: Gero Schwäricke, buildroot

On Tue, Jul 15, 2025 at 08:02:58PM +0200, Marcus Hoffmann wrote:
> [You don't often get email from buildroot@bubu1.eu. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi Gero,
> 
> I found almost exactly this change in our local patches recently but
> didn't get around to upstreaming this yet... oops.
> 
> Small note below for something that should probably be changed for
> consistency.
> 
> On 15.07.25 18:00, Gero Schwäricke wrote:
> > Systemd support for the RAUC hawkbit updater was added in
> > 
> >    4aa7a4ad8a (package/rauc-hawkbit-updater: add systemd optional dependency, 2024-07-10)
> > 
> > This installs the RAUC hawkbit updater service, which executes as user
> > "rauc-hawkbit" [1], which doesn't exist by default.
> > 
> > [1] https://github.com/rauc/rauc-hawkbit-updater/blob/2711c0e02781eb9d97285c87197f1bafef75d0d1/script/rauc-hawkbit-updater.service
> > 
> > Signed-off-by: Gero Schwäricke <gero.schwaericke@sevenlab.de>
> 
> Reviewed-by: Marcus Hoffmann <buildroot@bubu1.eu>

Apologies. When I implemented it I wasn't using systemd, so I didn't
come across it. In the last week I came across this for a hobby project,
but have been sitting on the patch.

Thanks for jumping on this!

Acked-by: Colin Foster <colin.foster@in-advantage.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user
  2025-07-15 18:02 ` Marcus Hoffmann via buildroot
  2025-07-15 18:07   ` Marcus Hoffmann via buildroot
  2025-07-15 18:09   ` Colin Foster
@ 2025-07-16 13:35   ` Gero Schwäricke
  2 siblings, 0 replies; 5+ messages in thread
From: Gero Schwäricke @ 2025-07-16 13:35 UTC (permalink / raw)
  To: Marcus Hoffmann, buildroot; +Cc: Colin Foster

Hi Marcus,

On Tue Jul 15, 2025 at 8:02 PM CEST, Marcus Hoffmann wrote:
> Hi Gero,
>
> I found almost exactly this change in our local patches recently but 
> didn't get around to upstreaming this yet... oops.
>
> Small note below for something that should probably be changed for 
> consistency.
>
> On 15.07.25 18:00, Gero Schwäricke wrote:
>> Systemd support for the RAUC hawkbit updater was added in
>> 
>>    4aa7a4ad8a (package/rauc-hawkbit-updater: add systemd optional dependency, 2024-07-10)
>> 
>> This installs the RAUC hawkbit updater service, which executes as user
>> "rauc-hawkbit" [1], which doesn't exist by default.
>> 
>> [1] https://github.com/rauc/rauc-hawkbit-updater/blob/2711c0e02781eb9d97285c87197f1bafef75d0d1/script/rauc-hawkbit-updater.service
>> 
>> Signed-off-by: Gero Schwäricke <gero.schwaericke@sevenlab.de>
>
> Reviewed-by: Marcus Hoffmann <buildroot@bubu1.eu>
>> ---
>>   package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk | 4 ++++
>>   1 file changed, 4 insertions(+)
>> 
>> diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> index da1c020bb6..5ee8414b91 100644
>> --- a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> +++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
>> @@ -15,6 +15,10 @@ RAUC_HAWKBIT_UPDATER_CFLAGS = $(TARGET_CFLAGS) -std=c99
>>   ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>>   RAUC_HAWKBIT_UPDATER_DEPENDENCIES += systemd
>>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=enabled
>> +# rauc-hawkbit-updater.service uses this user and group
>> +define RAUC_HAWKBIT_UPDATER_USERS
>> +	rauc-hawkbit -1 rauc-hawkbit -1 ! - - - RAUC Hawkbit Updater
>
> Other _USERS definitions in buildroot all use * instead of ! for the 
> password field. Not sure if that makes any difference in password but 
> (from shadow(5)) the convention seems to be that the '!' prefix is 
> specifically for locked accounts.
>

Thanks for the hint! I corrected this in v2 of the patch.

Best,
Gero

>> +endef
>>   else
>>   RAUC_HAWKBIT_UPDATER_CONF_OPTS += -Dsystemd=disabled
>>   endif
>
> Best,
> Marcus

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-07-16 13:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 16:00 [Buildroot] [PATCH] package/rauc-hawkbit-updater: fix missing user Gero Schwäricke
2025-07-15 18:02 ` Marcus Hoffmann via buildroot
2025-07-15 18:07   ` Marcus Hoffmann via buildroot
2025-07-15 18:09   ` Colin Foster
2025-07-16 13:35   ` Gero Schwäricke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.