* [PATCH] drm/nouveau/nvif: fix null ptr deref on pre-fermi boards
@ 2025-07-14 2:59 Ben Skeggs
2025-07-21 9:37 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Ben Skeggs @ 2025-07-14 2:59 UTC (permalink / raw)
To: nouveau; +Cc: Ben Skeggs, Jamie Heilman, Rui Salvaterra
Check that gpfifo.post() exists before trying to call it.
Fixes: 862450a85b85 ("drm/nouveau/gf100-: track chan progress with non-WFI semaphore release")
Reported-by: Jamie Heilman <jamie@audible.transient.net>
Reported-by: Rui Salvaterra <rsalvaterra@gmail.com>
Tested-by: Rui Salvaterra <rsalvaterra@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@nvidia.com>
---
drivers/gpu/drm/nouveau/nvif/chan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nvif/chan.c b/drivers/gpu/drm/nouveau/nvif/chan.c
index baa10227d51a..80c01017d642 100644
--- a/drivers/gpu/drm/nouveau/nvif/chan.c
+++ b/drivers/gpu/drm/nouveau/nvif/chan.c
@@ -39,6 +39,9 @@ nvif_chan_gpfifo_post(struct nvif_chan *chan)
const u32 pbptr = (chan->push.cur - map) + chan->func->gpfifo.post_size;
const u32 gpptr = (chan->gpfifo.cur + 1) & chan->gpfifo.max;
+ if (!chan->func->gpfifo.post)
+ return 0;
+
return chan->func->gpfifo.post(chan, gpptr, pbptr);
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/nouveau/nvif: fix null ptr deref on pre-fermi boards
2025-07-14 2:59 [PATCH] drm/nouveau/nvif: fix null ptr deref on pre-fermi boards Ben Skeggs
@ 2025-07-21 9:37 ` Danilo Krummrich
0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2025-07-21 9:37 UTC (permalink / raw)
To: Ben Skeggs; +Cc: nouveau, Jamie Heilman, Rui Salvaterra
On Mon Jul 14, 2025 at 4:59 AM CEST, Ben Skeggs wrote:
> Check that gpfifo.post() exists before trying to call it.
>
> Fixes: 862450a85b85 ("drm/nouveau/gf100-: track chan progress with non-WFI semaphore release")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Reported-by: Rui Salvaterra <rsalvaterra@gmail.com>
> Tested-by: Rui Salvaterra <rsalvaterra@gmail.com>
> Signed-off-by: Ben Skeggs <bskeggs@nvidia.com>
Please remember to add a Closes tag for Reported-by (I added them when I applied
the patch).
Applied to drm-misc-fixes, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-21 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 2:59 [PATCH] drm/nouveau/nvif: fix null ptr deref on pre-fermi boards Ben Skeggs
2025-07-21 9:37 ` Danilo Krummrich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.