All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gt: Protect against overflow in active_engine()
@ 2025-08-04  7:57 Krzysztof Karas
  2025-08-04  8:11 ` Jani Nikula
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Krzysztof Karas @ 2025-08-04  7:57 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson, Andi Shyti, Sebastian Brzezinka

It is unlikely, but possible for the first call to
intel_context_create() to fail with -ENOMEM, which would result
in entering the following code block and decrementing "count",
when it is set to 0 (initial condition in the for loop).

Protect from overflowing the variable with additional count > 0
check.

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
index f057c16410e7..cc0798dd30d5 100644
--- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
+++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
@@ -904,8 +904,10 @@ static void active_engine(struct kthread_work *work)
 			arg->result = PTR_ERR(ce[count]);
 			pr_err("[%s] Create context #%ld failed: %d!\n",
 			       engine->name, count, arg->result);
-			while (--count)
-				intel_context_put(ce[count]);
+			if (likely(count > 0)) {
+				while (--count)
+					intel_context_put(ce[count]);
+			}
 			return;
 		}
 	}
-- 
2.34.1

-- 
Best Regards,
Krzysztof

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-08-04 23:12 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-04  7:57 [PATCH] drm/i915/gt: Protect against overflow in active_engine() Krzysztof Karas
2025-08-04  8:11 ` Jani Nikula
2025-08-04 10:42 ` Sebastian Brzezinka
2025-08-04 10:48 ` ✗ Fi.CI.BUILD: warning for " Patchwork
2025-08-04 11:15 ` ✓ i915.CI.BAT: success " Patchwork
2025-08-04 12:33 ` [PATCH] " Andi Shyti
2025-08-04 14:39 ` Cavitt, Jonathan
2025-08-04 23:12 ` ✓ i915.CI.Full: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.