From: "Danilo Krummrich" <dakr@kernel.org>
To: "Vitaly Wool" <vitaly.wool@konsulko.se>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Bjorn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>
Subject: Re: [PATCH v3] rust: alloc: implement Box::pin_slice()
Date: Wed, 20 Aug 2025 14:56:52 +0200 [thread overview]
Message-ID: <DC79SQDWVVMI.3A6WCE173M511@kernel.org> (raw)
In-Reply-To: <3e922cc6-6d27-49ad-9719-5662c6102b6b@konsulko.se>
On Wed Aug 20, 2025 at 10:07 AM CEST, Vitaly Wool wrote:
> On 8/11/25 12:14, Vitaly Wool wrote:
>> From: Alice Ryhl <aliceryhl@google.com>
>>
>> Add a new constructor to Box to facilitate Box creation from a pinned
>> slice of elements. This allows to efficiently allocate memory for e.g.
>> slices of structrures containing spinlocks or mutexes. Such slices may
>> be used in kmemcache like or zpool API implementations.
>>
>> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>> Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.se>
>
> From what I could see, there were no objections to this one. Danilo,
> would you be up for picking it or is there something missing about it still?
This looks good now.
There's a few minor nits, e.g. it'd be nice to have an empty line between
struct definitions in the example and sentences ending with a period. But I can
fix those up on apply.
next prev parent reply other threads:[~2025-08-20 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 10:14 [PATCH v3] rust: alloc: implement Box::pin_slice() Vitaly Wool
2025-08-20 8:07 ` Vitaly Wool
2025-08-20 12:56 ` Danilo Krummrich [this message]
2025-08-21 14:47 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC79SQDWVVMI.3A6WCE173M511@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.