[PATCH 0/6] drm: Miscellaneous fixes in drm code

[PATCH 0/6] drm: Miscellaneous fixes in drm code

[Krzysztof Karas]

Krzysztof Karas (6):
  drm/i915/gem: Avoid accessing uninitialized context in
    emit_rpcs_query()
  drm/i915: Add default case for the switch in igt_smoke_tiling()
  drm: Remove drm_modeset_backoff() return code
  drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr()
  drm: Do not attempt to round_up() zeros in drm_suballoc_try_alloc()
  drm: Avoid undefined behavior on u16 multiplication

 drivers/gpu/drm/drm_fb_dma_helper.c                   | 7 +++++--
 drivers/gpu/drm/drm_gem_vram_helper.c                 | 2 +-
 drivers/gpu/drm/drm_mipi_dbi.c                        | 2 +-
 drivers/gpu/drm/drm_mode_config.c                     | 2 +-
 drivers/gpu/drm/drm_suballoc.c                        | 6 ++++--
 drivers/gpu/drm/drm_vblank.c                          | 2 +-
 drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 3 ++-
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c    | 4 +++-
 8 files changed, 18 insertions(+), 10 deletions(-)

-- 
2.34.1

[PATCH 1/6] drm/i915/gem: Avoid accessing uninitialized context in emit_rpcs_query()

[Krzysztof Karas]

Following the error path in that function may lead to usage of
uninitialized struct i915_gem_ww_ctx object, so move call to
i915_gem_ww_ctx_init() a bit earlier.

Fixes: 15b6c9249870 ("drm/i915: Move i915_vma_lock in the selftests to avoid lock inversion, v3.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: <stable@vger.kernel.org> # v5.10+
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index eb0158e43417..1330c0b431a7 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -962,13 +962,14 @@ emit_rpcs_query(struct drm_i915_gem_object *obj,
 	if (IS_ERR(rpcs))
 		return PTR_ERR(rpcs);
 
+	i915_gem_ww_ctx_init(&ww, false);
+
 	batch = i915_vma_instance(rpcs, ce->vm, NULL);
 	if (IS_ERR(batch)) {
 		err = PTR_ERR(batch);
 		goto err_put;
 	}
 
-	i915_gem_ww_ctx_init(&ww, false);
 retry:
 	err = i915_gem_object_lock(obj, &ww);
 	if (!err)
-- 
2.34.1

[PATCH 2/6] drm/i915: Add default case for the switch in igt_smoke_tiling()

[Krzysztof Karas]

To calm down static analysers define a default case and break
out of the test.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index 78734c404a6d..6d87356e928b 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -498,13 +498,15 @@ static int igt_smoke_tiling(void *arg)
 			tile.stride = 0;
 			tile.swizzle = I915_BIT_6_SWIZZLE_NONE;
 			break;
-
 		case I915_TILING_X:
 			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_x;
 			break;
 		case I915_TILING_Y:
 			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_y;
 			break;
+		default:
+			err = -EINVAL;
+			break;
 		}
 
 		if (tile.swizzle == I915_BIT_6_SWIZZLE_9_17 ||
-- 
2.34.1


-- 
Best Regards,
Krzysztof

[PATCH 3/6] drm: Remove drm_modeset_backoff() return code

[Krzysztof Karas]

We do not care about the value returned from that function
during initialization.

Cc: Simona Vetter <simona.vetter@ffwll.ch>
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/drm_mode_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index 25f376869b3a..69a923e1bdfe 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -471,7 +471,7 @@ int drmm_mode_config_init(struct drm_device *dev)
 		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
 				       &modeset_ctx);
 		if (ret == -EDEADLK)
-			ret = drm_modeset_backoff(&modeset_ctx);
+			drm_modeset_backoff(&modeset_ctx);
 
 		might_fault();
 
-- 
2.34.1


-- 
Best Regards,
Krzysztof

[PATCH 4/6] drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr()

[Krzysztof Karas]

There are two unsafe scenarios in that function:
 1) drm_format_info_block_width/height() may return 0 and cause
division by 0 down the line. Return early if any of these values
are 0.
 2) dma_addr calculations are carried out using 32-bit
arithmetic, which could cause a truncation of the values
before they are extended to 64 bits. Cast one of the operands
to dma_addr_t, so 64-bit arithmetic is used.

Fixes: 8c30eecc6769 ("drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: <stable@vger.kernel.org> # v6.1+
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/drm_fb_dma_helper.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_dma_helper.c b/drivers/gpu/drm/drm_fb_dma_helper.c
index fd71969d2fb1..00aaad648a33 100644
--- a/drivers/gpu/drm/drm_fb_dma_helper.c
+++ b/drivers/gpu/drm/drm_fb_dma_helper.c
@@ -85,6 +85,9 @@ dma_addr_t drm_fb_dma_get_gem_addr(struct drm_framebuffer *fb,
 	u32 block_start_y;
 	u32 num_hblocks;
 
+	if (block_w == 0 || block_h == 0)
+		return 0;
+
 	obj = drm_fb_dma_get_gem_obj(fb, plane);
 	if (!obj)
 		return 0;
@@ -101,8 +104,8 @@ dma_addr_t drm_fb_dma_get_gem_addr(struct drm_framebuffer *fb,
 	block_start_y = (sample_y / block_h) * block_h;
 	num_hblocks = sample_x / block_w;
 
-	dma_addr += fb->pitches[plane] * block_start_y;
-	dma_addr += block_size * num_hblocks;
+	dma_addr += (dma_addr_t)fb->pitches[plane] * block_start_y;
+	dma_addr += (dma_addr_t)block_size * num_hblocks;
 
 	return dma_addr;
 }
-- 
2.34.1


-- 
Best Regards,
Krzysztof

[PATCH 5/6] drm: Do not attempt to round_up() zeros in drm_suballoc_try_alloc()

[Krzysztof Karas]

Due to the nature of round_up(), its first argument is
decremented by one. drm_suballoc_hole_soffset() may return 0,
which is then passed to round_up() and may wrap around.
Remedy that by adding a guard against that value.

Fixes: 849ee8a2f0df ("drm/suballoc: Extract amdgpu_sa.c as generic suballocation helper")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: <stable@vger.kernel.org> # v6.4+
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/drm_suballoc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_suballoc.c b/drivers/gpu/drm/drm_suballoc.c
index 879ea33dbbc4..7f01e9d9fcfd 100644
--- a/drivers/gpu/drm/drm_suballoc.c
+++ b/drivers/gpu/drm/drm_suballoc.c
@@ -165,11 +165,13 @@ static bool drm_suballoc_try_alloc(struct drm_suballoc_manager *sa_manager,
 				   struct drm_suballoc *sa,
 				   size_t size, size_t align)
 {
-	size_t soffset, eoffset, wasted;
+	size_t soffset, eoffset, wasted = 0;
 
 	soffset = drm_suballoc_hole_soffset(sa_manager);
 	eoffset = drm_suballoc_hole_eoffset(sa_manager);
-	wasted = round_up(soffset, align) - soffset;
+
+	if (soffset)
+		wasted = round_up(soffset, align) - soffset;
 
 	if ((eoffset - soffset) >= (size + wasted)) {
 		soffset += wasted;
-- 
2.34.1

[PATCH 6/6] drm: Avoid undefined behavior on u16 multiplication

[Krzysztof Karas]

Fields hdiplay and vdisplay are defined as u16. Their
multiplication causes implicit promotion to signed 32-bit value,
which may overflow and cause undefined behavior.

The same goes for vpos, which is multiplied by signed integer.

Prevent possible undefined behavior by explicitly casting one of
the operands to (unsigned int) type.

Fixes: 3ed4351a83ca ("drm: Extract drm_vblank.[hc]")
Fixes: cc4312127108 ("drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()")
Fixes: 80f7c3f77697 ("drm/vram: Add helpers to validate a display mode's memory requirements")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Simona Vetter <simona.vetter@ffwll.ch>
Cc: <stable@vger.kernel.org> # v4.13+
Cc: <stable@vger.kernel.org> # v5.4+
Cc: <stable@vger.kernel.org> # v5.7+
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/drm_gem_vram_helper.c | 2 +-
 drivers/gpu/drm/drm_mipi_dbi.c        | 2 +-
 drivers/gpu/drm/drm_vblank.c          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
index b04cde4a60e7..4b144e9603b8 100644
--- a/drivers/gpu/drm/drm_gem_vram_helper.c
+++ b/drivers/gpu/drm/drm_gem_vram_helper.c
@@ -967,7 +967,7 @@ drm_vram_helper_mode_valid_internal(struct drm_device *dev,
 
 	max_fbpages = (vmm->vram_size / 2) >> PAGE_SHIFT;
 
-	fbsize = mode->hdisplay * mode->vdisplay * max_bpp;
+	fbsize = (unsigned int)mode->hdisplay * mode->vdisplay * max_bpp;
 	fbpages = DIV_ROUND_UP(fbsize, PAGE_SIZE);
 
 	if (fbpages > max_fbpages)
diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c
index e33c78fc8fbd..536741dd7690 100644
--- a/drivers/gpu/drm/drm_mipi_dbi.c
+++ b/drivers/gpu/drm/drm_mipi_dbi.c
@@ -691,7 +691,7 @@ int mipi_dbi_dev_init(struct mipi_dbi_dev *dbidev,
 		      const struct drm_simple_display_pipe_funcs *funcs,
 		      const struct drm_display_mode *mode, unsigned int rotation)
 {
-	size_t bufsize = mode->vdisplay * mode->hdisplay * sizeof(u16);
+	size_t bufsize = (unsigned int)mode->vdisplay * mode->hdisplay * sizeof(u16);
 
 	dbidev->drm.mode_config.preferred_depth = 16;
 
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 46f59883183d..8a3a82962494 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -779,7 +779,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(
 	 * since start of scanout at first display scanline. delta_ns
 	 * can be negative if start of scanout hasn't happened yet.
 	 */
-	delta_ns = div_s64(1000000LL * (vpos * mode->crtc_htotal + hpos),
+	delta_ns = div_s64(1000000LL * ((unsigned int)vpos * mode->crtc_htotal + hpos),
 			   mode->crtc_clock);
 
 	/* Subtract time delta from raw timestamp to get final
-- 
2.34.1

Re: [PATCH 0/6] drm: Miscellaneous fixes in drm code

[Jani Nikula]

On Mon, 08 Sep 2025, Krzysztof Karas <krzysztof.karas@intel.com> wrote:
> Krzysztof Karas (6):
>   drm/i915/gem: Avoid accessing uninitialized context in
>     emit_rpcs_query()
>   drm/i915: Add default case for the switch in igt_smoke_tiling()

i915 and drm changes should be sent separately when the changes have no
dependencies.

BR,
Jani.

>   drm: Remove drm_modeset_backoff() return code
>   drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr()
>   drm: Do not attempt to round_up() zeros in drm_suballoc_try_alloc()
>   drm: Avoid undefined behavior on u16 multiplication
>
>  drivers/gpu/drm/drm_fb_dma_helper.c                   | 7 +++++--
>  drivers/gpu/drm/drm_gem_vram_helper.c                 | 2 +-
>  drivers/gpu/drm/drm_mipi_dbi.c                        | 2 +-
>  drivers/gpu/drm/drm_mode_config.c                     | 2 +-
>  drivers/gpu/drm/drm_suballoc.c                        | 6 ++++--
>  drivers/gpu/drm/drm_vblank.c                          | 2 +-
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 3 ++-
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c    | 4 +++-
>  8 files changed, 18 insertions(+), 10 deletions(-)

-- 
Jani Nikula, Intel

Re: [PATCH 6/6] drm: Avoid undefined behavior on u16 multiplication

[Jani Nikula]

On Mon, 08 Sep 2025, Krzysztof Karas <krzysztof.karas@intel.com> wrote:
> Fields hdiplay and vdisplay are defined as u16. Their
> multiplication causes implicit promotion to signed 32-bit value,
> which may overflow and cause undefined behavior.
>
> The same goes for vpos, which is multiplied by signed integer.
>
> Prevent possible undefined behavior by explicitly casting one of
> the operands to (unsigned int) type.
>
> Fixes: 3ed4351a83ca ("drm: Extract drm_vblank.[hc]")
> Fixes: cc4312127108 ("drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()")
> Fixes: 80f7c3f77697 ("drm/vram: Add helpers to validate a display mode's memory requirements")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Simona Vetter <simona.vetter@ffwll.ch>
> Cc: <stable@vger.kernel.org> # v4.13+
> Cc: <stable@vger.kernel.org> # v5.4+
> Cc: <stable@vger.kernel.org> # v5.7+

The multitude of files, Fixes and subsequent Cc: stables with different
target kernels is just an indication this should be three separate
patches.

The cause may be the same, but they're still unrelated fixes.

Moreover, imagine the consequences of one of these fixes ending up being
incorrect, and you have to revert or fix it. It's a logistics PITA.


BR,
Jani.


> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
>  drivers/gpu/drm/drm_gem_vram_helper.c | 2 +-
>  drivers/gpu/drm/drm_mipi_dbi.c        | 2 +-
>  drivers/gpu/drm/drm_vblank.c          | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
> index b04cde4a60e7..4b144e9603b8 100644
> --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> @@ -967,7 +967,7 @@ drm_vram_helper_mode_valid_internal(struct drm_device *dev,
>  
>  	max_fbpages = (vmm->vram_size / 2) >> PAGE_SHIFT;
>  
> -	fbsize = mode->hdisplay * mode->vdisplay * max_bpp;
> +	fbsize = (unsigned int)mode->hdisplay * mode->vdisplay * max_bpp;
>  	fbpages = DIV_ROUND_UP(fbsize, PAGE_SIZE);
>  
>  	if (fbpages > max_fbpages)
> diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c
> index e33c78fc8fbd..536741dd7690 100644
> --- a/drivers/gpu/drm/drm_mipi_dbi.c
> +++ b/drivers/gpu/drm/drm_mipi_dbi.c
> @@ -691,7 +691,7 @@ int mipi_dbi_dev_init(struct mipi_dbi_dev *dbidev,
>  		      const struct drm_simple_display_pipe_funcs *funcs,
>  		      const struct drm_display_mode *mode, unsigned int rotation)
>  {
> -	size_t bufsize = mode->vdisplay * mode->hdisplay * sizeof(u16);
> +	size_t bufsize = (unsigned int)mode->vdisplay * mode->hdisplay * sizeof(u16);
>  
>  	dbidev->drm.mode_config.preferred_depth = 16;
>  
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 46f59883183d..8a3a82962494 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -779,7 +779,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(
>  	 * since start of scanout at first display scanline. delta_ns
>  	 * can be negative if start of scanout hasn't happened yet.
>  	 */
> -	delta_ns = div_s64(1000000LL * (vpos * mode->crtc_htotal + hpos),
> +	delta_ns = div_s64(1000000LL * ((unsigned int)vpos * mode->crtc_htotal + hpos),
>  			   mode->crtc_clock);
>  
>  	/* Subtract time delta from raw timestamp to get final

-- 
Jani Nikula, Intel

Re: [PATCH 1/6] drm/i915/gem: Avoid accessing uninitialized context in emit_rpcs_query()

[Andi Shyti]

Hi Krzysztof,

On Mon, Sep 08, 2025 at 09:23:02AM +0000, Krzysztof Karas wrote:
> Following the error path in that function may lead to usage of
> uninitialized struct i915_gem_ww_ctx object, so move call to
> i915_gem_ww_ctx_init() a bit earlier.
> 
> Fixes: 15b6c9249870 ("drm/i915: Move i915_vma_lock in the selftests to avoid lock inversion, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v5.10+
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

Re: [PATCH 1/6] drm/i915/gem: Avoid accessing uninitialized context in emit_rpcs_query()

[Sebastian Brzezinka]

Hi Krzysztof

On Mon Sep 8, 2025 at 9:23 AM UTC, Krzysztof Karas wrote:
> Following the error path in that function may lead to usage of
> uninitialized struct i915_gem_ww_ctx object, so move call to
> i915_gem_ww_ctx_init() a bit earlier.
>
> Fixes: 15b6c9249870 ("drm/i915: Move i915_vma_lock in the selftests to avoid lock inversion, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v5.10+
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>

Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
-- 
Best regards,
Sebastian

Re: [PATCH 2/6] drm/i915: Add default case for the switch in igt_smoke_tiling()

[Andi Shyti]

Hi Krzysztof,

On Mon, Sep 08, 2025 at 09:23:56AM +0000, Krzysztof Karas wrote:
> To calm down static analysers define a default case and break
> out of the test.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> index 78734c404a6d..6d87356e928b 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> @@ -498,13 +498,15 @@ static int igt_smoke_tiling(void *arg)
>  			tile.stride = 0;
>  			tile.swizzle = I915_BIT_6_SWIZZLE_NONE;
>  			break;
> -
>  		case I915_TILING_X:
>  			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_x;
>  			break;
>  		case I915_TILING_Y:
>  			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_y;
>  			break;
> +		default:
> +			err = -EINVAL;
> +			break;

You are breaking from the switch/case and ending up where? Should
this be continue?

If you really want to make static analysers happy (which we don't
care much) you could do something like:

		case I915_TILING_NONE:
		default:

But the C specification is not obliging anyone to use the default
case, so that we can happily ignore the static analyser issue if
there is no need for a default.

Andi

>  		}
>  
>  		if (tile.swizzle == I915_BIT_6_SWIZZLE_9_17 ||
> -- 
> 2.34.1
> 
> 
> -- 
> Best Regards,
> Krzysztof

Re: [PATCH 3/6] drm: Remove drm_modeset_backoff() return code

[Andi Shyti]

Hi Krzysztof,

On Mon, Sep 08, 2025 at 09:24:56AM +0000, Krzysztof Karas wrote:
> We do not care about the value returned from that function
> during initialization.
> 
> Cc: Simona Vetter <simona.vetter@ffwll.ch>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
>  drivers/gpu/drm/drm_mode_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 25f376869b3a..69a923e1bdfe 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -471,7 +471,7 @@ int drmm_mode_config_init(struct drm_device *dev)
>  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
>  				       &modeset_ctx);
>  		if (ret == -EDEADLK)
> -			ret = drm_modeset_backoff(&modeset_ctx);
> +			drm_modeset_backoff(&modeset_ctx);

This is a very insignificant change because whether we set ret or
we don't it doesn't change anything.

Up to Sima.

Andi

Re: [PATCH 4/6] drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr()

[Sebastian Brzezinka]

Hi Krzysztof

On Mon Sep 8, 2025 at 9:25 AM UTC, Krzysztof Karas wrote:
> There are two unsafe scenarios in that function:
>  1) drm_format_info_block_width/height() may return 0 and cause
> division by 0 down the line. Return early if any of these values
> are 0.
>  2) dma_addr calculations are carried out using 32-bit
> arithmetic, which could cause a truncation of the values
> before they are extended to 64 bits. Cast one of the operands
> to dma_addr_t, so 64-bit arithmetic is used.
>
> Fixes: 8c30eecc6769 ("drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}")
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
LGTM it could probably be split into two patches, but the changes are pretty small
and it doesn’t really bother me. drm_format_info_block_h/w can both potentially return 0,
so it's good to verify their return values.

Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

-- 
Best regards,
Sebastian

Re: [PATCH 6/6] drm: Avoid undefined behavior on u16 multiplication

[Jani Nikula]

On Mon, 08 Sep 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 08 Sep 2025, Krzysztof Karas <krzysztof.karas@intel.com> wrote:
>> Fields hdiplay and vdisplay are defined as u16. Their
>> multiplication causes implicit promotion to signed 32-bit value,
>> which may overflow and cause undefined behavior.
>>
>> The same goes for vpos, which is multiplied by signed integer.
>>
>> Prevent possible undefined behavior by explicitly casting one of
>> the operands to (unsigned int) type.
>>
>> Fixes: 3ed4351a83ca ("drm: Extract drm_vblank.[hc]")
>> Fixes: cc4312127108 ("drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()")
>> Fixes: 80f7c3f77697 ("drm/vram: Add helpers to validate a display mode's memory requirements")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Noralf Trønnes <noralf@tronnes.org>
>> Cc: Simona Vetter <simona.vetter@ffwll.ch>
>> Cc: <stable@vger.kernel.org> # v4.13+
>> Cc: <stable@vger.kernel.org> # v5.4+
>> Cc: <stable@vger.kernel.org> # v5.7+
>
> The multitude of files, Fixes and subsequent Cc: stables with different
> target kernels is just an indication this should be three separate
> patches.
>
> The cause may be the same, but they're still unrelated fixes.
>
> Moreover, imagine the consequences of one of these fixes ending up being
> incorrect, and you have to revert or fix it. It's a logistics PITA.

Also, depending on things introduced in v5.7 means this can't be
backported to v5.4 either. Not very important here, but something to
consider for the future.

BR,
Jani.


-- 
Jani Nikula, Intel

✗ i915.CI.BAT: failure for drm: Miscellaneous fixes in drm code

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 20547 bytes --]

== Series Details ==

Series: drm: Miscellaneous fixes in drm code
URL   : https://patchwork.freedesktop.org/series/154173/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_17150 -> Patchwork_154173v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_154173v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_154173v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/index.html

Participating hosts (43 -> 42)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_154173v1:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-cfl-guc:         [PASS][1] -> [FAIL][2] +15 other tests fail
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-cfl-guc/igt@kms_flip@basic-flip-vs-dpms.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-cfl-guc/igt@kms_flip@basic-flip-vs-dpms.html

  * igt@kms_flip@basic-flip-vs-dpms@a-vga1:
    - fi-pnv-d510:        [PASS][3] -> [FAIL][4] +11 other tests fail
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-pnv-d510/igt@kms_flip@basic-flip-vs-dpms@a-vga1.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-pnv-d510/igt@kms_flip@basic-flip-vs-dpms@a-vga1.html

  * igt@kms_flip@basic-flip-vs-dpms@b-vga1:
    - fi-ilk-650:         [PASS][5] -> [FAIL][6] +11 other tests fail
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-ilk-650/igt@kms_flip@basic-flip-vs-dpms@b-vga1.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-ilk-650/igt@kms_flip@basic-flip-vs-dpms@b-vga1.html

  * igt@kms_flip@basic-flip-vs-modeset@a-dp2:
    - fi-cfl-8109u:       [PASS][7] -> [FAIL][8] +27 other tests fail
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@a-dp2.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@a-dp2.html

  * igt@kms_flip@basic-flip-vs-modeset@a-edp1:
    - bat-mtlp-8:         [PASS][9] -> [FAIL][10] +19 other tests fail
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-mtlp-8/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-8/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html

  * igt@kms_flip@basic-flip-vs-modeset@a-hdmi-a1:
    - bat-adls-6:         [PASS][11] -> [FAIL][12] +19 other tests fail
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-adls-6/igt@kms_flip@basic-flip-vs-modeset@a-hdmi-a1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-adls-6/igt@kms_flip@basic-flip-vs-modeset@a-hdmi-a1.html

  * igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a2:
    - bat-rpls-4:         [PASS][13] -> [FAIL][14] +35 other tests fail
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-rpls-4/igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a2.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-rpls-4/igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a2.html

  * igt@kms_flip@basic-flip-vs-modeset@d-dp1:
    - bat-dg2-9:          [PASS][15] -> [FAIL][16] +19 other tests fail
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-9/igt@kms_flip@basic-flip-vs-modeset@d-dp1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-9/igt@kms_flip@basic-flip-vs-modeset@d-dp1.html

  * igt@kms_flip@basic-flip-vs-modeset@d-hdmi-a1:
    - fi-tgl-1115g4:      [PASS][17] -> [FAIL][18] +19 other tests fail
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-modeset@d-hdmi-a1.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-modeset@d-hdmi-a1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - fi-cfl-8700k:       [PASS][19] -> [FAIL][20] +15 other tests fail
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-cfl-8700k/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-cfl-8700k/igt@kms_flip@basic-flip-vs-wf_vblank.html
    - bat-dg2-14:         [PASS][21] -> [FAIL][22] +35 other tests fail
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-14/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-14/igt@kms_flip@basic-flip-vs-wf_vblank.html
    - bat-adlp-6:         [PASS][23] -> [FAIL][24] +37 other tests fail
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-adlp-6/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-wf_vblank.html
    - fi-bsw-n3050:       [PASS][25] -> [FAIL][26] +7 other tests fail
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
    - bat-twl-2:          [PASS][27] -> [FAIL][28] +15 other tests fail
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-twl-2/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-twl-2/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-hdmi-a2:
    - bat-dg1-7:          [PASS][29] -> [FAIL][30] +19 other tests fail
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg1-7/igt@kms_flip@basic-flip-vs-wf_vblank@a-hdmi-a2.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg1-7/igt@kms_flip@basic-flip-vs-wf_vblank@a-hdmi-a2.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1:
    - fi-hsw-4770:        [PASS][31] -> [FAIL][32] +15 other tests fail
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-hsw-4770/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-hsw-4770/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
    - fi-ivb-3770:        [PASS][33] -> [FAIL][34] +15 other tests fail
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-ivb-3770/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-ivb-3770/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
    - fi-elk-e7500:       [PASS][35] -> [FAIL][36] +19 other tests fail
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-elk-e7500/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-elk-e7500/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
    - bat-jsl-1:          [PASS][37] -> [FAIL][38] +16 other tests fail
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-jsl-1/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-jsl-1/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-dp3:
    - bat-arls-5:         [PASS][39] -> [FAIL][40] +19 other tests fail
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-arls-5/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp3.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-arls-5/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp3.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-dp6:
    - bat-mtlp-9:         NOTRUN -> [FAIL][41] +43 other tests fail
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp6.html

  * igt@kms_flip@basic-plain-flip@a-dp1:
    - bat-adlp-9:         [PASS][42] -> [FAIL][43] +25 other tests fail
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-adlp-9/igt@kms_flip@basic-plain-flip@a-dp1.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-adlp-9/igt@kms_flip@basic-plain-flip@a-dp1.html
    - bat-apl-1:          [PASS][44] -> [FAIL][45] +17 other tests fail
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-apl-1/igt@kms_flip@basic-plain-flip@a-dp1.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-apl-1/igt@kms_flip@basic-plain-flip@a-dp1.html

  * igt@kms_flip@basic-plain-flip@a-edp1:
    - bat-twl-1:          [PASS][46] -> [FAIL][47] +11 other tests fail
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-twl-1/igt@kms_flip@basic-plain-flip@a-edp1.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-twl-1/igt@kms_flip@basic-plain-flip@a-edp1.html

  * igt@kms_flip@basic-plain-flip@a-hdmi-a2:
    - bat-arls-6:         [PASS][48] -> [FAIL][49] +19 other tests fail
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-arls-6/igt@kms_flip@basic-plain-flip@a-hdmi-a2.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-arls-6/igt@kms_flip@basic-plain-flip@a-hdmi-a2.html

  * igt@kms_flip@basic-plain-flip@b-dp1:
    - fi-kbl-7567u:       [PASS][50] -> [FAIL][51] +15 other tests fail
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-kbl-7567u/igt@kms_flip@basic-plain-flip@b-dp1.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-kbl-7567u/igt@kms_flip@basic-plain-flip@b-dp1.html

  * igt@kms_flip@basic-plain-flip@b-hdmi-a2:
    - fi-glk-j4005:       [PASS][52] -> [FAIL][53] +15 other tests fail
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-glk-j4005/igt@kms_flip@basic-plain-flip@b-hdmi-a2.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-glk-j4005/igt@kms_flip@basic-plain-flip@b-hdmi-a2.html

  * igt@kms_flip@basic-plain-flip@c-dp1:
    - bat-dg2-8:          [PASS][54] -> [FAIL][55] +19 other tests fail
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-8/igt@kms_flip@basic-plain-flip@c-dp1.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-8/igt@kms_flip@basic-plain-flip@c-dp1.html

  * igt@kms_flip@basic-plain-flip@c-edp1:
    - fi-skl-6600u:       [PASS][56] -> [FAIL][57] +15 other tests fail
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/fi-skl-6600u/igt@kms_flip@basic-plain-flip@c-edp1.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/fi-skl-6600u/igt@kms_flip@basic-plain-flip@c-edp1.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         [PASS][58] -> [FAIL][59] +24 other tests fail
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-edp-1:
    - bat-rplp-1:         [PASS][60] -> [FAIL][61] +28 other tests fail
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-rplp-1/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-edp-1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-rplp-1/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-edp-1.html

  
Known issues
------------

  Here are the changes found in Patchwork_154173v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-mtlp-9:         NOTRUN -> [SKIP][62] ([i915#4613]) +3 other tests skip
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_mmap@basic:
    - bat-mtlp-9:         NOTRUN -> [SKIP][63] ([i915#4083])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@gem_mmap@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-mtlp-9:         NOTRUN -> [SKIP][64] ([i915#4079]) +1 other test skip
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_fence_blits@basic:
    - bat-mtlp-9:         NOTRUN -> [SKIP][65] ([i915#4077]) +2 other tests skip
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@gem_tiled_fence_blits@basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-mtlp-9:         NOTRUN -> [SKIP][66] ([i915#11681] / [i915#6621])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@guc_multi_lrc:
    - bat-dg2-11:         NOTRUN -> [ABORT][67] ([i915#14201])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-11/igt@i915_selftest@live@guc_multi_lrc.html

  * igt@i915_selftest@live@workarounds:
    - bat-arls-5:         [PASS][68] -> [DMESG-FAIL][69] ([i915#12061]) +1 other test dmesg-fail
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-arls-5/igt@i915_selftest@live@workarounds.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
    - bat-dg2-11:         NOTRUN -> [DMESG-FAIL][70] ([i915#12061])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-11/igt@i915_selftest@live@workarounds.html

  * igt@intel_hwmon@hwmon-read:
    - bat-mtlp-9:         NOTRUN -> [SKIP][71] ([i915#7707]) +1 other test skip
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@intel_hwmon@hwmon-read.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-mtlp-9:         NOTRUN -> [SKIP][72] ([i915#5190])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-mtlp-9:         NOTRUN -> [SKIP][73] ([i915#4212]) +8 other tests skip
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-mtlp-9:         NOTRUN -> [SKIP][74] ([i915#4213]) +1 other test skip
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - bat-mtlp-9:         NOTRUN -> [SKIP][75] ([i915#3555] / [i915#3840] / [i915#9159])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-mtlp-9:         NOTRUN -> [SKIP][76]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_psr@psr-primary-mmap-gtt:
    - bat-mtlp-9:         NOTRUN -> [SKIP][77] ([i915#4077] / [i915#9688]) +1 other test skip
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_psr@psr-primary-mmap-gtt.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-mtlp-9:         NOTRUN -> [SKIP][78] ([i915#3555] / [i915#8809])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-gtt:
    - bat-mtlp-9:         NOTRUN -> [SKIP][79] ([i915#3708] / [i915#4077]) +1 other test skip
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@prime_vgem@basic-gtt.html

  * igt@prime_vgem@basic-read:
    - bat-mtlp-9:         NOTRUN -> [SKIP][80] ([i915#3708]) +1 other test skip
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-write:
    - bat-mtlp-9:         NOTRUN -> [SKIP][81] ([i915#10216] / [i915#3708])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_module_load@load:
    - bat-mtlp-9:         [ABORT][82] ([i915#13494]) -> [PASS][83]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-mtlp-9/igt@i915_module_load@load.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-mtlp-9/igt@i915_module_load@load.html

  * igt@i915_selftest@live:
    - bat-arlh-2:         [INCOMPLETE][84] ([i915#14803] / [i915#14838]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-arlh-2/igt@i915_selftest@live.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-arlh-2/igt@i915_selftest@live.html

  * igt@i915_selftest@live@execlists:
    - bat-arlh-2:         [INCOMPLETE][86] -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-arlh-2/igt@i915_selftest@live@execlists.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-arlh-2/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@uncore:
    - bat-dg2-11:         [ABORT][88] ([i915#14201]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-11/igt@i915_selftest@live@uncore.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-11/igt@i915_selftest@live@uncore.html

  
#### Warnings ####

  * igt@i915_selftest@live:
    - bat-dg2-11:         [ABORT][90] ([i915#14201]) -> [ABORT][91] ([i915#12061])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17150/bat-dg2-11/igt@i915_selftest@live.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/bat-dg2-11/igt@i915_selftest@live.html

  
  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
  [i915#14201]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14201
  [i915#14803]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14803
  [i915#14838]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14838
  [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
  [i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
  [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
  [i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
  [i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
  [i915#9159]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9159
  [i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688


Build changes
-------------

  * Linux: CI_DRM_17150 -> Patchwork_154173v1

  CI-20190529: 20190529
  CI_DRM_17150: 78cc74214b6f200319b53d36c4c0ce6974af8d5b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8524: 8524
  Patchwork_154173v1: 78cc74214b6f200319b53d36c4c0ce6974af8d5b @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_154173v1/index.html

[-- Attachment #2: Type: text/html, Size: 23131 bytes --]

Re: [PATCH 6/6] drm: Avoid undefined behavior on u16 multiplication

[Krzysztof Karas]

Hi Jani,

[...]
> > The multitude of files, Fixes and subsequent Cc: stables with different
> > target kernels is just an indication this should be three separate
> > patches.
> >
I was not sure if it should be a single patch encompassing
multiple fixes or three separate, very similar looking ones,
so I'm glad to know how to handle this in the future.

> > The cause may be the same, but they're still unrelated fixes.
> >
> > Moreover, imagine the consequences of one of these fixes ending up being
> > incorrect, and you have to revert or fix it. It's a logistics PITA.
That is a fair point, I'll split them then.
> 
> Also, depending on things introduced in v5.7 means this can't be
> backported to v5.4 either. Not very important here, but something to
> consider for the future.
Noted, thanks for review!

-- 
Best Regards,
Krzysztof

Re: [PATCH 3/6] drm: Remove drm_modeset_backoff() return code

[Krzysztof Karas]

Hi Andi,
[...]
> > --- a/drivers/gpu/drm/drm_mode_config.c
> > +++ b/drivers/gpu/drm/drm_mode_config.c
> > @@ -471,7 +471,7 @@ int drmm_mode_config_init(struct drm_device *dev)
> >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> >  				       &modeset_ctx);
> >  		if (ret == -EDEADLK)
> > -			ret = drm_modeset_backoff(&modeset_ctx);
> > +			drm_modeset_backoff(&modeset_ctx);
> 
> This is a very insignificant change because whether we set ret or
> we don't it doesn't change anything.
This is something that static analyzer pointed out and I decided
that for the sake of having a nice looking code I'd do that and
see whether community accepts it or not.

-- 
Best Regards,
Krzysztof

Re: [PATCH 2/6] drm/i915: Add default case for the switch in igt_smoke_tiling()

[Krzysztof Karas]

Hi Andi,

[...]
> > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> > index 78734c404a6d..6d87356e928b 100644
> > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> > @@ -498,13 +498,15 @@ static int igt_smoke_tiling(void *arg)
> >  			tile.stride = 0;
> >  			tile.swizzle = I915_BIT_6_SWIZZLE_NONE;
> >  			break;
> > -
> >  		case I915_TILING_X:
> >  			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_x;
> >  			break;
> >  		case I915_TILING_Y:
> >  			tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_y;
> >  			break;
> > +		default:
> > +			err = -EINVAL;
> > +			break;
> 
> You are breaking from the switch/case and ending up where? Should
> this be continue?
> 
> If you really want to make static analysers happy (which we don't
> care much) you could do something like:
> 
> 		case I915_TILING_NONE:
> 		default:
> 
> But the C specification is not obliging anyone to use the default
> case, so that we can happily ignore the static analyser issue if
> there is no need for a default.
Hmm, if we indeed do not care about static analyzers, then I
agree that this is pushing it a bit. I may skip this patch in
the next iteration of this series then.

In any case thanks for review!

-- 
Best Regards,
Krzysztof