All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
@ 2025-09-23 13:03 L Lawliet
  2025-09-23 14:43 ` Kurt Borja
  0 siblings, 1 reply; 3+ messages in thread
From: L Lawliet @ 2025-09-23 13:03 UTC (permalink / raw)
  To: platform-driver-x86; +Cc: kuurtb

From 1dad6e971a889c7936d1a54ab38f146bd23ebbf3 Mon Sep 17 00:00:00 2001
From: tr1x_em <admin@trix.is-a.dev>
Date: Tue, 23 Sep 2025 18:24:58 +0530
Subject: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530

Signed-off-by: tr1x_em <admin@trix.is-a.dev>
---
 alienware-wmi-wmax.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/alienware-wmi-wmax.c b/alienware-wmi-wmax.c
index fd550c8..e7ba590 100644
--- a/alienware-wmi-wmax.c
+++ b/alienware-wmi-wmax.c
@@ -209,6 +209,15 @@ static const struct dmi_system_id
awcc_dmi_table[] __initconst = {
         },
         .driver_data = &g_series_quirks,
     },
+    {
+        .ident = "Dell Inc. G15 5530",
+        .matches =
+            {
+                DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                DMI_MATCH(DMI_PRODUCT_NAME, "G15 5530"),
+            },
+        .driver_data = &g_series_quirks,
+    },
     {
         .ident = "Dell Inc. G16 7630",
         .matches = {
-- 
2.51.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
  2025-09-23 13:03 [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530 L Lawliet
@ 2025-09-23 14:43 ` Kurt Borja
  2025-09-24  4:31   ` L Lawliet
  0 siblings, 1 reply; 3+ messages in thread
From: Kurt Borja @ 2025-09-23 14:43 UTC (permalink / raw)
  To: L Lawliet, platform-driver-x86; +Cc: kuurtb

Hi tr1x_em,

Thank you for your patch!

I believe you patched my personal development tree. Upstream patches
should be made on top of the pdx86 Linux tree:

	[1] https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git

This should be Cc'd to subsystem maintainers too. You can get the full
list of maintainers with the get_maintainer.pl script (which is also
found in the tree above):

$ ./scripts/get_maintainer.pl drivers/platform/x86/dell/alienware-wmi-wmax.c

There is also a few issues bellow.

On Tue Sep 23, 2025 at 8:03 AM -05, L Lawliet wrote:
> From 1dad6e971a889c7936d1a54ab38f146bd23ebbf3 Mon Sep 17 00:00:00 2001
> From: tr1x_em <admin@trix.is-a.dev>
> Date: Tue, 23 Sep 2025 18:24:58 +0530
> Subject: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
>

Add a commit description too (even if it's a little redundant).

> Signed-off-by: tr1x_em <admin@trix.is-a.dev>

Patches can only be signed off with a known identity (which is usually
your real name).

> ---
>  alienware-wmi-wmax.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/alienware-wmi-wmax.c b/alienware-wmi-wmax.c
> index fd550c8..e7ba590 100644
> --- a/alienware-wmi-wmax.c
> +++ b/alienware-wmi-wmax.c

Again, diffs should be taken from the root of the Linux tree.

> @@ -209,6 +209,15 @@ static const struct dmi_system_id
> awcc_dmi_table[] __initconst = {
>          },
>          .driver_data = &g_series_quirks,
>      },
> +    {
> +        .ident = "Dell Inc. G15 5530",
> +        .matches =
> +            {
> +                DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                DMI_MATCH(DMI_PRODUCT_NAME, "G15 5530"),
> +            },
> +        .driver_data = &g_series_quirks,
> +    },
>      {
>          .ident = "Dell Inc. G16 7630",
>          .matches = {

I believe your editor or email client messed up the formatting. Kernel
source files use tabs instead of spaces.

Please, check the "Submitting patches" guide if you have doubts:

	[2] https://docs.kernel.org/process/submitting-patches.html


-- 
 ~ Kurt


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
  2025-09-23 14:43 ` Kurt Borja
@ 2025-09-24  4:31   ` L Lawliet
  0 siblings, 0 replies; 3+ messages in thread
From: L Lawliet @ 2025-09-24  4:31 UTC (permalink / raw)
  To: Kurt Borja; +Cc: platform-driver-x86

Thank you kurt for the review
I made some silly mistakes would fix them as soon as possible and send
a canonical patch

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-24  4:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-23 13:03 [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530 L Lawliet
2025-09-23 14:43 ` Kurt Borja
2025-09-24  4:31   ` L Lawliet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.