From: "Yeounsu Moon" <yyyynoom@gmail.com>
To: "Simon Horman" <horms@kernel.org>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: dlink: handle dma_map_single() failure properly
Date: Fri, 10 Oct 2025 00:56:55 +0900 [thread overview]
Message-ID: <DDDWXTRCYVDA.33VBJ38T4QBXH@gmail.com> (raw)
In-Reply-To: <20251008091346.GO3060232@horms.kernel.org>
> Sorry for the slow response, I've been ill for the past few days.
No worries. I hope you're feeling better now.
>
> I did also consider the option above. That is handling the
> errors in the loop. And I can see some merit in that approach,
> e.g. reduced scope of variables.
>
> But I think the more idiomatic approach is to handle them 'here'.
> That is, at the end of the function. So I would lean towards
> that option.
Not only with `goto`, but there are also issues such as replacing `printk()`
with `netdev_info()`. So for now, I'll send the patch that fix `alloc_list()`
correctly.
prev parent reply other threads:[~2025-10-09 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 15:26 [PATCH net] net: dlink: handle dma_map_single() failure properly Yeounsu Moon
2025-10-03 9:44 ` Simon Horman
2025-10-03 12:29 ` Yeounsu Moon
2025-10-03 15:55 ` Jakub Kicinski
2025-10-05 5:22 ` Yeounsu Moon
2025-10-08 9:13 ` Simon Horman
2025-10-09 15:56 ` Yeounsu Moon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDDWXTRCYVDA.33VBJ38T4QBXH@gmail.com \
--to=yyyynoom@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.