All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
@ 2025-10-26 17:25 ` Diederik de Haas
  0 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2025-10-26 17:25 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Dragan Simic, Johan Jonker, Diederik de Haas

Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.

Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index d0e38412d56a..08bf40de17ea 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -789,7 +789,7 @@ &pmu_io_domains {
 	vccio1-supply = <&vccio_acodec>;
 	vccio2-supply = <&vcc_1v8>;
 	vccio3-supply = <&vccio_sd>;
-	vccio4-supply = <&vcc_1v8>;
+	vccio4-supply = <&vcca1v8_pmu>;
 	vccio5-supply = <&vcc_1v8>;
 	vccio6-supply = <&vcc1v8_dvp>;
 	vccio7-supply = <&vcc_3v3>;
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
@ 2025-10-26 17:25 ` Diederik de Haas
  0 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2025-10-26 17:25 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Dragan Simic, Johan Jonker, Diederik de Haas

Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.

Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index d0e38412d56a..08bf40de17ea 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -789,7 +789,7 @@ &pmu_io_domains {
 	vccio1-supply = <&vccio_acodec>;
 	vccio2-supply = <&vcc_1v8>;
 	vccio3-supply = <&vccio_sd>;
-	vccio4-supply = <&vcc_1v8>;
+	vccio4-supply = <&vcca1v8_pmu>;
 	vccio5-supply = <&vcc_1v8>;
 	vccio6-supply = <&vcc1v8_dvp>;
 	vccio7-supply = <&vcc_3v3>;
-- 
2.51.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
  2025-10-26 17:25 ` Diederik de Haas
@ 2025-10-26 17:36   ` Dragan Simic
  -1 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2025-10-26 17:36 UTC (permalink / raw)
  To: Diederik de Haas
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Johan Jonker

Hello Diederik,

On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik@cknow-tech.com> wrote:
> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
> 
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>

Thanks for this patch.  As already discussed in private, this is
correct and safe to do, because both supplies are designated as
always-on, so please feel free to include:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Though, I think this cleanup should also be propagated into the
stable kernels.  Right now this patch doesn't actually introduce
any functional changes, but maybe in the future there will be
some related driver or DT changes or improvements that may end up
relying on DT correction such as this one.

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> index d0e38412d56a..08bf40de17ea 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> @@ -789,7 +789,7 @@ &pmu_io_domains {
>  	vccio1-supply = <&vccio_acodec>;
>  	vccio2-supply = <&vcc_1v8>;
>  	vccio3-supply = <&vccio_sd>;
> -	vccio4-supply = <&vcc_1v8>;
> +	vccio4-supply = <&vcca1v8_pmu>;
>  	vccio5-supply = <&vcc_1v8>;
>  	vccio6-supply = <&vcc1v8_dvp>;
>  	vccio7-supply = <&vcc_3v3>;



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
@ 2025-10-26 17:36   ` Dragan Simic
  0 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2025-10-26 17:36 UTC (permalink / raw)
  To: Diederik de Haas
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Johan Jonker

Hello Diederik,

On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik@cknow-tech.com> wrote:
> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
> 
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>

Thanks for this patch.  As already discussed in private, this is
correct and safe to do, because both supplies are designated as
always-on, so please feel free to include:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Though, I think this cleanup should also be propagated into the
stable kernels.  Right now this patch doesn't actually introduce
any functional changes, but maybe in the future there will be
some related driver or DT changes or improvements that may end up
relying on DT correction such as this one.

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> index d0e38412d56a..08bf40de17ea 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> @@ -789,7 +789,7 @@ &pmu_io_domains {
>  	vccio1-supply = <&vccio_acodec>;
>  	vccio2-supply = <&vcc_1v8>;
>  	vccio3-supply = <&vccio_sd>;
> -	vccio4-supply = <&vcc_1v8>;
> +	vccio4-supply = <&vcca1v8_pmu>;
>  	vccio5-supply = <&vcc_1v8>;
>  	vccio6-supply = <&vcc1v8_dvp>;
>  	vccio7-supply = <&vcc_3v3>;


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
  2025-10-26 17:36   ` Dragan Simic
@ 2025-10-26 18:44     ` Diederik de Haas
  -1 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2025-10-26 18:44 UTC (permalink / raw)
  To: Dragan Simic, Diederik de Haas
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Johan Jonker

Hi,

On Sun Oct 26, 2025 at 6:36 PM CET, Dragan Simic wrote:
> On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik@cknow-tech.com> wrote:
>> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
>> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
>> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
>> 
>> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
>
> Thanks for this patch.  As already discussed in private, this is
> correct and safe to do, because both supplies are designated as
> always-on, so please feel free to include:
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Thanks :-)

> Though, I think this cleanup should also be propagated into the
> stable kernels.  Right now this patch doesn't actually introduce
> any functional changes, but maybe in the future there will be
> some related driver or DT changes or improvements that may end up
> relying on DT correction such as this one.

Fair point. Dunno if b4 picks this up automatically ...

Fixes: 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64 PineTab2")

Cheers,
  Diederik

>> ---
>>  arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> index d0e38412d56a..08bf40de17ea 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> @@ -789,7 +789,7 @@ &pmu_io_domains {
>>  	vccio1-supply = <&vccio_acodec>;
>>  	vccio2-supply = <&vcc_1v8>;
>>  	vccio3-supply = <&vccio_sd>;
>> -	vccio4-supply = <&vcc_1v8>;
>> +	vccio4-supply = <&vcca1v8_pmu>;
>>  	vccio5-supply = <&vcc_1v8>;
>>  	vccio6-supply = <&vcc1v8_dvp>;
>>  	vccio7-supply = <&vcc_3v3>;



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
@ 2025-10-26 18:44     ` Diederik de Haas
  0 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2025-10-26 18:44 UTC (permalink / raw)
  To: Dragan Simic, Diederik de Haas
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Johan Jonker

Hi,

On Sun Oct 26, 2025 at 6:36 PM CET, Dragan Simic wrote:
> On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik@cknow-tech.com> wrote:
>> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
>> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
>> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
>> 
>> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
>
> Thanks for this patch.  As already discussed in private, this is
> correct and safe to do, because both supplies are designated as
> always-on, so please feel free to include:
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Thanks :-)

> Though, I think this cleanup should also be propagated into the
> stable kernels.  Right now this patch doesn't actually introduce
> any functional changes, but maybe in the future there will be
> some related driver or DT changes or improvements that may end up
> relying on DT correction such as this one.

Fair point. Dunno if b4 picks this up automatically ...

Fixes: 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64 PineTab2")

Cheers,
  Diederik

>> ---
>>  arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> index d0e38412d56a..08bf40de17ea 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> @@ -789,7 +789,7 @@ &pmu_io_domains {
>>  	vccio1-supply = <&vccio_acodec>;
>>  	vccio2-supply = <&vcc_1v8>;
>>  	vccio3-supply = <&vccio_sd>;
>> -	vccio4-supply = <&vcc_1v8>;
>> +	vccio4-supply = <&vcca1v8_pmu>;
>>  	vccio5-supply = <&vcc_1v8>;
>>  	vccio6-supply = <&vcc1v8_dvp>;
>>  	vccio7-supply = <&vcc_3v3>;


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-26 18:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-26 17:25 [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2 Diederik de Haas
2025-10-26 17:25 ` Diederik de Haas
2025-10-26 17:36 ` Dragan Simic
2025-10-26 17:36   ` Dragan Simic
2025-10-26 18:44   ` Diederik de Haas
2025-10-26 18:44     ` Diederik de Haas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.