All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T
@ 2025-10-28 11:50 ` FUKAUMI Naoki
  0 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 11:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip,
	FUKAUMI Naoki

The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
and Dual-Role-Power. However, currently it cannot operate as host/
source.

By setting "power-role" to "dual" (along with adding related
properties), the power role can operate as source and the data role
can operate as host.

Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
device's orientation is reverse, the root port is detected but the
device itself is not. This must be addressed separately.
(USB 2.0/1.1 devices operate even in reverse orientation.)

Furthermore, this file is also used by the Radxa ROCK 5B, but the
Type-C port cannot operate as a host regardless of this fix. This must
also be addressed separately.

Fixes: 67b2c15d8fb3c ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
index 3bbe78810ec6f..b77c5a8229e75 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
@@ -331,12 +331,14 @@ usb_con: connector {
 			data-role = "dual";
 			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
 			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
-			power-role = "sink";
+			power-role = "dual";
 			try-power-role = "sink";
 			op-sink-microwatt = <1000000>;
 			sink-pdos =
 				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>,
 				<PDO_VAR(5000, 20000, 5000)>;
+			source-pdos =
+				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
 
 			altmodes {
 				displayport {
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T
@ 2025-10-28 11:50 ` FUKAUMI Naoki
  0 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 11:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip,
	FUKAUMI Naoki

The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
and Dual-Role-Power. However, currently it cannot operate as host/
source.

By setting "power-role" to "dual" (along with adding related
properties), the power role can operate as source and the data role
can operate as host.

Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
device's orientation is reverse, the root port is detected but the
device itself is not. This must be addressed separately.
(USB 2.0/1.1 devices operate even in reverse orientation.)

Furthermore, this file is also used by the Radxa ROCK 5B, but the
Type-C port cannot operate as a host regardless of this fix. This must
also be addressed separately.

Fixes: 67b2c15d8fb3c ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
index 3bbe78810ec6f..b77c5a8229e75 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
@@ -331,12 +331,14 @@ usb_con: connector {
 			data-role = "dual";
 			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
 			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
-			power-role = "sink";
+			power-role = "dual";
 			try-power-role = "sink";
 			op-sink-microwatt = <1000000>;
 			sink-pdos =
 				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>,
 				<PDO_VAR(5000, 20000, 5000)>;
+			source-pdos =
+				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
 
 			altmodes {
 				displayport {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
  2025-10-28 11:50 ` FUKAUMI Naoki
@ 2025-10-28 11:50   ` FUKAUMI Naoki
  -1 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 11:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip,
	FUKAUMI Naoki

The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
and Dual-Role-Power. However, currently it cannot operate as host/
source.

By setting "power-role" to "dual" and "try-power-role" to "sink"
(along with adding related properties), the data role can operate as
host.

Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
device's orientation is reverse, the root port is detected but the
device itself is not. This must be addressed separately.
(USB 2.0/1.1 devices operate even in reverse orientation.)

Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
index bc8140883de47..1664f85db4aaa 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
@@ -484,9 +484,14 @@ usb_con: connector {
 			compatible = "usb-c-connector";
 			data-role = "dual";
 			label = "USB-C";
-			power-role = "source";
+			op-sink-microwatt = <50000>;
+			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
+			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
+			power-role = "dual";
+			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
 			source-pdos =
 				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+			try-power-role = "sink";
 
 			ports {
 				#address-cells = <1>;
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
@ 2025-10-28 11:50   ` FUKAUMI Naoki
  0 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 11:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip,
	FUKAUMI Naoki

The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
and Dual-Role-Power. However, currently it cannot operate as host/
source.

By setting "power-role" to "dual" and "try-power-role" to "sink"
(along with adding related properties), the data role can operate as
host.

Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
device's orientation is reverse, the root port is detected but the
device itself is not. This must be addressed separately.
(USB 2.0/1.1 devices operate even in reverse orientation.)

Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
index bc8140883de47..1664f85db4aaa 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
@@ -484,9 +484,14 @@ usb_con: connector {
 			compatible = "usb-c-connector";
 			data-role = "dual";
 			label = "USB-C";
-			power-role = "source";
+			op-sink-microwatt = <50000>;
+			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
+			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
+			power-role = "dual";
+			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
 			source-pdos =
 				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+			try-power-role = "sink";
 
 			ports {
 				#address-cells = <1>;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T
  2025-10-28 11:50 ` FUKAUMI Naoki
@ 2025-10-28 14:50   ` FUKAUMI Naoki
  -1 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 14:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

On 10/28/25 20:50, FUKAUMI Naoki wrote:
> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
> and Dual-Role-Power. However, currently it cannot operate as host/
> source.
> 
> By setting "power-role" to "dual" (along with adding related
> properties), the power role can operate as source and the data role
> can operate as host.
> 
> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
> device's orientation is reverse, the root port is detected but the
> device itself is not. This must be addressed separately.
> (USB 2.0/1.1 devices operate even in reverse orientation.)
> 
> Furthermore, this file is also used by the Radxa ROCK 5B, but the
> Type-C port cannot operate as a host regardless of this fix. This must
> also be addressed separately.
> 
> Fixes: 67b2c15d8fb3c ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> index 3bbe78810ec6f..b77c5a8229e75 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> @@ -331,12 +331,14 @@ usb_con: connector {
>   			data-role = "dual";
>   			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
>   			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
> -			power-role = "sink";
> +			power-role = "dual";

Ah, this shouldn't be applied for ROCK 5B (which is only "sink").
I will revise the patch to target only ROCK 5B+/5T.

By the way, even without applying this fix, the Type-C port on the ROCK 
5B still won't work as a host. The kernel outputs the following message:

i2c 4-0022: deferred probe pending: typec_fusb302: cannot register tcpm port

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   			try-power-role = "sink";
>   			op-sink-microwatt = <1000000>;
>   			sink-pdos =
>   				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>,
>   				<PDO_VAR(5000, 20000, 5000)>;
> +			source-pdos =
> +				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
>   
>   			altmodes {
>   				displayport {


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T
@ 2025-10-28 14:50   ` FUKAUMI Naoki
  0 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 14:50 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

On 10/28/25 20:50, FUKAUMI Naoki wrote:
> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
> and Dual-Role-Power. However, currently it cannot operate as host/
> source.
> 
> By setting "power-role" to "dual" (along with adding related
> properties), the power role can operate as source and the data role
> can operate as host.
> 
> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
> device's orientation is reverse, the root port is detected but the
> device itself is not. This must be addressed separately.
> (USB 2.0/1.1 devices operate even in reverse orientation.)
> 
> Furthermore, this file is also used by the Radxa ROCK 5B, but the
> Type-C port cannot operate as a host regardless of this fix. This must
> also be addressed separately.
> 
> Fixes: 67b2c15d8fb3c ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> index 3bbe78810ec6f..b77c5a8229e75 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
> @@ -331,12 +331,14 @@ usb_con: connector {
>   			data-role = "dual";
>   			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
>   			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
> -			power-role = "sink";
> +			power-role = "dual";

Ah, this shouldn't be applied for ROCK 5B (which is only "sink").
I will revise the patch to target only ROCK 5B+/5T.

By the way, even without applying this fix, the Type-C port on the ROCK 
5B still won't work as a host. The kernel outputs the following message:

i2c 4-0022: deferred probe pending: typec_fusb302: cannot register tcpm port

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   			try-power-role = "sink";
>   			op-sink-microwatt = <1000000>;
>   			sink-pdos =
>   				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>,
>   				<PDO_VAR(5000, 20000, 5000)>;
> +			source-pdos =
> +				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
>   
>   			altmodes {
>   				displayport {


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
  2025-10-28 11:50   ` FUKAUMI Naoki
@ 2025-10-28 17:24     ` Diederik de Haas
  -1 siblings, 0 replies; 10+ messages in thread
From: Diederik de Haas @ 2025-10-28 17:24 UTC (permalink / raw)
  To: FUKAUMI Naoki, heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

On Tue Oct 28, 2025 at 12:50 PM CET, FUKAUMI Naoki wrote:
> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
> and Dual-Role-Power. However, currently it cannot operate as host/
> source.

You describe the ROCK 5B+/5T while modifying the 5 ITX. If the exact
same logic applies to the 5 ITX, then ``s/5B+\/5T/5 ITX/`` above?

Cheers,
  Diederik

> By setting "power-role" to "dual" and "try-power-role" to "sink"
> (along with adding related properties), the data role can operate as
> host.
>
> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
> device's orientation is reverse, the root port is detected but the
> device itself is not. This must be addressed separately.
> (USB 2.0/1.1 devices operate even in reverse orientation.)
>
> Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> index bc8140883de47..1664f85db4aaa 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> @@ -484,9 +484,14 @@ usb_con: connector {
>  			compatible = "usb-c-connector";
>  			data-role = "dual";
>  			label = "USB-C";
> -			power-role = "source";
> +			op-sink-microwatt = <50000>;
> +			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
> +			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
> +			power-role = "dual";
> +			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
>  			source-pdos =
>  				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> +			try-power-role = "sink";
>  
>  			ports {
>  				#address-cells = <1>;


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
@ 2025-10-28 17:24     ` Diederik de Haas
  0 siblings, 0 replies; 10+ messages in thread
From: Diederik de Haas @ 2025-10-28 17:24 UTC (permalink / raw)
  To: FUKAUMI Naoki, heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

On Tue Oct 28, 2025 at 12:50 PM CET, FUKAUMI Naoki wrote:
> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
> and Dual-Role-Power. However, currently it cannot operate as host/
> source.

You describe the ROCK 5B+/5T while modifying the 5 ITX. If the exact
same logic applies to the 5 ITX, then ``s/5B+\/5T/5 ITX/`` above?

Cheers,
  Diederik

> By setting "power-role" to "dual" and "try-power-role" to "sink"
> (along with adding related properties), the data role can operate as
> host.
>
> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
> device's orientation is reverse, the root port is detected but the
> device itself is not. This must be addressed separately.
> (USB 2.0/1.1 devices operate even in reverse orientation.)
>
> Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> index bc8140883de47..1664f85db4aaa 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> @@ -484,9 +484,14 @@ usb_con: connector {
>  			compatible = "usb-c-connector";
>  			data-role = "dual";
>  			label = "USB-C";
> -			power-role = "source";
> +			op-sink-microwatt = <50000>;
> +			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
> +			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
> +			power-role = "dual";
> +			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
>  			source-pdos =
>  				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> +			try-power-role = "sink";
>  
>  			ports {
>  				#address-cells = <1>;


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
  2025-10-28 17:24     ` Diederik de Haas
@ 2025-10-28 22:46       ` FUKAUMI Naoki
  -1 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 22:46 UTC (permalink / raw)
  To: Diederik de Haas, heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

Hi Diederik,

On 10/29/25 02:24, Diederik de Haas wrote:
> On Tue Oct 28, 2025 at 12:50 PM CET, FUKAUMI Naoki wrote:
>> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
>> and Dual-Role-Power. However, currently it cannot operate as host/
>> source.
> 
> You describe the ROCK 5B+/5T while modifying the 5 ITX. If the exact
> same logic applies to the 5 ITX, then ``s/5B+\/5T/5 ITX/`` above?

Oh, yes, it should be "5 ITX" :)

Thanks!

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Cheers,
>    Diederik
> 
>> By setting "power-role" to "dual" and "try-power-role" to "sink"
>> (along with adding related properties), the data role can operate as
>> host.
>>
>> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
>> device's orientation is reverse, the root port is detected but the
>> device itself is not. This must be addressed separately.
>> (USB 2.0/1.1 devices operate even in reverse orientation.)
>>
>> Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> index bc8140883de47..1664f85db4aaa 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> @@ -484,9 +484,14 @@ usb_con: connector {
>>   			compatible = "usb-c-connector";
>>   			data-role = "dual";
>>   			label = "USB-C";
>> -			power-role = "source";
>> +			op-sink-microwatt = <50000>;
>> +			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
>> +			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
>> +			power-role = "dual";
>> +			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
>>   			source-pdos =
>>   				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
>> +			try-power-role = "sink";
>>   
>>   			ports {
>>   				#address-cells = <1>;
> 
> 



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX
@ 2025-10-28 22:46       ` FUKAUMI Naoki
  0 siblings, 0 replies; 10+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 22:46 UTC (permalink / raw)
  To: Diederik de Haas, heiko
  Cc: robh, krzk+dt, conor+dt, liujianfeng1994, dmitry.baryshkov,
	sebastian.reichel, andy.yan, nicolas.frattaroli, damon.ding,
	jbx6244, detlev.casanova, devicetree, linux-rockchip

Hi Diederik,

On 10/29/25 02:24, Diederik de Haas wrote:
> On Tue Oct 28, 2025 at 12:50 PM CET, FUKAUMI Naoki wrote:
>> The USB Type-C port on the Radxa ROCK 5B+/5T supports Dual-Role-Data
>> and Dual-Role-Power. However, currently it cannot operate as host/
>> source.
> 
> You describe the ROCK 5B+/5T while modifying the 5 ITX. If the exact
> same logic applies to the 5 ITX, then ``s/5B+\/5T/5 ITX/`` above?

Oh, yes, it should be "5 ITX" :)

Thanks!

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Cheers,
>    Diederik
> 
>> By setting "power-role" to "dual" and "try-power-role" to "sink"
>> (along with adding related properties), the data role can operate as
>> host.
>>
>> Unfortunately, a remaining issue is that when a USB 3.0 SuperSpeed
>> device's orientation is reverse, the root port is detected but the
>> device itself is not. This must be addressed separately.
>> (USB 2.0/1.1 devices operate even in reverse orientation.)
>>
>> Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> index bc8140883de47..1664f85db4aaa 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>> @@ -484,9 +484,14 @@ usb_con: connector {
>>   			compatible = "usb-c-connector";
>>   			data-role = "dual";
>>   			label = "USB-C";
>> -			power-role = "source";
>> +			op-sink-microwatt = <50000>;
>> +			/* fusb302 supports PD Rev 2.0 Ver 1.2 */
>> +			pd-revision = /bits/ 8 <0x2 0x0 0x1 0x2>;
>> +			power-role = "dual";
>> +			sink-pdos = <PDO_FIXED(5000, 10, PDO_FIXED_USB_COMM)>;
>>   			source-pdos =
>>   				<PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
>> +			try-power-role = "sink";
>>   
>>   			ports {
>>   				#address-cells = <1>;
> 
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-10-28 22:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28 11:50 [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T FUKAUMI Naoki
2025-10-28 11:50 ` FUKAUMI Naoki
2025-10-28 11:50 ` [PATCH 2/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5 ITX FUKAUMI Naoki
2025-10-28 11:50   ` FUKAUMI Naoki
2025-10-28 17:24   ` Diederik de Haas
2025-10-28 17:24     ` Diederik de Haas
2025-10-28 22:46     ` FUKAUMI Naoki
2025-10-28 22:46       ` FUKAUMI Naoki
2025-10-28 14:50 ` [PATCH 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T FUKAUMI Naoki
2025-10-28 14:50   ` FUKAUMI Naoki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.