Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags

From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Marc Olberding" <molberding@nvidia.com>
Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags
Date: Mon, 24 Nov 2025 09:12:38 +0100	[thread overview]
Message-ID: <DEGRVEN1ZNUY.OCJLFWDG8XD4@kernel.org> (raw)
In-Reply-To: <87jyzfzwpw.fsf@bootlin.com>

[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

Hi,

>> +		.no_sfdp_flags = SECT_4K,
>
> This one is the right fix and should stand alone in its own patch (first
> in the series if you add support for the block protection).

Only if that flash really doesn't have SFDP. But since the entry
didn't have a size property the flash *must* have SFDP in the first
place.  Otherwise it won't even be probed. Please provide a dump of
the SFDP tables, see [1]. Also please provide the contents of
/sys/kernel/debug/spi-nor/spiN.N/params.

-michael

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements

>
>>  		.fixups = &winbond_nor_multi_die_fixups,
>>  	}, {
>>  		.id = SNOR_ID(0xef, 0x50, 0x12),
>
> Thanks,
> Miquèl

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/