Re: [PATCH 1/2] phy: rockchip: inno-usb2: fix disconnection in gadget mode

From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"William Wu" <wulf@rock-chips.com>
Cc: "Kever Yang" <kever.yang@rock-chips.com>,
	"Minas Harutyunyan" <Minas.Harutyunyan@synopsys.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Louis Chauvet" <louis.chauvet@bootlin.com>,
	"Hervé Codina" <herve.codina@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	linux-phy@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] phy: rockchip: inno-usb2: fix disconnection in gadget mode
Date: Thu, 27 Nov 2025 10:48:26 +0100	[thread overview]
Message-ID: <DEJDSE73CJES.2AB8YSKLW6VE1@bootlin.com> (raw)
In-Reply-To: <DEJD8DJZFNZO.11B1UBXJBN7MO@bootlin.com>

On Thu Nov 27, 2025 at 10:22 AM CET, Luca Ceresoli wrote:
> On Tue Nov 25, 2025 at 4:28 PM CET, Théo Lebrun wrote:
>>> The code already checks for !rport->suspended, so add a guard for VBUS as
>>> well to avoid a disconnection when a cable is connected.
>>
>> Your commit message was clear but I was missing one key point: what
>> rport->suspended means. It isn't what I first thought. Instead it means
>> phy is powered off. Naming is bad but unrelated to your series. Maybe
>> add a comment to your commit message like the following?
>>
>>   The code already checks for !rport->suspended (PHY is powered on), ...
>
> You are right. I have added a slightly longer text:
>
>   The code already checks for !rport->suspended (which, somewhat
>   counter-intuitively, means the PHY is powered on), ...
>
> Still worth your Reviewed-by?

Even more so.

> I fixed the other issues you have reported, for patch 2 as well.
>
> I also added the Cc: stable@vger.kernel.org line, which I noticed being
> missing.

I never add that Cc trailer and only rely on `Fixes:`. I thought it
used to be documented as an alternative to that Cc trailer but it does
not show up in `git log -p Documentation/process/stable-kernel-rules.rst`

There is one indirect mention of "scripts that look for commits
containing a 'Fixes:' tag":
https://elixir.bootlin.com/linux/v6.17.9/source/Documentation/process/stable-kernel-rules.rst#L132-L134

Anyway, you do right by explicitly tagging `Cc: stable@...`.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com