All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings
Date: Tue, 16 Dec 2025 23:31:51 +0900	[thread overview]
Message-ID: <DEZPPQVSS2H4.1WGXTSDHIR8J@nvidia.com> (raw)
In-Reply-To: <20251216-nova-fixes-v3-0-c7469a71f7c4@nvidia.com>

On Tue Dec 16, 2025 at 11:57 AM JST, Alexandre Courbot wrote:
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
>
> - Some explicit padding required to safely implement `AsBytes` was
>   missing in the bindings,
> - A bug in the received message length calculation results in the
>   message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
>   bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
>   directly, instead of the alias we defined to limit the diff when we
>   upgrade firmware versions.
>
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical. Other series planned for this cycle will depend on
> them, so one way or the other it would be great to see them in
> drm-rust-next.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Pushed (with Danilo's Acked-by received on Zulip) to drm-rust-fixes,
thanks!

["gpu: nova-core: gsp: fix length of received messages":
  update `PANIC:` comments as pointed out by Joel.]

WARNING: multiple messages have this Message-ID (diff)
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>
Cc: <nouveau@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings
Date: Tue, 16 Dec 2025 23:31:51 +0900	[thread overview]
Message-ID: <DEZPPQVSS2H4.1WGXTSDHIR8J@nvidia.com> (raw)
In-Reply-To: <20251216-nova-fixes-v3-0-c7469a71f7c4@nvidia.com>

On Tue Dec 16, 2025 at 11:57 AM JST, Alexandre Courbot wrote:
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
>
> - Some explicit padding required to safely implement `AsBytes` was
>   missing in the bindings,
> - A bug in the received message length calculation results in the
>   message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
>   bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
>   directly, instead of the alias we defined to limit the diff when we
>   upgrade firmware versions.
>
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical. Other series planned for this cycle will depend on
> them, so one way or the other it would be great to see them in
> drm-rust-next.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Pushed (with Danilo's Acked-by received on Zulip) to drm-rust-fixes,
thanks!

["gpu: nova-core: gsp: fix length of received messages":
  update `PANIC:` comments as pointed out by Joel.]

  parent reply	other threads:[~2025-12-16 14:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  2:57 [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings Alexandre Courbot
2025-12-16  2:57 ` Alexandre Courbot
2025-12-16  2:57 ` [PATCH v3 1/4] gpu: nova-core: bindings: add missing explicit padding Alexandre Courbot
2025-12-16  2:57   ` Alexandre Courbot
2025-12-16  2:57 ` [PATCH v3 2/4] gpu: nova-core: gsp: fix length of received messages Alexandre Courbot
2025-12-16  2:57   ` Alexandre Courbot
2025-12-16  6:14   ` Alistair Popple
2025-12-16  6:14     ` Alistair Popple
2025-12-16  7:57     ` Alexandre Courbot
2025-12-16  9:21   ` Joel Fernandes
2025-12-16  9:21     ` Joel Fernandes
2025-12-16 13:02     ` Alexandre Courbot
2025-12-16  2:57 ` [PATCH v3 3/4] gpu: nova-core: bindings: derive `MaybeZeroable` Alexandre Courbot
2025-12-16  2:57   ` Alexandre Courbot
2025-12-16  2:57 ` [PATCH v3 4/4] gpu: nova-core: gsp: replace firmware version with "bindings" alias Alexandre Courbot
2025-12-16  2:57   ` Alexandre Courbot
2025-12-16  9:21 ` [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings Joel Fernandes
2025-12-16  9:21   ` Joel Fernandes
2025-12-16 14:31 ` Alexandre Courbot [this message]
2025-12-16 14:31   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEZPPQVSS2H4.1WGXTSDHIR8J@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.