* [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail
@ 2025-12-26 22:32 Osama Abdelkader
2025-12-31 14:09 ` Luca Ceresoli
0 siblings, 1 reply; 3+ messages in thread
From: Osama Abdelkader @ 2025-12-26 22:32 UTC (permalink / raw)
To: Andy Yan
Cc: Osama Abdelkader, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel
When drm_bridge_attach() fails, the function should return an error
instead of continuing execution.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 82aaf74e1bc0..b6fe313ccaf8 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
}
ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
- if (ret)
+ if (ret) {
dev_err_probe(dev, ret, "Failed to attach bridge\n");
+ return ERR_PTR(ret);
+ }
dw_dp_init_hw(dp);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail
2025-12-26 22:32 [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail Osama Abdelkader
@ 2025-12-31 14:09 ` Luca Ceresoli
2025-12-31 14:38 ` Osama Abdelkader
0 siblings, 1 reply; 3+ messages in thread
From: Luca Ceresoli @ 2025-12-31 14:09 UTC (permalink / raw)
To: Osama Abdelkader, Andy Yan
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On Fri Dec 26, 2025 at 11:32 PM CET, Osama Abdelkader wrote:
> When drm_bridge_attach() fails, the function should return an error
> instead of continuing execution.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Looks like a bugfix, should it have a 'Fixes:' tag and 'Cc: stable@...'?
See https://docs.kernel.org/process/submitting-patches.html
> --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
> }
>
> ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> - if (ret)
> + if (ret) {
> dev_err_probe(dev, ret, "Failed to attach bridge\n");
> + return ERR_PTR(ret);
> + }
>
> dw_dp_init_hw(dp);
>
It could be more concise, without adding braces:
if (ret)
return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n"));
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail
2025-12-31 14:09 ` Luca Ceresoli
@ 2025-12-31 14:38 ` Osama Abdelkader
0 siblings, 0 replies; 3+ messages in thread
From: Osama Abdelkader @ 2025-12-31 14:38 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Andy Yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel
On Wed, Dec 31, 2025 at 03:09:51PM +0100, Luca Ceresoli wrote:
> On Fri Dec 26, 2025 at 11:32 PM CET, Osama Abdelkader wrote:
> > When drm_bridge_attach() fails, the function should return an error
> > instead of continuing execution.
> >
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
>
> Looks like a bugfix, should it have a 'Fixes:' tag and 'Cc: stable@...'?
> See https://docs.kernel.org/process/submitting-patches.html
>
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
> > }
> >
> > ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> > - if (ret)
> > + if (ret) {
> > dev_err_probe(dev, ret, "Failed to attach bridge\n");
> > + return ERR_PTR(ret);
> > + }
> >
> > dw_dp_init_hw(dp);
> >
>
> It could be more concise, without adding braces:
>
> if (ret)
> return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n"));
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Thanks, v2 is on the way.
Best regards,
Osama
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-31 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 22:32 [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail Osama Abdelkader
2025-12-31 14:09 ` Luca Ceresoli
2025-12-31 14:38 ` Osama Abdelkader
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.