From: "Danilo Krummrich" <dakr@kernel.org>
To: "Benno Lossin" <lossin@kernel.org>
Cc: Maurice Hieronymus <mhi@mailbox.org>,
aliceryhl@google.com, acourbot@nvidia.com, simona@ffwll.ch,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
a.hindborg@kernel.org, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rust: macros: Add derive Display for enums
Date: Mon, 05 Jan 2026 16:00:41 +0100 [thread overview]
Message-ID: <DFGQUPHJVF5M.3EZ2KL4XIMDJH@kernel.org> (raw)
In-Reply-To: <DFGQH1FOS007.3IG8XIBOBWTZI@kernel.org>
On Mon Jan 5, 2026 at 3:42 PM CET, Benno Lossin wrote:
> I'm still skeptical about having a derive macro for `Display`. What
> about adding & deriving the following trait instead:
>
> pub trait EnumVariantName {
> fn variant_name(&self) -> &'static str;
> }
With a derive macro for this trait, that sounds absolutely reasonable -- a
corresponding Display implementation becomes trivial with this.
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Benno Lossin" <lossin@kernel.org>
Cc: "Maurice Hieronymus" <mhi@mailbox.org>, <aliceryhl@google.com>,
<acourbot@nvidia.com>, <airlied@gmail.com>, <simona@ffwll.ch>,
<nouveau@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<ojeda@kernel.org>, <boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <a.hindborg@kernel.org>,
<tmgross@umich.edu>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] rust: macros: Add derive Display for enums
Date: Mon, 05 Jan 2026 16:00:41 +0100 [thread overview]
Message-ID: <DFGQUPHJVF5M.3EZ2KL4XIMDJH@kernel.org> (raw)
In-Reply-To: <DFGQH1FOS007.3IG8XIBOBWTZI@kernel.org>
On Mon Jan 5, 2026 at 3:42 PM CET, Benno Lossin wrote:
> I'm still skeptical about having a derive macro for `Display`. What
> about adding & deriving the following trait instead:
>
> pub trait EnumVariantName {
> fn variant_name(&self) -> &'static str;
> }
With a derive macro for this trait, that sounds absolutely reasonable -- a
corresponding Display implementation becomes trivial with this.
next prev parent reply other threads:[~2026-01-05 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 20:07 [PATCH v2 0/2] rust: macros: Add derive Display for enums Maurice Hieronymus
2026-01-04 20:07 ` Maurice Hieronymus
2026-01-04 20:07 ` [PATCH v2 1/2] " Maurice Hieronymus
2026-01-04 20:07 ` Maurice Hieronymus
2026-01-05 9:02 ` Benno Lossin
2026-01-05 9:02 ` Benno Lossin
2026-01-05 10:29 ` Danilo Krummrich
2026-01-05 10:29 ` Danilo Krummrich
2026-01-05 14:42 ` Benno Lossin
2026-01-05 14:42 ` Benno Lossin
2026-01-05 15:00 ` Danilo Krummrich [this message]
2026-01-05 15:00 ` Danilo Krummrich
2026-01-05 15:23 ` Maurice Hieronymus
2026-01-05 15:23 ` Maurice Hieronymus
2026-01-05 16:11 ` Gary Guo
2026-01-05 16:11 ` Gary Guo
2026-01-05 21:11 ` Maurice Hieronymus
2026-01-05 21:11 ` Maurice Hieronymus
2026-01-05 22:03 ` Danilo Krummrich
2026-01-05 22:03 ` Danilo Krummrich
2026-01-06 5:56 ` Maurice Hieronymus
2026-01-06 5:56 ` Maurice Hieronymus
2026-01-06 12:56 ` Benno Lossin
2026-01-06 12:56 ` Benno Lossin
2026-01-04 20:07 ` [PATCH v2 2/2] gpu: nova-core: Use derive Display for Chipset enum Maurice Hieronymus
2026-01-04 20:07 ` Maurice Hieronymus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFGQUPHJVF5M.3EZ2KL4XIMDJH@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mhi@mailbox.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.