Re: [PATCH v5 7/8] gpu: nova-core: create debugfs root in module init

["Danilo Krummrich" <dakr@kernel.org>]

On Sat Jan 17, 2026 at 9:58 PM CET, Timur Tabi wrote:
> On Sat, 2026-01-17 at 13:29 +0100, Danilo Krummrich wrote:
>> On Fri Jan 16, 2026 at 10:49 PM CET, Timur Tabi wrote:
>> >   impl InPlaceModule for NovaCoreModule {
>> >       fn init(module: &'static kernel::ThisModule) -> impl PinInit<Self, Error> {
>> > +        let dir = Dir::new(kernel::c_str!("nova_core"));
>> > +
>> > +        // SAFETY: we are the only driver code running, so there cannot be any concurrent
>> > access to
>> > +        // `DEBUGFS_ROOT`.
>> > +        unsafe { DEBUGFS_ROOT = Some(dir) };
>> 
>> I think you forgot to add a new Kconfig to nova-core to enable this and in case
>> not set leave it as None.
>
> You don't want the debugfs entries created by default?  That's how it is in Nouveau.

I think it's OK to always have the entries on keeping them beyond device unbind
has to be behind a Kconfig option.

I thought you want this behind a Kconfig in general, otherwise what is
debugfs::Dir::empty() for?