From: "Danilo Krummrich" <dakr@kernel.org>
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: Gary Guo <gary@garyguo.net>,
"mmaurer@google.com" <mmaurer@google.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH v6 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries
Date: Sat, 31 Jan 2026 01:20:55 +0100 [thread overview]
Message-ID: <DG2CFA6SMAMO.GR68NA4YLW76@kernel.org> (raw)
In-Reply-To: <ab90ca9a-a721-41a5-9b28-2af73fda3212@nvidia.com>
On Sat Jan 31, 2026 at 1:16 AM CET, John Hubbard wrote:
> On 1/30/26 4:10 PM, Danilo Krummrich wrote:
>> On Sat Jan 31, 2026 at 12:58 AM CET, Gary Guo wrote:
>>> On Fri Jan 30, 2026 at 11:36 PM GMT, Timur Tabi wrote:
>>>> I think there might be a problem with this code that I don't know how to resolve.
> ...
>> There is no need for CONFIG_NOVA_CORE_DEBUGFS in the first place. The only
>> Kconfig we need is for retaining the GSP log buffers after driver unbind.
>
> Interesting. And in fact...I think we can live without that feature,
> especially if it complicates things here. If someone is debugging,
> and they need logs, they can usually (always?) find a way to leave
> the driver bound long enough to get them, or so I believe after
> some experience doing this. Yes?
I guess you could put a long enough sleep or just leak the debugfs directory.
Not sure how much it hurts developer ergonimics going for multiple iterations
though.
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: "Gary Guo" <gary@garyguo.net>, "Timur Tabi" <ttabi@nvidia.com>,
"mmaurer@google.com" <mmaurer@google.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"Alexandre Courbot" <acourbot@nvidia.com>
Subject: Re: [PATCH v6 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries
Date: Sat, 31 Jan 2026 01:20:55 +0100 [thread overview]
Message-ID: <DG2CFA6SMAMO.GR68NA4YLW76@kernel.org> (raw)
In-Reply-To: <ab90ca9a-a721-41a5-9b28-2af73fda3212@nvidia.com>
On Sat Jan 31, 2026 at 1:16 AM CET, John Hubbard wrote:
> On 1/30/26 4:10 PM, Danilo Krummrich wrote:
>> On Sat Jan 31, 2026 at 12:58 AM CET, Gary Guo wrote:
>>> On Fri Jan 30, 2026 at 11:36 PM GMT, Timur Tabi wrote:
>>>> I think there might be a problem with this code that I don't know how to resolve.
> ...
>> There is no need for CONFIG_NOVA_CORE_DEBUGFS in the first place. The only
>> Kconfig we need is for retaining the GSP log buffers after driver unbind.
>
> Interesting. And in fact...I think we can live without that feature,
> especially if it complicates things here. If someone is debugging,
> and they need logs, they can usually (always?) find a way to leave
> the driver bound long enough to get them, or so I believe after
> some experience doing this. Yes?
I guess you could put a long enough sleep or just leak the debugfs directory.
Not sure how much it hurts developer ergonimics going for multiple iterations
though.
next prev parent reply other threads:[~2026-01-31 0:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 2:28 [PATCH v6 0/7] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-29 2:28 ` [PATCH v6 1/7] rust: device: add device name method Timur Tabi
2026-01-29 2:28 ` [PATCH v6 2/7] rust: uaccess: add write_dma() for copying from DMA buffers to userspace Timur Tabi
2026-01-29 17:24 ` Gary Guo
2026-01-31 0:14 ` Danilo Krummrich
2026-01-31 0:14 ` Danilo Krummrich
2026-01-29 2:28 ` [PATCH v6 3/7] gpu: nova-core: implement BinaryWriter for CoherentAllocation<u8> Timur Tabi
2026-01-30 8:31 ` Alice Ryhl
2026-01-30 8:31 ` Alice Ryhl
2026-01-30 18:53 ` Timur Tabi
2026-01-30 18:53 ` Timur Tabi
2026-01-29 2:28 ` [PATCH v6 4/7] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-29 2:28 ` [PATCH v6 5/7] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-29 2:28 ` [PATCH v6 6/7] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-01-30 8:34 ` Alice Ryhl
2026-01-30 8:34 ` Alice Ryhl
2026-01-30 14:59 ` Timur Tabi
2026-01-30 14:59 ` Timur Tabi
2026-01-29 2:28 ` [PATCH v6 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-30 23:36 ` Timur Tabi
2026-01-30 23:58 ` Gary Guo
2026-01-31 0:07 ` John Hubbard
2026-01-31 0:10 ` Danilo Krummrich
2026-01-31 0:10 ` Danilo Krummrich
2026-01-31 0:16 ` John Hubbard
2026-01-31 0:16 ` John Hubbard
2026-01-31 0:20 ` Danilo Krummrich [this message]
2026-01-31 0:20 ` Danilo Krummrich
2026-01-31 0:24 ` John Hubbard
2026-01-31 0:24 ` John Hubbard
2026-01-31 4:11 ` Timur Tabi
2026-01-31 0:26 ` Timur Tabi
2026-01-31 0:26 ` Timur Tabi
2026-01-31 0:35 ` Danilo Krummrich
2026-01-31 0:35 ` Danilo Krummrich
2026-01-31 0:51 ` Timur Tabi
2026-01-31 0:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG2CFA6SMAMO.GR68NA4YLW76@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.