Report: lenovo_wmi_other FW attributes always read 0

["Kurt Borja" <kuurtb@gmail.com>]

Hi all,

In my system (83KY Legion 7 16IAX1) the current_value of any of the
firmware attributes exposed by this driver always reads 0

	$ ls /sys/class/firmware-attributes/lenovo-wmi-other-0/attributes/
	ppt_pl1_spl  ppt_pl2_sppt  ppt_pl3_fppt

	$ cat /sys/class/firmware-attributes/lenovo-wmi-other-0/attributes/*/current_value
	0
	0
	0

After investigating my acpidump [1] I found that the argument passed to
the WMI method Arg2 is matched as a whole integer instead of individual
bytes (L: 49203)

	If ((ToInteger (Arg2) == 0x01010000))
	{
		Return (^^PC00.LPCB.EC0.F5E0) /* \_SB_.PC00.LPCB.EC0_.F5E0 */
	}

	If ((ToInteger (Arg2) == 0x01020000))
	{
		Return (^^PC00.LPCB.EC0.CCP1) /* \_SB_.PC00.LPCB.EC0_.CCP1 */
	}

	If ((ToInteger (Arg2) == 0x01030000))
	{
		/* This case (CPU FPPT) is actually just zero... */
		Return (Zero)
	}

...and the driver always sets the second byte of Arg2 to the current
profile (mode), which is never zero!

	attribute_id =
		FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) |
		FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) |
	-->	FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, mode) |
		FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id);

So it never actually matches the attribute and falls back to zero :/

This is however, not the case for all tunables. As you can see in the
acpidump, just bellow the block above, these are matched depending on
the current mode (second byte)


	If ((ToInteger (Arg2) == 0x01080100))
	{
		...
	}

	If ((ToInteger (Arg2) == 0x01080200))
	{
		...
	}

	If ((ToInteger (Arg2) == 0x01080300))
	{
		...
	}

	If ((ToInteger (Arg2) == 0x0108FF00))
	{
		...
	}

The fix should be easy for this device but I don't know how other
compatible models handle this argument. Hopefully we can find a solution
that works for everyone?

Thanks for looking into it!

[1] https://lore.kernel.org/platform-driver-x86/DFPEEI5LNJXZ.2E32AHA8VUJW3@gmail.com/2-acpidump.txt

-- 
Thanks,
 ~ Kurt