Re: Report: lenovo_wmi_other FW attributes always read 0

["Kurt Borja" <kuurtb@gmail.com>]

On Wed Feb 4, 2026 at 3:36 AM -05, Derek J. Clark wrote:
> On February 4, 2026 12:00:12 AM PST, Kurt Borja <kuurtb@gmail.com> wrote:
>>Hi all,
>
> Hi Kurt.

Hi Derek,

>
>>In my system (83KY Legion 7 16IAX1) the current_value of any of the
>>firmware attributes exposed by this driver always reads 0
>>
>>	$ ls /sys/class/firmware-attributes/lenovo-wmi-other-0/attributes/
>>	ppt_pl1_spl  ppt_pl2_sppt  ppt_pl3_fppt
>>
>>	$ cat /sys/class/firmware-attributes/lenovo-wmi-other-0/attributes/*/current_value
>>	0
>>	0
>>	0
>>
>>After investigating my acpidump [1] I found that the argument passed to
>>the WMI method Arg2 is matched as a whole integer instead of individual
>>bytes (L: 49203)
>>
>>	If ((ToInteger (Arg2) == 0x01010000))
>>	{
>>		Return (^^PC00.LPCB.EC0.F5E0) /* \_SB_.PC00.LPCB.EC0_.F5E0 */
>>	}
>>
>>	If ((ToInteger (Arg2) == 0x01020000))
>>	{
>>		Return (^^PC00.LPCB.EC0.CCP1) /* \_SB_.PC00.LPCB.EC0_.CCP1 */
>>	}
>>
>>	If ((ToInteger (Arg2) == 0x01030000))
>>	{
>>		/* This case (CPU FPPT) is actually just zero... */
>>		Return (Zero)
>>	}
>>
>>...and the driver always sets the second byte of Arg2 to the current
>>profile (mode), which is never zero!
>>
>>	attribute_id =
>>		FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) |
>>		FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) |
>>	-->	FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, mode) |
>>		FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id);
>>
>>So it never actually matches the attribute and falls back to zero :/
>>
>>This is however, not the case for all tunables. As you can see in the
>>acpidump, just bellow the block above, these are matched depending on
>>the current mode (second byte)
>
> This typically means that the method is stubbed so that it returns 0 on is_supported. During development I forgot to go back and add a check for this when adding the attributes. Per the spec, there is no profile that corresponds to 0x00, so this is working as expected when showing an unsupported attribute. If you add a debug print to the capdata driver when it is querying the attributes you can see the entries are empty. 

Hmm it's weird because if I read

	\_SB_.PC00.LPCB.EC0_.F5E0
	\_SB_.PC00.LPCB.EC0_.CCP1

directly, they show the correct SPPT and SPL values shown in the windows
Legion Space app (under Custom mode).

It seems like these are supported?

>
> Coincidentally, I'm planning on submitting a series this week that adds the missing check for is_supported and also adds the not yet implemented attributes. If you want to take an early preview, it can be found here:
>
> https://github.com/pastaq/linux/tree/pastaq/6.18/lenovo/wmi-next
>
> With this you should only see attributes that are supported.

Same problem, see bellow

	$ fwupdmgr get-bios-settings

	gpu_oc_stat:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the GPU overclocking status
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

	cpu_temp:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU thermal load limit
	  Read Only:            False
	  Minimum value:        85
	  Maximum value:        105
	  Scalar Increment:     1

	gpu_nv_ac_offset:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the Nvidia GPU AC total processing power baseline offset
	  Read Only:            False
	  Minimum value:        10
	  Maximum value:        80
	  Scalar Increment:     1

	gpu_nv_cpu_boost:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the Nvidia GPU to CPU dynamic boost limit
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

	gpu_temp:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the GPU thermal load limit
	  Read Only:            False
	  Minimum value:        75
	  Maximum value:        87
	  Scalar Increment:     1

	ppt_pl1_spl:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU sustained power limit
	  Read Only:            False
	  Minimum value:        50
	  Maximum value:        110
	  Scalar Increment:     1

	cpu_oc_stat:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU overclocking status
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

	ppt_cpu_cl:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU cross loading power limit
	  Read Only:            False
	  Minimum value:        30
	  Maximum value:        75
	  Scalar Increment:     1

	ppt_pl2_sppt:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU slow package power tracking limit
	  Read Only:            False
	  Minimum value:        60
	  Maximum value:        168
	  Scalar Increment:     1

	ppt_pl1_tau:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the CPU sustained power limit exceed duration
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

	gpu_nv_ppab:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the Nvidia GPU power performance aware boost limit
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

	gpu_nv_ctgp:
	  Setting type:         Integer
	  Current Value:        0
	  Description:          Set the GPU configurable total graphics power
	  Read Only:            False
	  Minimum value:        0
	  Maximum value:        0
	  Scalar Increment:     0

Also it still shows SPPT and SPL as supported (which is coherent with
Legion Space).

-- 
Thanks,
 ~ Kurt