From: "Ze Huang" <huang.ze@linux.dev>
To: "Chukun Pan" <amadeus@jmu.edu.cn>, <krzk@kernel.org>
Cc: <broonie@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <dlan@kernel.org>,
<huang.ze@linux.dev>, <krzk+dt@kernel.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-riscv@lists.infradead.org>, <neil.armstrong@linaro.org>,
<robh@kernel.org>, <spacemit@lists.linux.dev>, <vkoul@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY
Date: Tue, 10 Feb 2026 13:50:32 +0800 [thread overview]
Message-ID: <DGB1P3K6I14J.1QCMDY84ZR7ZH@linux.dev> (raw)
In-Reply-To: <20260209064016.1176056-1-amadeus@jmu.edu.cn>
On Mon Feb 9, 2026 at 2:40 PM CST, Chukun Pan wrote:
> Hi,
>
>> Plus, if this was a vbus regulator it would not be called "phy"...
>> Even more confusing.
>
> Sorry, I didn't consider that this naming is confusing. Other
> platforms, such as Rockchip's inno-usb2phy driver, use the
> "phy-supply" property. I continued with this bad naming.
>
>> Bindings are supposed to be complete regardless what driver does
>> (or does not).
>>
>> You must list all supplies with proper names.
>>
>> If this regulator was missing, then what else?
>
> (...)
>
>> Please start describing in the bindings your complete hardware, not
>> your drivers.
>
> It appears Ze Huang described the vbus-supply property in
> spacemit.k1-dwc3.yaml.
>
> So I should enable the regulator in the dwc3-generic-plat driver.
No, we will enable regulator at port level.
>
> Sorry for the noise.
>
> Thanks,
> Chukun
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Ze Huang" <huang.ze@linux.dev>
To: "Chukun Pan" <amadeus@jmu.edu.cn>, <krzk@kernel.org>
Cc: <broonie@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <dlan@kernel.org>,
<huang.ze@linux.dev>, <krzk+dt@kernel.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-riscv@lists.infradead.org>, <neil.armstrong@linaro.org>,
<robh@kernel.org>, <spacemit@lists.linux.dev>, <vkoul@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY
Date: Tue, 10 Feb 2026 13:50:32 +0800 [thread overview]
Message-ID: <DGB1P3K6I14J.1QCMDY84ZR7ZH@linux.dev> (raw)
In-Reply-To: <20260209064016.1176056-1-amadeus@jmu.edu.cn>
On Mon Feb 9, 2026 at 2:40 PM CST, Chukun Pan wrote:
> Hi,
>
>> Plus, if this was a vbus regulator it would not be called "phy"...
>> Even more confusing.
>
> Sorry, I didn't consider that this naming is confusing. Other
> platforms, such as Rockchip's inno-usb2phy driver, use the
> "phy-supply" property. I continued with this bad naming.
>
>> Bindings are supposed to be complete regardless what driver does
>> (or does not).
>>
>> You must list all supplies with proper names.
>>
>> If this regulator was missing, then what else?
>
> (...)
>
>> Please start describing in the bindings your complete hardware, not
>> your drivers.
>
> It appears Ze Huang described the vbus-supply property in
> spacemit.k1-dwc3.yaml.
>
> So I should enable the regulator in the dwc3-generic-plat driver.
No, we will enable regulator at port level.
>
> Sorry for the noise.
>
> Thanks,
> Chukun
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Ze Huang" <huang.ze@linux.dev>
To: "Chukun Pan" <amadeus@jmu.edu.cn>, <krzk@kernel.org>
Cc: <broonie@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <dlan@kernel.org>,
<huang.ze@linux.dev>, <krzk+dt@kernel.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-riscv@lists.infradead.org>, <neil.armstrong@linaro.org>,
<robh@kernel.org>, <spacemit@lists.linux.dev>, <vkoul@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY
Date: Tue, 10 Feb 2026 13:50:32 +0800 [thread overview]
Message-ID: <DGB1P3K6I14J.1QCMDY84ZR7ZH@linux.dev> (raw)
In-Reply-To: <20260209064016.1176056-1-amadeus@jmu.edu.cn>
On Mon Feb 9, 2026 at 2:40 PM CST, Chukun Pan wrote:
> Hi,
>
>> Plus, if this was a vbus regulator it would not be called "phy"...
>> Even more confusing.
>
> Sorry, I didn't consider that this naming is confusing. Other
> platforms, such as Rockchip's inno-usb2phy driver, use the
> "phy-supply" property. I continued with this bad naming.
>
>> Bindings are supposed to be complete regardless what driver does
>> (or does not).
>>
>> You must list all supplies with proper names.
>>
>> If this regulator was missing, then what else?
>
> (...)
>
>> Please start describing in the bindings your complete hardware, not
>> your drivers.
>
> It appears Ze Huang described the vbus-supply property in
> spacemit.k1-dwc3.yaml.
>
> So I should enable the regulator in the dwc3-generic-plat driver.
No, we will enable regulator at port level.
>
> Sorry for the noise.
>
> Thanks,
> Chukun
next prev parent reply other threads:[~2026-02-10 5:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 10:00 [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY Chukun Pan
2026-02-06 10:00 ` Chukun Pan
2026-02-06 10:00 ` Chukun Pan
2026-02-06 10:00 ` [PATCH 2/2] " Chukun Pan
2026-02-06 10:00 ` Chukun Pan
2026-02-06 10:00 ` Chukun Pan
2026-02-07 10:48 ` [PATCH 1/2] dt-bindings: " Krzysztof Kozlowski
2026-02-07 10:48 ` Krzysztof Kozlowski
2026-02-07 10:48 ` Krzysztof Kozlowski
2026-02-07 10:49 ` Krzysztof Kozlowski
2026-02-07 10:49 ` Krzysztof Kozlowski
2026-02-07 10:49 ` Krzysztof Kozlowski
2026-02-07 12:30 ` Ze Huang
2026-02-07 12:30 ` Ze Huang
2026-02-07 12:30 ` Ze Huang
2026-02-07 13:44 ` Krzysztof Kozlowski
2026-02-07 13:44 ` Krzysztof Kozlowski
2026-02-07 13:44 ` Krzysztof Kozlowski
2026-02-09 6:40 ` Chukun Pan
2026-02-09 6:40 ` Chukun Pan
2026-02-09 6:40 ` Chukun Pan
2026-02-10 5:50 ` Ze Huang [this message]
2026-02-10 5:50 ` Ze Huang
2026-02-10 5:50 ` Ze Huang
2026-02-10 7:00 ` Chukun Pan
2026-02-10 7:00 ` Chukun Pan
2026-02-10 7:00 ` Chukun Pan
2026-02-07 11:55 ` Yixun Lan
2026-02-07 11:55 ` Yixun Lan
2026-02-07 11:55 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGB1P3K6I14J.1QCMDY84ZR7ZH@linux.dev \
--to=huang.ze@linux.dev \
--cc=amadeus@jmu.edu.cn \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.