All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: <jic23@kernel.org>, <dlechner@baylibre.com>, <nuno.sa@analog.com>,
	<andy@kernel.org>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] iio: light: gp2ap020a00f: simplify locking with guard()
Date: Mon, 16 Feb 2026 15:04:55 -0600	[thread overview]
Message-ID: <DGGOWGRQGI1C.XSJ585TPVWZA@gmail.com> (raw)
In-Reply-To: <aZLCe_5C8e82EMGO@smile.fi.intel.com>

On Mon Feb 16, 2026 at 1:08 AM CST, Andy Shevchenko wrote:
> On Sun, Feb 15, 2026 at 06:53:16PM -0600, Ethan Tidmore wrote:
>
>>  	struct gp2ap020a00f_data *data = iio_priv(indio_dev);
>>  	int i, err = 0;
>
> Would you need the err assignment now?

I'm not familiar with iio_for_each_active_channel() but, if there's a
chance it could run zero times, then it'd run into if (err) with err
not being initialized?

Thanks,

ET

  reply	other threads:[~2026-02-16 21:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16  0:53 [PATCH v3 0/2] iio: light: gp2ap020a00f: fix return type and simplify locking Ethan Tidmore
2026-02-16  0:53 ` [PATCH v3 1/2] iio: light: gp2ap020a00f: simplify locking with guard() Ethan Tidmore
2026-02-16  7:08   ` Andy Shevchenko
2026-02-16 21:04     ` Ethan Tidmore [this message]
2026-02-17  8:37       ` Andy Shevchenko
2026-02-17  9:02         ` Ethan Tidmore
2026-02-17  9:12           ` Andy Shevchenko
2026-02-17  9:03         ` Andy Shevchenko
2026-02-17  9:10           ` Ethan Tidmore
2026-02-17 10:23             ` Andy Shevchenko
2026-02-16  0:53 ` [PATCH v3 2/2] iio: light: gp2ap020a00f: correct return type to int Ethan Tidmore
2026-02-16  7:10   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGGOWGRQGI1C.XSJ585TPVWZA@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.