From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: light: gp2ap020a00f: correct return type to int
Date: Mon, 16 Feb 2026 09:10:20 +0200 [thread overview]
Message-ID: <aZLC3PPhEa65Fu5S@smile.fi.intel.com> (raw)
In-Reply-To: <20260216005317.11763-3-ethantidmore06@gmail.com>
On Sun, Feb 15, 2026 at 06:53:17PM -0600, Ethan Tidmore wrote:
> The function gp2ap020a00f_get_thresh_reg() can return -EINVAL in its
> error path. Yet, the function has return type of u8. Added error
> checking for gp2ap020a00f_get_thresh_reg() return value.
>
> Detected by Smatch:
> drivers/iio/light/gp2ap020a00f.c:1013 gp2ap020a00f_get_thresh_reg() warn:
> signedness bug returning '(-22)'
LGTM now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-16 7:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 0:53 [PATCH v3 0/2] iio: light: gp2ap020a00f: fix return type and simplify locking Ethan Tidmore
2026-02-16 0:53 ` [PATCH v3 1/2] iio: light: gp2ap020a00f: simplify locking with guard() Ethan Tidmore
2026-02-16 7:08 ` Andy Shevchenko
2026-02-16 21:04 ` Ethan Tidmore
2026-02-17 8:37 ` Andy Shevchenko
2026-02-17 9:02 ` Ethan Tidmore
2026-02-17 9:12 ` Andy Shevchenko
2026-02-17 9:03 ` Andy Shevchenko
2026-02-17 9:10 ` Ethan Tidmore
2026-02-17 10:23 ` Andy Shevchenko
2026-02-16 0:53 ` [PATCH v3 2/2] iio: light: gp2ap020a00f: correct return type to int Ethan Tidmore
2026-02-16 7:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZLC3PPhEa65Fu5S@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.