From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
Simona Vetter <simona@ffwll.ch>,
Alistair Popple <apopple@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Eliot Courtney <ecourtney@nvidia.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Gary Guo <gary@garyguo.net>
Subject: Re: [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference
Date: Tue, 17 Feb 2026 12:33:06 +0100 [thread overview]
Message-ID: <DGH7D7B7GEXG.2QQCBZYWQ4GP8@kernel.org> (raw)
In-Reply-To: <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com>
On Tue Feb 17, 2026 at 3:45 AM CET, Alexandre Courbot wrote:
> We already have a regular reference to the `Device`, so we don't need to
> repeatedly acquire one in this method.
>
> Reviewed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
This conflicts with [1]. I think I will just drop [1] from my queue, since for
nova-core specifically using the base Device here may be better, as eventually
nova-core will work with both a pci::Device and a platform::Device.
(Which also reminds me that at some point we have to treat pci::Bar as generic
I/O backend.)
I hope we can actually keep as many code paths in common as I imagine.
[1] https://lore.kernel.org/all/20260123175854.176735-7-gary@kernel.org/
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
<nouveau@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, "Gary Guo" <gary@garyguo.net>
Subject: Re: [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference
Date: Tue, 17 Feb 2026 12:33:06 +0100 [thread overview]
Message-ID: <DGH7D7B7GEXG.2QQCBZYWQ4GP8@kernel.org> (raw)
In-Reply-To: <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com>
On Tue Feb 17, 2026 at 3:45 AM CET, Alexandre Courbot wrote:
> We already have a regular reference to the `Device`, so we don't need to
> repeatedly acquire one in this method.
>
> Reviewed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
This conflicts with [1]. I think I will just drop [1] from my queue, since for
nova-core specifically using the base Device here may be better, as eventually
nova-core will work with both a pci::Device and a platform::Device.
(Which also reminds me that at some point we have to treat pci::Bar as generic
I/O backend.)
I hope we can actually keep as many code paths in common as I imagine.
[1] https://lore.kernel.org/all/20260123175854.176735-7-gary@kernel.org/
next prev parent reply other threads:[~2026-02-17 11:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 2:45 [PATCH v3 0/8] gpu: nova-core: miscellaneous improvements Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 1/8] gpu: nova-core: gsp: warn if data remains after processing a message Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 2/8] gpu: nova-core: gsp: remove unnecessary Display impls Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 3/8] gpu: nova-core: gsp: simplify sequencer opcode parsing Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 4/8] gpu: nova-core: gsp: remove unneeded sequencer trait Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 5/8] gpu: nova-core: gsp: derive `Debug` on more sequencer types Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 6/8] gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 7/8] gpu: nova-core: use core library's CStr instead of kernel one Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 11:25 ` Danilo Krummrich
2026-02-17 11:25 ` Danilo Krummrich
2026-02-17 14:10 ` Alexandre Courbot
2026-02-17 14:10 ` Alexandre Courbot
2026-02-17 2:45 ` [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference Alexandre Courbot
2026-02-17 2:45 ` Alexandre Courbot
2026-02-17 11:33 ` Danilo Krummrich [this message]
2026-02-17 11:33 ` Danilo Krummrich
2026-02-17 11:33 ` [PATCH v3 0/8] gpu: nova-core: miscellaneous improvements Danilo Krummrich
2026-02-17 11:33 ` Danilo Krummrich
2026-02-19 2:12 ` Alexandre Courbot
2026-02-19 2:12 ` Alexandre Courbot
2026-02-25 1:01 ` Alexandre Courbot
2026-02-25 1:01 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGH7D7B7GEXG.2QQCBZYWQ4GP8@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.