From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: Alistair Popple <apopple@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Eliot Courtney <ecourtney@nvidia.com>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 9/9] gpu: nova-core: use the Generic Bootloader to boot FWSEC on Turing
Date: Tue, 24 Feb 2026 11:31:05 +0900 [thread overview]
Message-ID: <DGMU80KDI2NP.14EXST8YEO2YU@nvidia.com> (raw)
In-Reply-To: <20260212-turing_prep-v9-9-238520ad8799@nvidia.com>
On Thu Feb 12, 2026 at 5:26 PM JST, Alexandre Courbot wrote:
> + let dmem_desc = {
> + let imem_sec = FalconDmaLoadable::imem_sec_load_params(&firmware);
> + let imem_ns = FalconDmaLoadable::imem_ns_load_params(&firmware).ok_or(EINVAL)?;
> + let dmem = FalconDmaLoadable::dmem_load_params(&firmware);
> +
> + BootloaderDmemDescV2 {
> + reserved: [0; 4],
> + signature: [0; 4],
> + ctx_dma: 4, // FALCON_DMAIDX_PHYS_SYS_NCOH
> + code_dma_base: firmware.dma_handle(),
> + non_sec_code_off: imem_ns.dst_start,
> + non_sec_code_size: imem_ns.len,
> + sec_code_off: imem_sec.dst_start,
> + sec_code_size: imem_sec.len,
> + code_entry_point: 0,
> + data_dma_base: firmware.dma_handle() + u64::from(dmem.src_start),
> + data_size: dmem.len,
> + argc: 0,
> + argv: 0,
> + }
> + };
> +
> + // The bootloader's code must be loaded in the area right below the first 64K of IMEM.
> + const BOOTLOADER_LOAD_CEILING: u32 = num::usize_into_u32::<{ sizes::SZ_64K }>();
> + let imem_dst_start = BOOTLOADER_LOAD_CEILING
> + .checked_sub(desc.code_size)
> + .ok_or(EOVERFLOW)?;
Are there any alignment requirements for `imem_dst_start`? Or maybe
`code_size` is always such that the alignment will be fine?
WARNING: multiple messages have this Message-ID (diff)
From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 9/9] gpu: nova-core: use the Generic Bootloader to boot FWSEC on Turing
Date: Tue, 24 Feb 2026 11:31:05 +0900 [thread overview]
Message-ID: <DGMU80KDI2NP.14EXST8YEO2YU@nvidia.com> (raw)
In-Reply-To: <20260212-turing_prep-v9-9-238520ad8799@nvidia.com>
On Thu Feb 12, 2026 at 5:26 PM JST, Alexandre Courbot wrote:
> + let dmem_desc = {
> + let imem_sec = FalconDmaLoadable::imem_sec_load_params(&firmware);
> + let imem_ns = FalconDmaLoadable::imem_ns_load_params(&firmware).ok_or(EINVAL)?;
> + let dmem = FalconDmaLoadable::dmem_load_params(&firmware);
> +
> + BootloaderDmemDescV2 {
> + reserved: [0; 4],
> + signature: [0; 4],
> + ctx_dma: 4, // FALCON_DMAIDX_PHYS_SYS_NCOH
> + code_dma_base: firmware.dma_handle(),
> + non_sec_code_off: imem_ns.dst_start,
> + non_sec_code_size: imem_ns.len,
> + sec_code_off: imem_sec.dst_start,
> + sec_code_size: imem_sec.len,
> + code_entry_point: 0,
> + data_dma_base: firmware.dma_handle() + u64::from(dmem.src_start),
> + data_size: dmem.len,
> + argc: 0,
> + argv: 0,
> + }
> + };
> +
> + // The bootloader's code must be loaded in the area right below the first 64K of IMEM.
> + const BOOTLOADER_LOAD_CEILING: u32 = num::usize_into_u32::<{ sizes::SZ_64K }>();
> + let imem_dst_start = BOOTLOADER_LOAD_CEILING
> + .checked_sub(desc.code_size)
> + .ok_or(EOVERFLOW)?;
Are there any alignment requirements for `imem_dst_start`? Or maybe
`code_size` is always such that the alignment will be fine?
next prev parent reply other threads:[~2026-02-24 2:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 8:26 [PATCH v9 0/9] gpu: nova-core: add Turing support Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 1/9] gpu: nova-core: falcon: rename load parameters to reflect DMA dependency Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 2/9] gpu: nova-core: require DmaObject on FalconDmaLoadable, not FalconFirmware Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 3/9] gpu: nova-core: falcon: remove generic argument from dma_wr Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 4/9] gpu: nova-core: falcon: remove FalconFirmware's dependency on FalconDmaLoadable Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 5/9] gpu: nova-core: move brom_params and boot_addr to FalconFirmware Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 6/9] gpu: nova-core: add PIO support for loading firmware images Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-13 14:47 ` Danilo Krummrich
2026-02-13 14:47 ` Danilo Krummrich
2026-02-22 10:57 ` Alexandre Courbot
2026-02-22 10:57 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 7/9] gpu: nova-core: make Chipset::arch() const Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 8/9] gpu: nova-core: add gen_bootloader firmware to ModInfoBuilder Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 9/9] gpu: nova-core: use the Generic Bootloader to boot FWSEC on Turing Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot
2026-02-24 2:31 ` Eliot Courtney [this message]
2026-02-24 2:31 ` Eliot Courtney
2026-02-27 4:21 ` Alexandre Courbot
2026-02-27 4:21 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGMU80KDI2NP.14EXST8YEO2YU@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.