From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Minu Jin" <s9430939@naver.com>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c
Date: Thu, 26 Feb 2026 20:03:39 -0600 [thread overview]
Message-ID: <DGPDIN1FAML6.3BSV5TDBEBO0X@gmail.com> (raw)
In-Reply-To: <20260226010536.179729-1-azpijr@gmail.com>
On Wed Feb 25, 2026 at 7:05 PM CST, Jose A. Perez de Azpillaga wrote:
> Replace msleep() with fsleep() in rtw_cmd.c to improve delay
> precision and follow modern kernel practices.
>
> Specifically, this fixes a checkpatch warning for the 10ms delay
> in _rtw_free_evt_priv() and updates the 100ms polling loop in
> rtw_chk_hi_queue_hdl() for consistency.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
...
> _cancel_workitem_sync(&pevtpriv->c2h_wk);
> while (pevtpriv->c2h_wk_alive)
> - msleep(10);
> + fsleep(10 * 1000);
It's better to use USEC_PER_MSEC instead of 1000 to avoid magic numbers.
...
> while (!empty && jiffies_to_msecs(jiffies - start) < g_wait_hiq_empty) {
> - msleep(100);
> + fsleep(100 * 1000);
Ditto.
Thanks,
ET
next prev parent reply other threads:[~2026-02-27 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 1:05 [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c Jose A. Perez de Azpillaga
2026-02-27 2:03 ` Ethan Tidmore [this message]
2026-02-27 8:46 ` [PATCH v2] " Jose A. Perez de Azpillaga
2026-02-27 15:18 ` Ethan Tidmore
2026-02-27 16:39 ` Dan Carpenter
2026-02-27 17:16 ` Ethan Tidmore
2026-02-28 4:46 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPDIN1FAML6.3BSV5TDBEBO0X@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=azpijr@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.