All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Dan Carpenter" <dan.carpenter@linaro.org>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Minu Jin" <s9430939@naver.com>, <linux-staging@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c
Date: Fri, 27 Feb 2026 11:16:08 -0600	[thread overview]
Message-ID: <DGPWXAMVCRMC.18JS9LTH3CC8R@gmail.com> (raw)
In-Reply-To: <aaHI2a6DtQlSXS0u@stanley.mountain>

On Fri Feb 27, 2026 at 10:39 AM CST, Dan Carpenter wrote:
> On Fri, Feb 27, 2026 at 09:18:24AM -0600, Ethan Tidmore wrote:
>> On Fri Feb 27, 2026 at 2:46 AM CST, Jose A. Perez de Azpillaga wrote:
>> > Replace msleep() with fsleep() in rtw_cmd.c to improve delay
>> > precision and follow modern kernel practices.
>> >
>> > Specifically, this fixes a checkpatch warning for the 10ms delay
>> > in _rtw_free_evt_priv() and updates the 100ms polling loops in
>> > rtw_chk_hi_queue_hdl() and rtw_free_cmd_priv() for consistency.
>> >
>> > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
>> > ---
>> > v2: changed to USEC_PER_MSEC instead of magic numbers
>> > ---
>> ^^^
>> Remove this.
>> 
>
> Having an extra --- cut off line doesn't matter.  The other thing that
> you sometimes see is an extra blank line before the --- cut off line
> and that's fine too.
>
> regards,
> dan carpenter

Oh ok, nice to know. I guess I assumed the last cut of line was the one
that counted.

Thanks,

ET

  reply	other threads:[~2026-02-27 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  1:05 [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c Jose A. Perez de Azpillaga
2026-02-27  2:03 ` Ethan Tidmore
2026-02-27  8:46 ` [PATCH v2] " Jose A. Perez de Azpillaga
2026-02-27 15:18   ` Ethan Tidmore
2026-02-27 16:39     ` Dan Carpenter
2026-02-27 17:16       ` Ethan Tidmore [this message]
2026-02-28  4:46   ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGPWXAMVCRMC.18JS9LTH3CC8R@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=azpijr@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=s9430939@naver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.