All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Eliot Courtney" <ecourtney@nvidia.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Simona Vetter <simona@ffwll.ch>, Benno Lossin <lossin@kernel.org>,
	Gary Guo <gary@garyguo.net>, Alistair Popple <apopple@nvidia.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	Zhi Wang <zhiw@nvidia.com>
Subject: Re: [PATCH v3 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp`
Date: Wed, 04 Mar 2026 23:17:38 +0900	[thread overview]
Message-ID: <DGU29CRUS8BB.3N1UAT96X34YZ@nvidia.com> (raw)
In-Reply-To: <20260304-cmdq-locking-v3-3-a6314b708850@nvidia.com>

On Wed Mar 4, 2026 at 11:46 AM JST, Eliot Courtney wrote:
<snip>
>  /// Send the [`GetGspInfo`] command and awaits for its reply.
>  pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar0) -> Result<GetGspStaticInfoReply> {
> -    cmdq.send_command(bar, GetGspStaticInfo)?;
> -
> -    loop {
> -        match cmdq.receive_msg::<GetGspStaticInfoReply>(Cmdq::RECEIVE_TIMEOUT) {
> -            Ok(info) => return Ok(info),
> -            Err(ERANGE) => continue,
> -            Err(e) => return Err(e),
> -        }
> -    }
> +    cmdq.send_command(bar, GetGspStaticInfo)

Also noticed something cool while rebasing the unload series on top of
this one: all these command helpers become one-liners and are not really
needed anymore! Here we can just make `GetGspStaticInfo` public and call
`cmdq.send_command` on it directly in `boot`. It removes a layer of
black magic and makes it easier to understand what is going on.


WARNING: multiple messages have this Message-ID (diff)
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Eliot Courtney" <ecourtney@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	<nouveau@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>, "Zhi Wang" <zhiw@nvidia.com>
Subject: Re: [PATCH v3 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp`
Date: Wed, 04 Mar 2026 23:17:38 +0900	[thread overview]
Message-ID: <DGU29CRUS8BB.3N1UAT96X34YZ@nvidia.com> (raw)
In-Reply-To: <20260304-cmdq-locking-v3-3-a6314b708850@nvidia.com>

On Wed Mar 4, 2026 at 11:46 AM JST, Eliot Courtney wrote:
<snip>
>  /// Send the [`GetGspInfo`] command and awaits for its reply.
>  pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar0) -> Result<GetGspStaticInfoReply> {
> -    cmdq.send_command(bar, GetGspStaticInfo)?;
> -
> -    loop {
> -        match cmdq.receive_msg::<GetGspStaticInfoReply>(Cmdq::RECEIVE_TIMEOUT) {
> -            Ok(info) => return Ok(info),
> -            Err(ERANGE) => continue,
> -            Err(e) => return Err(e),
> -        }
> -    }
> +    cmdq.send_command(bar, GetGspStaticInfo)

Also noticed something cool while rebasing the unload series on top of
this one: all these command helpers become one-liners and are not really
needed anymore! Here we can just make `GetGspStaticInfo` public and call
`cmdq.send_command` on it directly in `boot`. It removes a layer of
black magic and makes it easier to understand what is going on.


  parent reply	other threads:[~2026-03-04 14:17 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  2:46 [PATCH v3 0/5] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-03-04  2:46 ` Eliot Courtney
2026-03-04  2:46 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-04  2:46   ` Eliot Courtney
2026-03-04 11:25   ` Gary Guo
2026-03-04 11:25     ` Gary Guo
2026-03-04 11:55     ` Alexandre Courbot
2026-03-04 11:55       ` Alexandre Courbot
2026-03-04  2:46 ` [PATCH v3 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-04  2:46   ` Eliot Courtney
2026-03-04 11:25   ` Gary Guo
2026-03-04 11:25     ` Gary Guo
2026-03-04 11:55   ` Alexandre Courbot
2026-03-04 11:55     ` Alexandre Courbot
2026-03-04  2:46 ` [PATCH v3 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp` Eliot Courtney
2026-03-04  2:46   ` Eliot Courtney
2026-03-04 11:27   ` Gary Guo
2026-03-04 11:27     ` Gary Guo
2026-03-04 11:56   ` Alexandre Courbot
2026-03-04 11:56     ` Alexandre Courbot
2026-03-05  1:34     ` Eliot Courtney
2026-03-05  1:34       ` Eliot Courtney
2026-03-05  2:10       ` Alexandre Courbot
2026-03-05  2:10         ` Alexandre Courbot
2026-03-05  7:44         ` Eliot Courtney
2026-03-05  7:44           ` Eliot Courtney
2026-03-05 10:40           ` Alexandre Courbot
2026-03-05 10:40             ` Alexandre Courbot
2026-03-04 14:17   ` Alexandre Courbot [this message]
2026-03-04 14:17     ` Alexandre Courbot
2026-03-05  1:29     ` Eliot Courtney
2026-03-05  1:29       ` Eliot Courtney
2026-03-05  1:37       ` Alexandre Courbot
2026-03-05  1:37         ` Alexandre Courbot
2026-03-04  2:46 ` [PATCH v3 4/5] gpu: nova-core: gsp: make `Cmdq` a pinned type Eliot Courtney
2026-03-04  2:46   ` Eliot Courtney
2026-03-04  2:46 ` [PATCH v3 5/5] gpu: nova-core: gsp: add mutex locking to Cmdq Eliot Courtney
2026-03-04  2:46   ` Eliot Courtney
2026-03-04 11:57   ` Alexandre Courbot
2026-03-04 11:57     ` Alexandre Courbot
2026-03-05  1:36     ` Eliot Courtney
2026-03-05  1:36       ` Eliot Courtney
2026-03-05  1:51       ` Alexandre Courbot
2026-03-05  1:51         ` Alexandre Courbot
2026-03-04 12:02   ` Alexandre Courbot
2026-03-04 12:02     ` Alexandre Courbot
2026-03-04 11:58 ` [PATCH v3 0/5] gpu: nova-core: gsp: add " Alexandre Courbot
2026-03-04 11:58   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGU29CRUS8BB.3N1UAT96X34YZ@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.