From: Troy Mitchell <troymitchell988@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>, "Yixun Lan" <dlan@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>, "Frank Li" <Frank.Li@kernel.org>,
"Guodong Xu" <guodong@riscstar.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] dt-bindings: dmaengine: Add SpacemiT K1 DMA request definitions
Date: Sat, 28 Mar 2026 17:46:54 +0800 [thread overview]
Message-ID: <DHEBJ4VVDDY2.2KRIW6EP7EXOL@linux.spacemit.com> (raw)
In-Reply-To: <20260327-fancy-nondescript-mouse-cfd6f3@quoll>
On Fri Mar 27, 2026 at 3:27 PM CST, Krzysztof Kozlowski wrote:
> On Thu, Mar 26, 2026 at 04:17:16PM +0800, Troy Mitchell wrote:
>> From: Guodong Xu <guodong@riscstar.com>
>>
>> Add the DMA request numbers for non-secure peripherals of the K1 SoC
>> from SpacemiT.
>>
>> Signed-off-by: Guodong Xu <guodong@riscstar.com>
>> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>> ---
>
> No changelog - neither here, nor in commit msg.
My apologies, patches 1-6 were added in v2.
I missed including this in the version history..
>
>> include/dt-bindings/dma/k1-pdma.h | 56 +++++++++++++++++++++++++++++++++++++++
>
> So previous review applies, no? Was there such?
No, since it's a new addition, there are naturally no previous reviews.
- Troy
WARNING: multiple messages have this Message-ID (diff)
From: Troy Mitchell <troymitchell988@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>, "Yixun Lan" <dlan@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>, "Frank Li" <Frank.Li@kernel.org>,
"Guodong Xu" <guodong@riscstar.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] dt-bindings: dmaengine: Add SpacemiT K1 DMA request definitions
Date: Sat, 28 Mar 2026 17:46:54 +0800 [thread overview]
Message-ID: <DHEBJ4VVDDY2.2KRIW6EP7EXOL@linux.spacemit.com> (raw)
In-Reply-To: <20260327-fancy-nondescript-mouse-cfd6f3@quoll>
On Fri Mar 27, 2026 at 3:27 PM CST, Krzysztof Kozlowski wrote:
> On Thu, Mar 26, 2026 at 04:17:16PM +0800, Troy Mitchell wrote:
>> From: Guodong Xu <guodong@riscstar.com>
>>
>> Add the DMA request numbers for non-secure peripherals of the K1 SoC
>> from SpacemiT.
>>
>> Signed-off-by: Guodong Xu <guodong@riscstar.com>
>> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>> ---
>
> No changelog - neither here, nor in commit msg.
My apologies, patches 1-6 were added in v2.
I missed including this in the version history..
>
>> include/dt-bindings/dma/k1-pdma.h | 56 +++++++++++++++++++++++++++++++++++++++
>
> So previous review applies, no? Was there such?
No, since it's a new addition, there are naturally no previous reviews.
- Troy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-28 9:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 8:17 [PATCH v2 0/7] dmaengine: Add Peripheral DMA support for SpacemiT K3 SoC Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 1/7] dt-bindings: dmaengine: Add SpacemiT K1 DMA request definitions Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-27 7:27 ` Krzysztof Kozlowski
2026-03-27 7:27 ` Krzysztof Kozlowski
2026-03-28 9:46 ` Troy Mitchell [this message]
2026-03-28 9:46 ` Troy Mitchell
2026-03-27 7:28 ` Krzysztof Kozlowski
2026-03-27 7:28 ` Krzysztof Kozlowski
2026-03-28 9:48 ` Troy Mitchell
2026-03-28 9:48 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 2/7] dt-bindings: dmaengine: Add SpacemiT K3 DMA compatible string Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-26 18:34 ` Conor Dooley
2026-03-26 18:34 ` Conor Dooley
2026-03-27 7:04 ` Troy Mitchell
2026-03-27 7:04 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 3/7] dt-bindings: dmaengine: Add SpacemiT K3 DMA request definitions Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-27 7:30 ` Krzysztof Kozlowski
2026-03-27 7:30 ` Krzysztof Kozlowski
2026-03-28 9:58 ` Troy Mitchell
2026-03-28 9:58 ` Troy Mitchell
2026-03-28 11:35 ` Krzysztof Kozlowski
2026-03-28 11:35 ` Krzysztof Kozlowski
2026-03-26 8:17 ` [PATCH v2 4/7] dmaengine: mmp_pdma: support variable extended DRCMR base Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 5/7] dmaengine: mmp_pdma: add Spacemit K3 support Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 6/7] clk: spacemit: k3: mark top_dclk as CLK_IS_CRITICAL Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
2026-03-26 8:17 ` [PATCH v2 7/7] riscv: dts: spacemit: Add PDMA controller node for K3 SoC Troy Mitchell
2026-03-26 8:17 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHEBJ4VVDDY2.2KRIW6EP7EXOL@linux.spacemit.com \
--to=troymitchell988@gmail.com \
--cc=Frank.Li@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=guodong@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.