[LTP] [PATCH 1/1] include: Remove 'make install' support

[LTP] [PATCH 1/1] include: Remove 'make install' support

[Petr Vorel]

LTP headers aren't needed to be installed, they are unusable without LTP
core library anyway (which is not separated from sources). Therefore
newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add
leaf Makefile") did not support it. Remove it also from
include/Makefile.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,

trivial patch, but I'd appreciate your ack that we really don't want
headers to be installed. Otherwise it'd have to be added also to
include/lapi/Makefile (added in 684cae7552).

Kind regards,
Petr

 include/Makefile | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/include/Makefile b/include/Makefile
index 84cd4ed6e3..7fe72a2557 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -1,19 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 # Copyright (C) 2009, Cisco Systems Inc.
+# Copyright (c) Linux Test Project, 2026
 # Ngie Cooper, July 2009
 
 top_srcdir		?= ..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
-INSTALL_DIR		:= $(includedir)
-
-INSTALL_MODE		:= 00644
-
-INSTALL_TARGETS		:= *.h
-
-MAKE_TARGETS		:=
-
 .PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean
 distclean:: clean ac-distclean
 maintainer-clean:: distclean ac-maintainer-clean
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] include: Remove 'make install' support

[linuxtestproject.agent]

Hi Petr,

On Wed, 22 Apr 2026, Petr Vorel wrote:
> include: Remove 'make install' support

> +# Copyright (c) Linux Test Project, 2026

Nit: existing line above uses "(C)" (uppercase); "(c)" here is inconsistent.

Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>

---
Note:

Our agent completed the review of the patch. The full review can be
found at: <review_url>

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] include: Remove 'make install' support

[Ricardo B. Marlière via ltp]

On Wed Apr 22, 2026 at 8:31 AM -03, Petr Vorel wrote:
> LTP headers aren't needed to be installed, they are unusable without LTP
> core library anyway (which is not separated from sources). Therefore
> newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add
> leaf Makefile") did not support it. Remove it also from
> include/Makefile.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Reviewed-by: Ricardo B. Marlière <rbm@suse.com>

> ---
> Hi,
>
> trivial patch, but I'd appreciate your ack that we really don't want
> headers to be installed. Otherwise it'd have to be added also to
> include/lapi/Makefile (added in 684cae7552).

Thanks!

>
> Kind regards,
> Petr
>
>  include/Makefile | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/include/Makefile b/include/Makefile
> index 84cd4ed6e3..7fe72a2557 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -1,19 +1,12 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  # Copyright (C) 2009, Cisco Systems Inc.
> +# Copyright (c) Linux Test Project, 2026
>  # Ngie Cooper, July 2009
>  
>  top_srcdir		?= ..
>  
>  include $(top_srcdir)/include/mk/env_pre.mk
>  
> -INSTALL_DIR		:= $(includedir)
> -
> -INSTALL_MODE		:= 00644
> -
> -INSTALL_TARGETS		:= *.h
> -
> -MAKE_TARGETS		:=
> -
>  .PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean
>  distclean:: clean ac-distclean
>  maintainer-clean:: distclean ac-maintainer-clean


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] include: Remove 'make install' support

[Li Wang]

Petr Vorel <pvorel@suse.cz> wrote:

> LTP headers aren't needed to be installed, they are unusable without LTP
> core library anyway (which is not separated from sources). Therefore
> newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add
> leaf Makefile") did not support it. Remove it also from
> include/Makefile.

That's right, we don't need to install the LTP headers.

Reviewed-by: Li Wang <wangli.ahau@gmail.com>


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] include: Remove 'make install' support

[Jan Stancek via ltp]

On Wed, Apr 22, 2026 at 1:31 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> LTP headers aren't needed to be installed, they are unusable without LTP
> core library anyway (which is not separated from sources). Therefore
> newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add
> leaf Makefile") did not support it. Remove it also from
> include/Makefile.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Acked-by: Jan Stancek <jstancek@redhat.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] include: Remove 'make install' support

[Petr Vorel]

> On Wed, Apr 22, 2026 at 1:31 PM Petr Vorel <pvorel@suse.cz> wrote:

> > LTP headers aren't needed to be installed, they are unusable without LTP
> > core library anyway (which is not separated from sources). Therefore
> > newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add
> > leaf Makefile") did not support it. Remove it also from
> > include/Makefile.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Acked-by: Jan Stancek <jstancek@redhat.com>

Jan, thanks for your ack. I merged patch yesterday, I'm sorry, unfortunately I
forgot to write that on ML. Next time I'll wait a bit longer and verify that I
replied that patch was merged (it'd be great to have tooling to post info about
merging).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp