From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Conor Dooley" <conor@kernel.org>, "Linus Walleij" <linusw@kernel.org>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Yixun Lan" <dlan@kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>
Subject: Re: [PATCH v2 4/4] pinctrl: spacemit: move over to generic pinmux dt_node_to_map implementation
Date: Fri, 22 May 2026 19:26:49 +0800 [thread overview]
Message-ID: <DIP63LFPHYTN.XDUDRDCPPZVQ@linux.spacemit.com> (raw)
In-Reply-To: <20260519-cosmetics-careless-0e9a219c51ef@spud>
On Tue May 19, 2026 at 5:37 PM CST, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Replace the custom implementation of dt_node_to_map with
> pinctrl_generic_dt_node_to_map() to demonstrate its use.
> spacemit_pin_mux_config didn't provide much value in the first place,
> because the group contains the information required to look up the
> spacemit_pin struct corresponding to a pin, so there's no loss in
> functionality as a result of the generic function carrying only the mux
> data in the group's data pointer rather than having an array of
> spacemit_pin_mux_config structs.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Conor Dooley" <conor@kernel.org>, "Linus Walleij" <linusw@kernel.org>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Yixun Lan" <dlan@kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>
Subject: Re: [PATCH v2 4/4] pinctrl: spacemit: move over to generic pinmux dt_node_to_map implementation
Date: Fri, 22 May 2026 19:26:49 +0800 [thread overview]
Message-ID: <DIP63LFPHYTN.XDUDRDCPPZVQ@linux.spacemit.com> (raw)
In-Reply-To: <20260519-cosmetics-careless-0e9a219c51ef@spud>
On Tue May 19, 2026 at 5:37 PM CST, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Replace the custom implementation of dt_node_to_map with
> pinctrl_generic_dt_node_to_map() to demonstrate its use.
> spacemit_pin_mux_config didn't provide much value in the first place,
> because the group contains the information required to look up the
> spacemit_pin struct corresponding to a pin, so there's no loss in
> functionality as a result of the generic function carrying only the mux
> data in the group's data pointer rather than having an array of
> spacemit_pin_mux_config structs.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
next prev parent reply other threads:[~2026-05-22 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 9:37 [PATCH v2 0/4] generic pinmux dt_node_to_map implementation/spacemit driver converted to use it Conor Dooley
2026-05-19 9:37 ` Conor Dooley
2026-05-19 9:37 ` [PATCH v2 1/4] pinctrl: generic: change signature of pinctrl_generic_to_map() to pass void data Conor Dooley
2026-05-19 9:37 ` Conor Dooley
2026-05-19 9:37 ` [PATCH v2 2/4] pinctrl: add new generic groups/function creation function for pinmux Conor Dooley
2026-05-19 9:37 ` Conor Dooley
2026-05-22 11:26 ` Troy Mitchell
2026-05-22 11:26 ` Troy Mitchell
2026-05-19 9:37 ` [PATCH v2 3/4] pinctrl: spacemit: delete spacemit_pctrl_check_power() Conor Dooley
2026-05-19 9:37 ` Conor Dooley
2026-05-19 9:37 ` [PATCH v2 4/4] pinctrl: spacemit: move over to generic pinmux dt_node_to_map implementation Conor Dooley
2026-05-19 9:37 ` Conor Dooley
2026-05-22 11:26 ` Troy Mitchell [this message]
2026-05-22 11:26 ` Troy Mitchell
2026-05-26 12:52 ` [PATCH v2 0/4] generic pinmux dt_node_to_map implementation/spacemit driver converted to use it Linus Walleij
2026-05-26 12:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIP63LFPHYTN.XDUDRDCPPZVQ@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=dlan@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.