From: "Danilo Krummrich" <dakr@kernel.org>
To: "Hongling Zeng" <zhongling0719@126.com>
Cc: Hongling Zeng <zenghongling@kylinos.cn>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
simona@ffwll.ch, airlied@redhat.com, bskeggs@nvidia.com,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nouveau/gsp: fix NULL pointer dereference in r535 nvenc/ofs alloc
Date: Wed, 27 May 2026 12:39:39 +0200 [thread overview]
Message-ID: <DITE87NC3I9L.QHBKWC4PEMX4@kernel.org> (raw)
In-Reply-To: <6A164F51.7010203@126.com>
On Wed May 27, 2026 at 3:56 AM CEST, Hongling Zeng wrote:
> Should I submit a patch to clean up the IS_ERR_OR_NULL() checks in:
> - nvkm_gsp_rm_alloc_get() / nvkm_gsp_rm_alloc()
> - nvkm_gsp_rpc_rd()
> - All the callers
Sounds good. Ideally, where it makes sense, do it in separate patches and send a
series.
Thanks,
Danilo
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Hongling Zeng" <zhongling0719@126.com>
Cc: "Hongling Zeng" <zenghongling@kylinos.cn>, <lyude@redhat.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<airlied@redhat.com>, <ttabi@nvidia.com>, <bskeggs@nvidia.com>,
<dri-devel@lists.freedesktop.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nouveau/gsp: fix NULL pointer dereference in r535 nvenc/ofs alloc
Date: Wed, 27 May 2026 12:39:39 +0200 [thread overview]
Message-ID: <DITE87NC3I9L.QHBKWC4PEMX4@kernel.org> (raw)
In-Reply-To: <6A164F51.7010203@126.com>
On Wed May 27, 2026 at 3:56 AM CEST, Hongling Zeng wrote:
> Should I submit a patch to clean up the IS_ERR_OR_NULL() checks in:
> - nvkm_gsp_rm_alloc_get() / nvkm_gsp_rm_alloc()
> - nvkm_gsp_rpc_rd()
> - All the callers
Sounds good. Ideally, where it makes sense, do it in separate patches and send a
series.
Thanks,
Danilo
next prev parent reply other threads:[~2026-05-27 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 1:47 [PATCH] nouveau/gsp: fix NULL pointer dereference in r535 nvenc/ofs alloc Hongling Zeng
2026-05-26 13:16 ` Danilo Krummrich
2026-05-26 13:16 ` Danilo Krummrich
2026-05-27 1:56 ` Hongling Zeng
2026-05-27 1:56 ` Hongling Zeng
2026-05-27 10:39 ` Danilo Krummrich [this message]
2026-05-27 10:39 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DITE87NC3I9L.QHBKWC4PEMX4@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@redhat.com \
--cc=bskeggs@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.