From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Lyude Paul" <lyude@redhat.com>,
dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Christian König" <christian.koenig@amd.com>,
driver-core@lists.linux.dev, "Miguel Ojeda" <ojeda@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Simona Vetter" <simona@ffwll.ch>,
linux-kernel@vger.kernel.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maxime Ripard" <mripard@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Benno Lossin" <lossin@kernel.org>,
linaro-mm-sig@lists.linaro.org,
"Mukesh Kumar Chaurasiya" <mkchauras@gmail.com>,
"Asahi Lina" <lina+kernel@asahilina.net>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v20 3/4] rust: faux: Allow retrieving a bound Device
Date: Fri, 12 Jun 2026 22:17:30 +0200 [thread overview]
Message-ID: <DJ7CJCZRHT1R.3LZDILZ7HTXQ3@kernel.org> (raw)
In-Reply-To: <DJ7AXOH0W92V.1L1869KO4C1H9@garyguo.net>
On Fri Jun 12, 2026 at 9:02 PM CEST, Gary Guo wrote:
>> +impl AsRef<device::Device<device::Bound>> for Registration {
>> + fn as_ref(&self) -> &device::Device<device::Bound> {
>> + // SAFETY:
>> + // - The underlying `device` in `faux_device` is guaranteed by the C API to be a valid
>> + // initialized `device`.
>> + // - faux_match() always returns 1, and probe runs synchronously (PROBE_FORCE_SYNCHRONOUS).
>
> Please quote all code with backticks.
As far as I'm concerned there's no need to do that for things that are not
rendered anyway. But also feel free to do it anyway of course.
Thanks,
Danilo
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Christian König" <christian.koenig@amd.com>,
driver-core@lists.linux.dev, "Miguel Ojeda" <ojeda@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Simona Vetter" <simona@ffwll.ch>,
linux-kernel@vger.kernel.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
linaro-mm-sig@lists.linaro.org,
"Mukesh Kumar Chaurasiya" <mkchauras@gmail.com>,
"Asahi Lina" <lina+kernel@asahilina.net>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v20 3/4] rust: faux: Allow retrieving a bound Device
Date: Fri, 12 Jun 2026 22:17:30 +0200 [thread overview]
Message-ID: <DJ7CJCZRHT1R.3LZDILZ7HTXQ3@kernel.org> (raw)
In-Reply-To: <DJ7AXOH0W92V.1L1869KO4C1H9@garyguo.net>
On Fri Jun 12, 2026 at 9:02 PM CEST, Gary Guo wrote:
>> +impl AsRef<device::Device<device::Bound>> for Registration {
>> + fn as_ref(&self) -> &device::Device<device::Bound> {
>> + // SAFETY:
>> + // - The underlying `device` in `faux_device` is guaranteed by the C API to be a valid
>> + // initialized `device`.
>> + // - faux_match() always returns 1, and probe runs synchronously (PROBE_FORCE_SYNCHRONOUS).
>
> Please quote all code with backticks.
As far as I'm concerned there's no need to do that for things that are not
rendered anyway. But also feel free to do it anyway of course.
Thanks,
Danilo
next prev parent reply other threads:[~2026-06-12 20:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 16:21 [PATCH v20 0/4] Rust bindings for gem shmem Lyude Paul
2026-06-10 16:21 ` Lyude Paul
2026-06-10 16:21 ` [PATCH v20 1/4] rust: drm: gem: shmem: Add DmaResvGuard helper Lyude Paul
2026-06-10 16:21 ` Lyude Paul
2026-06-11 11:07 ` Alice Ryhl
2026-06-11 11:07 ` Alice Ryhl
2026-06-12 18:41 ` Gary Guo
2026-06-12 18:41 ` Gary Guo
2026-06-10 16:21 ` [PATCH v20 2/4] rust: drm: gem: shmem: Add vmap functions Lyude Paul
2026-06-10 16:21 ` Lyude Paul
2026-06-10 16:39 ` sashiko-bot
2026-06-11 11:10 ` Alice Ryhl
2026-06-11 11:10 ` Alice Ryhl
2026-06-11 17:01 ` Deborah Brouwer
2026-06-11 17:01 ` Deborah Brouwer
2026-06-12 18:39 ` [Linaro-mm-sig] " lyude
2026-06-12 18:39 ` lyude
2026-06-10 16:21 ` [PATCH v20 3/4] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-10 16:21 ` Lyude Paul
2026-06-10 16:37 ` sashiko-bot
2026-06-11 11:10 ` Alice Ryhl
2026-06-11 11:10 ` Alice Ryhl
2026-06-12 19:02 ` Gary Guo
2026-06-12 19:02 ` Gary Guo
2026-06-12 20:17 ` Danilo Krummrich [this message]
2026-06-12 20:17 ` Danilo Krummrich
2026-06-10 16:21 ` [PATCH v20 4/4] rust: drm: gem: Introduce shmem::Object::sg_table() Lyude Paul
2026-06-10 16:21 ` Lyude Paul
2026-06-10 16:46 ` sashiko-bot
2026-06-11 12:06 ` [PATCH v20 0/4] Rust bindings for gem shmem Danilo Krummrich
2026-06-11 12:06 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ7CJCZRHT1R.3LZDILZ7HTXQ3@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=christian.koenig@amd.com \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=lina+kernel@asahilina.net \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mkchauras@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.