Re: [PATCH v2 bpf-next/net 5/5] selftest: bpf: Add test for hwtstamp proxy.

["Alexei Starovoitov" <alexei.starovoitov@gmail.com>]

On Fri Jun 12, 2026 at 6:00 PM PDT, Kuniyuki Iwashima wrote:
> diff --git a/tools/testing/selftests/bpf/bpf_kfuncs.h b/tools/testing/selftests/bpf/bpf_kfuncs.h
> index 7dad01439391..8d119b10ed0d 100644
> --- a/tools/testing/selftests/bpf/bpf_kfuncs.h
> +++ b/tools/testing/selftests/bpf/bpf_kfuncs.h
> @@ -92,4 +92,14 @@ extern int bpf_set_dentry_xattr(struct dentry *dentry, const char *name__str,
>  				const struct bpf_dynptr *value_p, int flags) __ksym __weak;
>  extern int bpf_remove_dentry_xattr(struct dentry *dentry, const char *name__str) __ksym __weak;
>  
> +extern int bpf_skb_scrub_tx_tstamp(struct __sk_buff *s) __ksym __weak;
> +
> +struct bpf_hwtstamp;
> +extern int bpf_skb_set_hwtstamp(struct __sk_buff *s,
> +				struct bpf_hwtstamp *attrs, int attrs__sz) __ksym __weak;
> +
> +struct bpf_tx_tstamp_cmpl;
> +extern int bpf_skb_complete_tx_tstamp(struct __sk_buff *s,
> +				      struct bpf_tx_tstamp_cmpl *attrs,
> +				      int attrs__sz) __ksym __weak;

...

> diff --git a/tools/testing/selftests/bpf/progs/proxy_hwtstamp.c b/tools/testing/selftests/bpf/progs/proxy_hwtstamp.c
> new file mode 100644
> index 000000000000..e13963f2393e
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/proxy_hwtstamp.c
> @@ -0,0 +1,236 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright 2026 Google LLC */
> +
> +#include "vmlinux.h"

Please update your pahole. It must be old, since you had
the need to add kfuncs defs into bpf_kfuncs.h.
pahole was improved couple years ago and all kfuncs now
in vmlinux.h automatically.

Overall, the set looks good to me, but I would like
to see an ack for networking bits from somebody.

bpf-next/net was the right subj to use, but this is very late
into release cycle, so I prefer to land it to bpf-next/master
and send together with main bpf-next PR.

Kuba,
is is ok with you? thoughts on patchset overall?