From: "Prashant Rahul" <prashantrahul23@gmail.com>
To: "Dan Carpenter" <error27@gmail.com>,
"Prashant Rahul" <prashantrahul23@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Shuah Khan" <shuah@kernel.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] staging: octeon: handle rx/tx initialization failures in probe
Date: Mon, 29 Jun 2026 21:49:49 +0530 [thread overview]
Message-ID: <DJLO4N0H5YYF.1GOPQDJ9QVG4A@gmail.com> (raw)
In-Reply-To: <akIiVWOOfjbdM_G-@stanley.mountain>
On Mon Jun 29, 2026 at 1:14 PM IST, Dan Carpenter wrote:
> cvmx_pko_shutdown() has a built in call to
> cvmx_pko_disable() so why are we calling that separately?
Didn't realize cvmx_pko_shutdown did that. Will remove that. Also, Should
I remove the cvmx_pko_disable() call in the remove function in this patch
series? Or should I do that in a new patch?
> Also I feel like probe() should fail if alloc_netdev() fails
> or register_netdev(), but that's not introduced by this patch
> either.
My main goal with the patch series was to get rid of panic() calls in
some of the initialization error paths. I will look into properly handling
alloc_etherdev and register_netdev errors but in new patch(es).
regards,
Prashant Rahul
next prev parent reply other threads:[~2026-06-29 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 7:01 [PATCH 0/4] staging: octeon: Improve initialization error handling Prashant Rahul
2026-06-28 7:01 ` [PATCH 1/4] staging: octeon: factor out device removal into a helper Prashant Rahul
2026-06-29 7:25 ` Dan Carpenter
2026-06-29 7:45 ` Dan Carpenter
2026-06-28 7:01 ` [PATCH 2/4] staging: octeon: Propagate rx initialization failures Prashant Rahul
2026-06-28 7:01 ` [PATCH 3/4] staging: octeon: Propagate tx " Prashant Rahul
2026-06-28 7:01 ` [PATCH 4/4] staging: octeon: handle rx/tx initialization failures in probe Prashant Rahul
2026-06-29 7:44 ` Dan Carpenter
2026-06-29 16:19 ` Prashant Rahul [this message]
2026-06-29 19:40 ` Dan Carpenter
2026-06-29 7:24 ` [PATCH 0/4] staging: octeon: Improve initialization error handling Dan Carpenter
2026-06-29 8:25 ` Prashant Rahul
2026-06-29 8:45 ` Dan Carpenter
2026-06-29 20:20 ` Klara Modin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJLO4N0H5YYF.1GOPQDJ9QVG4A@gmail.com \
--to=prashantrahul23@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.