From: Dan Carpenter <error27@gmail.com>
To: Prashant Rahul <prashantrahul23@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] staging: octeon: Improve initialization error handling
Date: Mon, 29 Jun 2026 10:24:57 +0300 [thread overview]
Message-ID: <akIdyUhcH6O-Iczx@stanley.mountain> (raw)
In-Reply-To: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com>
On Sun, Jun 28, 2026 at 12:31:23PM +0530, Prashant Rahul wrote:
> Hi all,
>
> The TX and RX initialization paths currently call panic() on some
> initialization failures. Instead, these failures should be reported back
> to the probe function so that it can unwind any resources acquired during
> initialization and fail gracefully.
>
> This series replaces those panic() calls with proper error logging, propagates
> the errors to the probe function, and adds the necessary cleanup to avoid
> leaving the driver in a partially initialized state.
>
> This is my first time working with drivers, so please let me know if I
> have made any mistakes.
>
> Thank you! :3
>
> Signed-off-by: Prashant Rahul <prashantrahul23@gmail.com>
> ---
You need to say when you haven't tested your code.
You need to say when you're using AI to write patches. There is
a format for it.
Documentation/process/coding-assistants.rst
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-29 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 7:01 [PATCH 0/4] staging: octeon: Improve initialization error handling Prashant Rahul
2026-06-28 7:01 ` [PATCH 1/4] staging: octeon: factor out device removal into a helper Prashant Rahul
2026-06-29 7:25 ` Dan Carpenter
2026-06-29 7:45 ` Dan Carpenter
2026-06-28 7:01 ` [PATCH 2/4] staging: octeon: Propagate rx initialization failures Prashant Rahul
2026-06-28 7:01 ` [PATCH 3/4] staging: octeon: Propagate tx " Prashant Rahul
2026-06-28 7:01 ` [PATCH 4/4] staging: octeon: handle rx/tx initialization failures in probe Prashant Rahul
2026-06-29 7:44 ` Dan Carpenter
2026-06-29 16:19 ` Prashant Rahul
2026-06-29 19:40 ` Dan Carpenter
2026-06-29 7:24 ` Dan Carpenter [this message]
2026-06-29 8:25 ` [PATCH 0/4] staging: octeon: Improve initialization error handling Prashant Rahul
2026-06-29 8:45 ` Dan Carpenter
2026-06-29 20:20 ` Klara Modin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akIdyUhcH6O-Iczx@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=prashantrahul23@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.