All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Dave Airlie" <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH] nouveau/instmem: use iomapping interface for instmem handling
Date: Wed, 01 Jul 2026 23:52:55 +0200	[thread overview]
Message-ID: <DJNKGRGHSFEA.2KYSDR2HKUEC4@kernel.org> (raw)
In-Reply-To: <20260623223320.3837840-1-airlied@gmail.com>

On Wed Jun 24, 2026 at 12:33 AM CEST, Dave Airlie wrote:
> @@ -172,8 +175,7 @@ nv50_instobj_kmap(struct nv50_instobj *iobj, struct nvkm_vmm *vmm)
>  
>  	/* Make the mapping visible to the host. */
>  	iobj->bar = bar;
> -	iobj->map = ioremap_wc(device->func->resource_addr(device, NVKM_BAR2_INST) +
> -			       (u32)iobj->bar->addr, size);
> +	iobj->map = io_mapping_map_wc(&imem->iomap, iobj->bar->addr, size);

Apparently, the u32 cast was there for a reason. nv50_bar_oneinit() creates the
BAR2 VMM with a 4GiB base, so iobj->bar->addr includes a 4GiB offset that was
truncated by the cast.

WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Dave Airlie" <airlied@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>, <nouveau@lists.freedesktop.org>
Subject: Re: [PATCH] nouveau/instmem: use iomapping interface for instmem handling
Date: Wed, 01 Jul 2026 23:52:55 +0200	[thread overview]
Message-ID: <DJNKGRGHSFEA.2KYSDR2HKUEC4@kernel.org> (raw)
In-Reply-To: <20260623223320.3837840-1-airlied@gmail.com>

On Wed Jun 24, 2026 at 12:33 AM CEST, Dave Airlie wrote:
> @@ -172,8 +175,7 @@ nv50_instobj_kmap(struct nv50_instobj *iobj, struct nvkm_vmm *vmm)
>  
>  	/* Make the mapping visible to the host. */
>  	iobj->bar = bar;
> -	iobj->map = ioremap_wc(device->func->resource_addr(device, NVKM_BAR2_INST) +
> -			       (u32)iobj->bar->addr, size);
> +	iobj->map = io_mapping_map_wc(&imem->iomap, iobj->bar->addr, size);

Apparently, the u32 cast was there for a reason. nv50_bar_oneinit() creates the
BAR2 VMM with a 4GiB base, so iobj->bar->addr includes a 4GiB offset that was
truncated by the cast.

  parent reply	other threads:[~2026-07-01 21:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 22:33 [PATCH] nouveau/instmem: use iomapping interface for instmem handling Dave Airlie
2026-06-23 22:49 ` sashiko-bot
2026-07-01 21:52 ` Danilo Krummrich [this message]
2026-07-01 21:52   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJNKGRGHSFEA.2KYSDR2HKUEC4@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.